Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
33 | abstract class MiddlewareAbstract extends ObjectAbstract implements MiddlewareInterface |
||
34 | { |
||
35 | /** |
||
36 | * Make process logic clear ! |
||
37 | * |
||
38 | * {@inheritDoc} |
||
39 | */ |
||
40 | View Code Duplication | public function process( |
|
56 | |||
57 | /** |
||
58 | * Doing stuff before calling next middleware |
||
59 | * |
||
60 | * @param RequestInterface $request |
||
61 | * @param ResponseInterface $response |
||
62 | * @access protected |
||
63 | */ |
||
64 | abstract protected function before( |
||
68 | |||
69 | /** |
||
70 | * Doing stuff after next middleware called |
||
71 | * |
||
72 | * @param RequestInterface $request |
||
73 | * @param ResponseInterface $response |
||
74 | * @access protected |
||
75 | */ |
||
76 | abstract protected function after( |
||
80 | } |
||
81 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.