RedirectToHttps::redirectIt() - Code Metrics - phossa2/libs - Measure and Improve Code Quality continuously with Scrutinizer

RedirectToHttps::redirectIt() A
last analyzed 2016-10-12 00:59 UTC

↳ Parent: RedirectToHttps

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1

<?php
/**
 * Phossa Project
 *
 * PHP version 5.4
 *
 * @category  Library
 * @package   Phossa2\Route
 * @copyright Copyright (c) 2016 phossa.com
 * @license   http://mit-license.org/ MIT License
 * @link      http://www.phossa.com/
 */
/*# declare(strict_types=1); */

namespace Phossa2\Route\Extension;

use Phossa2\Route\Status;
use Phossa2\Route\Dispatcher;
use Phossa2\Event\Interfaces\EventInterface;
use Phossa2\Route\Interfaces\ResultInterface;
use Phossa2\Event\EventableExtensionAbstract;

/**
 * RedirectToHttps
 *
 * If connection is not secure (not https), set the result status to
 * Status::MOVED_PERMANENTLY and return FALSE
 *
 * @package Phossa2\Route
 * @author  Hong Zhang <[email protected]>
 * @see     EventableExtensionAbstract
 * @see     ResultInterface
 * @version 2.0.0
 * @since   2.0.0 added
 */
class RedirectToHttps extends EventableExtensionAbstract
{
    /**
     * {@inheritDoc}
     */
    public function methodsAvailable()/*# : array */
    {
        return ['redirectIt'];
    }

    /**
     * Extension methods takes an event as input.
     *
     * Event params has `Phossa2\Route\Result` set as 'result'
     *
     * MUST RETURN A BOOLEAN VALUE !!!
     *
     * @param  EventInterface $event
     * @return bool
     * @access protected
     */
    public function redirectIt(EventInterface $event)/*# : bool */
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        /* @var ResultInterface $result */
        $result = $event->getParam('result');

        if (!isset($_SERVER['HTTPS'])) {
            $result->setStatus(Status::MOVED_PERMANENTLY);
            return false;
        }
        return true;
    }

    /**
     * Return event handlers of this extension handling
     *
     * ```php
     * protected function extensionHandles()
     * {
     *     return [
     *         ['event' => 'cache.*', 'handler' => ['byPassCache', 100]],
     *     ];
     * }
     * ```
     *
     * @return array
     * @access protected
     */
    protected function extensionHandles()/*# : array */
    {
        return [
            [
                'event' => Dispatcher::EVENT_BEFORE_MATCH,
                'handler' => 'redirectIt'
            ]
        ];
    }
}


1			<?php
2			/**
3			* Phossa Project
4			*
5			* PHP version 5.4
6			*
7			* @category Library
8			* @package Phossa2\Route
9			* @copyright Copyright (c) 2016 phossa.com
10			* @license http://mit-license.org/ MIT License
11			* @link http://www.phossa.com/
12			*/
13			/# declare(strict_types=1); /
14
15			namespace Phossa2\Route\Extension;
16
17			use Phossa2\Route\Status;
18			use Phossa2\Route\Dispatcher;
19			use Phossa2\Event\Interfaces\EventInterface;
20			use Phossa2\Route\Interfaces\ResultInterface;
21			use Phossa2\Event\EventableExtensionAbstract;
22
23			/**
24			* RedirectToHttps
25			*
26			* If connection is not secure (not https), set the result status to
27			* Status::MOVED_PERMANENTLY and return FALSE
28			*
29			* @package Phossa2\Route
30			* @author Hong Zhang <[email protected]>
31			* @see EventableExtensionAbstract
32			* @see ResultInterface
33			* @version 2.0.0
34			* @since 2.0.0 added
35			*/
36			class RedirectToHttps extends EventableExtensionAbstract
37			{
38			/**
39			* {@inheritDoc}
40			*/
41			public function methodsAvailable()/# : array /
42			{
43			return ['redirectIt'];
44			}
45
46			/**
47			* Extension methods takes an event as input.
48			*
49			* Event params has `Phossa2\Route\Result` set as 'result'
50			*
51			* MUST RETURN A BOOLEAN VALUE !!!
52			*
53			* @param EventInterface $event
54			* @return bool
55			* @access protected
56			*/
57			public function redirectIt(EventInterface $event)/# : bool /
			0 ignored issues – show Coding Style introduced 2016-09-27 11:59 UTC by Report Bug Copy Issue Report `redirectIt` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
58			{
59			/* @var ResultInterface $result */
60			$result = $event->getParam('result');
61
62			if (!isset($_SERVER['HTTPS'])) {
63			$result->setStatus(Status::MOVED_PERMANENTLY);
64			return false;
65			}
66			return true;
67			}
68
69			/**
70			* Return event handlers of this extension handling
71			*
72			* ```php
73			* protected function extensionHandles()
74			* {
75			* return [
76			* ['event' => 'cache.*', 'handler' => ['byPassCache', 100]],
77			* ];
78			* }
79			* ```
80			*
81			* @return array
82			* @access protected
83			*/
84			protected function extensionHandles()/# : array /
85			{
86			return [
87			[
88			'event' => Dispatcher::EVENT_BEFORE_MATCH,
89			'handler' => 'redirectIt'
90			]
91			];
92			}
93			}
94

phossa2 / libs

RedirectToHttps::redirectIt() A last analyzed 2016-10-12 00:59 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RedirectToHttps::redirectIt() A
last analyzed 2016-10-12 00:59 UTC