ArrayList::get() - Code Metrics - Inspection of "Move `get` and `indexOf` methods" - phootwork/collection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Cristiano

created 2018-10-05 16:20 UTC

ArrayList::get() A

↳ Parent: ArrayList::remove()

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php
namespace phootwork\collection;

use \Iterator;

/**
 * Represents a List
 * 
 * @author Thomas Gossmann
 */
class ArrayList extends AbstractList {
	
	/**
	 * Creates a new ArrayList
	 * 
	 * @param array|Iterator $collection
	 */
	public function __construct($collection = []) {
		$this->addAll($collection);
	}
	
	/**
	 * Adds an element to that list
	 * 
	 * @param mixed $element
	 * @param int $index
	 * @return $this
	 */
	public function add($element, $index = null) {
		if ($index === null) {
			$this->collection[$this->size()] = $element;
		} else {
			array_splice($this->collection, $index, 0, $element);
		}
		
		return $this;
	}
	
	/**
	 * Adds all elements to the list
	 * 
	 * @param array|Iterator $collection
	 * @return $this
	 */
	public function addAll($collection) {
		foreach ($collection as $element) {
			$this->add($element);
		}
		
		return $this;
	}

	/**
	 * Removes an element from the list
	 * 
	 * @param mixed $element
	 * @return $this
	 */
	public function remove($element) {
		$index = array_search($element, $this->collection, true);
		if ($index !== null) {
			unset($this->collection[$index]);
		}

		return $this;
	}

	/**
	 * Removes all elements from the list
	 *
	 * @param array|Iterator $collection
	 * @return $this
	 */
	public function removeAll($collection) {
		foreach ($collection as $element) {
			$this->remove($element);
		}
		
		return $this;
	}

}


1		<?php
2		namespace phootwork\collection;
3
4		use \Iterator;
5
6		/**
7		* Represents a List
8		*
9		* @author Thomas Gossmann
10		*/
11		class ArrayList extends AbstractList {
12
13		/**
14		* Creates a new ArrayList
15		*
16		* @param array\|Iterator $collection
17		*/
18	24	public function __construct($collection = []) {
19	24	$this->addAll($collection);
20	24	}
21
22		/**
23		* Adds an element to that list
24		*
25		* @param mixed $element
26		* @param int $index
27		* @return $this
28		*/
29	24	public function add($element, $index = null) {
30	24	if ($index === null) {
31	24	$this->collection[$this->size()] = $element;
32		} else {
33	1	array_splice($this->collection, $index, 0, $element);
34		}
35
36	24	return $this;
37		}
38
39		/**
40		* Adds all elements to the list
41		*
42		* @param array\|Iterator $collection
43		* @return $this
44		*/
45	24	public function addAll($collection) {
46	24	foreach ($collection as $element) {
47	18	$this->add($element);
48		}
49
50	24	return $this;
51		}
52
53		/**
54		* Removes an element from the list
55		*
56		* @param mixed $element
57		* @return $this
58		*/
59	2	public function remove($element) {
60	2	$index = array_search($element, $this->collection, true);
61	2	if ($index !== null) {
62	2	unset($this->collection[$index]);
63		}
64
65	2	return $this;
66		}
67
68		/**
69		* Removes all elements from the list
70		*
71		* @param array\|Iterator $collection
72		* @return $this
73		*/
74	2	public function removeAll($collection) {
75	2	foreach ($collection as $element) {
76	2	$this->remove($element);
77		}
78
79	2	return $this;
80		}
81
82		}
83

phootwork / collection

Pull Request — master (#3)

ArrayList::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like