Phoole\Config\Util\ArrayAccessTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	offsetUnset()	0	3	1
A	offsetSet()	0	3	1
A	offsetGet()	0	3	1
A	offsetExists()	0	3	1

<?php

/**
 * Phoole (PHP7.2+)
 *
 * @category  Library
 * @package   Phoole\Config
 * @copyright Copyright (c) 2019 Hong Zhang
 */
declare(strict_types=1);

namespace Phoole\Config\Util;

/**
 * Implementation of \ArrayAccess
 *
 * @package Phoole\Config
 * @see     \ArrayAccess
 */
trait ArrayAccessTrait
{
    public function offsetExists($offset): bool
    {
        return $this->has($offset);

It seems like has() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function offsetGet($offset)
    {
        return $this->get($offset);

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function offsetSet($offset, $value): void

The parameter $value is not used and could be removed.

The parameter $offset is not used and could be removed.

    {
        throw new \RuntimeException("config is immutable");
    }

    public function offsetUnset($offset): void

The parameter $offset is not used and could be removed.

    {
        throw new \RuntimeException("config is immutable");
    }
}