YourMembershipServiceProvider::register() - Code Metrics - Inspection of "Fix Provider typos" - phone2action/ym-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 0.1-dev ( 2d539f...0d1b7d )

by Petr

created 2017-01-12 18:53 UTC

YourMembershipServiceProvider::register() A

↳ Parent: YourMembershipServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	1
eloc	6
nc	1
nop	0

<?php
namespace P2A\YourMembership;

use Illuminate\Support\ServiceProvider;
use P2A\YourMembership\YourMembershipClient;

class YourMembershipServiceProvider extends ServiceProvider
{

	private $packageName = 'yourmembership';
	private $packageConfigPath = __DIR__.'/config/yourmembership.php';
	/**
	 * Indicates if loading of the provider is deferred.
	 *
	 * @var bool
	 */
	protected $defer = true;

	/**
	 * Register the service provider.
	 *
	 * @return void
	 */
	public function register()
	{
		$this->mergeConfigFrom(
	    	$this->packageConfigPath, $this->packageName
		);

		$this->app->register(YourMembershipClient::class, function($app, $parameters) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$guzzleClient = new \GuzzleHttp\Client($app['config']['yourmembership']['guzzle-client']);
			return new YourMembershipClient($guzzleClient, $parameters[0], $parameters[1]);
		});
	}

	public function boot()
	{
		$this->publishes([
		$this->packageConfigPath => config_path('yourmembership.php'),
		]);
	}

	/**
	 * Get the services provided by the provider.
	 *
	 * @return array
	 */
	public function provides()
	{
		return array(YourMembershipClient::class);
	}

}


1			<?php
2			namespace P2A\YourMembership;
3
4			use Illuminate\Support\ServiceProvider;
5			use P2A\YourMembership\YourMembershipClient;
6
7			class YourMembershipServiceProvider extends ServiceProvider
8			{
9
10			private $packageName = 'yourmembership';
11			private $packageConfigPath = __DIR__.'/config/yourmembership.php';
12			/**
13			* Indicates if loading of the provider is deferred.
14			*
15			* @var bool
16			*/
17			protected $defer = true;
18
19			/**
20			* Register the service provider.
21			*
22			* @return void
23			*/
24			public function register()
25			{
26			$this->mergeConfigFrom(
27			$this->packageConfigPath, $this->packageName
28			);
29
30			$this->app->register(YourMembershipClient::class, function($app, $parameters) {
			1 ignored issue – show Documentation introduced 2017-01-12 19:00 UTC by Report Bug Copy Issue Report `function ($app, $paramet...[0], $parameters[1]); }` is of type `object<Closure>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31			$guzzleClient = new \GuzzleHttp\Client($app['config']['yourmembership']['guzzle-client']);
32			return new YourMembershipClient($guzzleClient, $parameters[0], $parameters[1]);
33			});
34			}
35
36			public function boot()
37			{
38			$this->publishes([
39			$this->packageConfigPath => config_path('yourmembership.php'),
40			]);
41			}
42
43			/**
44			* Get the services provided by the provider.
45			*
46			* @return array
47			*/
48			public function provides()
49			{
50			return array(YourMembershipClient::class);
51			}
52
53			}
54

phone2action / ym-api

Push — 0.1-dev ( 2d539f...0d1b7d )

YourMembershipServiceProvider::register() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like