phmLabs / Smoke

src/Rules/Xml/Rss/ValidRule.php

Spacing +6 added lines, -6 removed lines

@@ -23,12 +23,12 @@ 
 
     private function getSchema()
     {
-        return __DIR__ . '/' . self::SCHEMA;
+        return __DIR__.'/'.self::SCHEMA;
     }
 
     public function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         if (preg_match('/<rss/', $body)) {
             libxml_clear_errors();
@@ -38,8 +38,8 @@ 
 
             if ($lastError) {
                 throw new ValidationFailedException(
-                    'The given xml file is not well formed (last error: ' .
-                    str_replace("\n", '', $lastError->message) . ').');
+                    'The given xml file is not well formed (last error: '.
+                    str_replace("\n", '', $lastError->message).').');
             }
 
             $valid = @$dom->schemaValidate($this->getSchema());
@@ -49,11 +49,11 @@ 
                 $lastErrorMessage = str_replace("\n", '', $lastError->message);
 
                 if ($response instanceof UriAwareResponse) {
-                    $toolUrl = sprintf(self::PUBLIC_SERVICE, urlencode((string)$response->getUri()));
+                    $toolUrl = sprintf(self::PUBLIC_SERVICE, urlencode((string) $response->getUri()));
                 } else {
                     $toolUrl = '';
                 }
-                return new CheckResult(CheckResult::STATUS_FAILURE, 'The given xml file is not a valid rss file (last error: ' . $lastErrorMessage . ').', null, $toolUrl);
+                return new CheckResult(CheckResult::STATUS_FAILURE, 'The given xml file is not a valid rss file (last error: '.$lastErrorMessage.').', null, $toolUrl);
             }
         }
         return new CheckResult(CheckResult::STATUS_SUCCESS, 'The given rss file is valid.');

src/Extensions/SmokeResponseRetriever/Retriever/Crawler/Filter/LongUrlFilter.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
      */
     public function isFiltered(UriInterface $currentUri, UriInterface $startUri)
     {
-        return strlen((string)$currentUri) > 255;
+        return strlen((string) $currentUri) > 255;
     }
 
     public function isResponseFiltered(ResponseInterface $response, UriInterface $startUri)

src/Rules/Seo/RobotsDisallowAllRule.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use phm\HttpWebdriverClient\Http\Response\UriAwareResponse;
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\ClientAware;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Spacing +4 added lines, -4 removed lines

@@ -21,12 +21,12 @@ 
     public function validate(ResponseInterface $response)
     {
         if ($response instanceof UriAwareResponse) {
-            $url = $response->getUri()->getScheme() . '://' . $response->getUri()->getHost();
+            $url = $response->getUri()->getScheme().'://'.$response->getUri()->getHost();
 
             if (substr_count($url, '/') === 2) {
-                $filename = $robotsUrl = $url . '/robots.txt';
+                $filename = $robotsUrl = $url.'/robots.txt';
             } elseif (substr_count($url, '/') === 3) {
-                $filename = $robotsUrl = $url . 'robots.txt';
+                $filename = $robotsUrl = $url.'robots.txt';
             } else {
                 return;
             }
@@ -39,7 +39,7 @@ 
 
             $normalizedContent = $this->normalizeContent($content);
 
-            if (strpos($normalizedContent, 'user-agent:* disallow:/' . PHP_EOL) !== false) {
+            if (strpos($normalizedContent, 'user-agent:* disallow:/'.PHP_EOL) !== false) {
                 throw new ValidationFailedException('The robots.txt contains disallow all (Disallow: /)');
             }
 

src/Rules/Xml/XmlValidXsdRule.php

Spacing +3 added lines, -3 removed lines

@@ -26,7 +26,7 @@ 
      */
     protected function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         $dom = new \DOMDocument();
         @$dom->loadXML($body);
@@ -41,12 +41,12 @@ 
                 $error = true;
                 $lastError = libxml_get_last_error();
 
-                $messageParts[] = $xsdFile['xsdfilename'] . ' - ' . $xsdFile['xsdfileurl'] . ' (last error: ' . str_replace("\n", '', $lastError->message) . ').';
+                $messageParts[] = $xsdFile['xsdfilename'].' - '.$xsdFile['xsdfileurl'].' (last error: '.str_replace("\n", '', $lastError->message).').';
             }
         }
 
         if ($error === true) {
-            $message = 'XML file (' . (string)$response->getUri() . ')  does not validate against the following XSD files: ' . implode(', ', $messageParts);
+            $message = 'XML file ('.(string) $response->getUri().')  does not validate against the following XSD files: '.implode(', ', $messageParts);
             throw new ValidationFailedException($message);
         }
     }

src/Scanner/Scanner.php

Spacing +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
                     $result = new CheckResult(CheckResult::STATUS_SUCCESS, 'Check successful.');
                 }
             } catch (\Exception $e) {
-                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occurred: ' . $e->getMessage());
+                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occurred: '.$e->getMessage());
                 $this->eventDispatcher->simpleNotify('Scanner.CheckResponse.Rule.Error', array('checkResult' => $result, 'ruleName' => $name, 'exception' => $e));
             }
 

src/Rules/Seo/GoogleMobileFriendlyRule.php

Spacing +4 added lines, -4 removed lines

@@ -15,7 +15,7 @@ 
 
     private function getEndpoint(UriInterface $uri)
     {
-        return str_replace('#url#', urlencode((string)$uri), self::ENDPOINT);
+        return str_replace('#url#', urlencode((string) $uri), self::ENDPOINT);
     }
 
     public function validate(ResponseInterface $response)
@@ -38,7 +38,7 @@ 
             )));
 
         if (property_exists($result, 'error')) {
-            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
+            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
             $checkResult->addAttribute(new Attribute('Google response', json_encode($result), true));
             return $checkResult;
         }
@@ -46,10 +46,10 @@ 
         $passResult = $result->ruleGroups->USABILITY;
 
         if (!$passResult->pass) {
-            $result = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+            $result = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
 
         } else {
-            $result = new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+            $result = new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
         }
 
         $result->addAttribute(new Attribute('google_result', json_encode($result), true));

src/Http/GuzzleClient.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      */
     public function init($nocache = true, $clientTimeout = 20000)
     {
-        $timeoutInSeconds = (int)($clientTimeout / 1000);
+        $timeoutInSeconds = (int) ($clientTimeout / 1000);
 
         if ($nocache) {
             $this->guzzleClient = new phmGuzzleClient(null, $timeoutInSeconds);

src/Rules/CheckResult.php

Doc Comments +3 added lines, -2 removed lines

@@ -42,6 +42,7 @@ 
      * @param $status
      * @param $value
      * @param $message
+     * @param string $url
      */
     public function __construct($status, $message = '', $value = null, $url = null)
     {
@@ -73,7 +74,7 @@ 
     }
 
     /**
-     * @param Attribute $attributes
+     * @param Attribute $attribute
      */
     public function addAttribute(Attribute $attribute)
     {
@@ -136,7 +137,7 @@ 
     }
 
     /**
-     * @param string $identifier
+     * @param string $identifierRule
      */
     public function setIdentifierRule($identifierRule)
     {