Completed
Push — master ( 364b5f...c78d5c )
by Nils
02:35
created
src/Rules/Xml/Sitemap/ValidRule.php 2 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -16,11 +16,18 @@
 block discarded – undo
16 16
 
17 17
     protected $contentTypes = array('text/xml', 'application/xml');
18 18
 
19
+    /**
20
+     * @param boolean $isIndex
21
+     */
19 22
     private function getSchema($isIndex)
20 23
     {
21 24
         return ($isIndex) ?  __DIR__ . '/' . self::INDEX : __DIR__ . '/' . self::SCHEMA;
22 25
     }
23 26
 
27
+    /**
28
+     * @param \Psr\Http\Message\StreamInterface $body
29
+     * @param string $filename
30
+     */
24 31
     private function validateBody($body, $filename, $isIndex = TRUE)
25 32
     {
26 33
         $dom = new \DOMDocument();
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -27,13 +27,13 @@  discard block
 block discarded – undo
27 27
     private function getSchema($isIndex)
28 28
     {
29 29
         if ($isIndex) {
30
-            return __DIR__ . '/' . self::INDEX;
30
+            return __DIR__.'/'.self::INDEX;
31 31
         }
32 32
 
33 33
         if ($this->strictMode) {
34
-            return __DIR__ . '/' . self::SCHEMA;
34
+            return __DIR__.'/'.self::SCHEMA;
35 35
         } else {
36
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
36
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
37 37
         }
38 38
     }
39 39
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         if (!$valid) {
48 48
             $lastError = libxml_get_last_error();
49 49
             throw new ValidationFailedException(
50
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
50
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
51 51
         }
52 52
     }
53 53
 
@@ -79,9 +79,9 @@  discard block
 block discarded – undo
79 79
 
80 80
         // sitemapindex or urlset
81 81
         if (preg_match('/<sitemapindex/', $body)) {
82
-            $this->validateBody($body, (string)$response->getUri());
82
+            $this->validateBody($body, (string) $response->getUri());
83 83
         } elseif (preg_match('/<urlset/', $body)) {
84
-            $this->validateBody($body, (string)$response->getUri(), false);
84
+            $this->validateBody($body, (string) $response->getUri(), false);
85 85
         }
86 86
     }
87 87
 }
Please login to merge, or discard this patch.
src/Rules/Xml/XmlCheckRule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,8 +21,8 @@
 block discarded – undo
21 21
         if (!$success) {
22 22
             $lastError = libxml_get_last_error();
23 23
 
24
-            throw new ValidationFailedException('The xml file ' . $response->getUri() . ' is not well formed (last error: ' .
25
-                str_replace("\n", '', $lastError->message) . ').');
24
+            throw new ValidationFailedException('The xml file '.$response->getUri().' is not well formed (last error: '.
25
+                str_replace("\n", '', $lastError->message).').');
26 26
         }
27 27
     }
28 28
 }
Please login to merge, or discard this patch.
src/Rules/Html/CssSelectorExistsRule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
         if ($error === true) {
47 47
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
48 48
 
49
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors .'" not found in DOM.');
49
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
50 50
         }
51 51
     }
52 52
 }
Please login to merge, or discard this patch.
src/Rules/Json/JsonPathExistsRule.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -65,17 +65,17 @@
 block discarded – undo
65 65
 
66 66
             if ($jsonValue === FALSE || (is_array($jsonValue) && empty($jsonValue))) {
67 67
                 $error = true;
68
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (JSON Path not found)';
68
+                $noCorrectJsonPaths[] = $path['pattern'].' (JSON Path not found)';
69 69
             }
70 70
             if ($this->checkRelation($path['relation'], $path['value'], $count) === false) {
71 71
                 $error = true;
72
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (number of JSONPaths is not correct corresponding to the given relation/value)';
72
+                $noCorrectJsonPaths[] = $path['pattern'].' (number of JSONPaths is not correct corresponding to the given relation/value)';
73 73
             }
74 74
         }
75 75
 
76 76
         if ($error === true) {
77 77
             $allNoCorrectJsonPaths = implode('", "', $noCorrectJsonPaths);
78
-            throw new ValidationFailedException('Disonances with JSON Paths "' . $allNoCorrectJsonPaths . '!');
78
+            throw new ValidationFailedException('Disonances with JSON Paths "'.$allNoCorrectJsonPaths.'!');
79 79
         }
80 80
     }
81 81
 }
Please login to merge, or discard this patch.