phmLabs / Smoke

src/Rules/Html/InsecureContentRule.php

Spacing +2 added lines, -2 removed lines

@@ -27,13 +27,13 @@
             return;
         }
 
-        $htmlDocument = new Document((string)$response->getBody());
+        $htmlDocument = new Document((string) $response->getBody());
 
         $resources = $htmlDocument->getDependencies($uri, false);
 
         foreach ($resources as $resource) {
             if ($resource->getScheme() && 'https' !== $resource->getScheme()) {
-                throw new ValidationFailedException('At least one dependency was found on a secure url, that was transfered insecure (' . (string)$resource . ')');
+                throw new ValidationFailedException('At least one dependency was found on a secure url, that was transfered insecure ('.(string) $resource.')');
             }
         }
     }

src/Rules/Html/NoIndexRule.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
             return;
         }
 
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
         $metaTags = $crawler->filterXPath("//meta[@name='robots']/@content");
 
         foreach ($metaTags as $metaTag) {

src/Rules/Js/SyntaxRule.php

Spacing +6 added lines, -6 removed lines

@@ -30,18 +30,18 @@
             return;
         }
 
-        $filename = $this->tmpDir . DIRECTORY_SEPARATOR . md5((string)$response->getBody()) . '.js';
-        file_put_contents($filename, (string)$response->getBody());
-        $conf = __DIR__ . DIRECTORY_SEPARATOR . 'jsHint.conf';
+        $filename = $this->tmpDir.DIRECTORY_SEPARATOR.md5((string) $response->getBody()).'.js';
+        file_put_contents($filename, (string) $response->getBody());
+        $conf = __DIR__.DIRECTORY_SEPARATOR.'jsHint.conf';
 
-        $command = $this->jsHintExecutable . ' --config ' . $conf . ' --verbose ' . $filename . ' | grep -E E[0-9]+.$';
+        $command = $this->jsHintExecutable.' --config '.$conf.' --verbose '.$filename.' | grep -E E[0-9]+.$';
         $validationResult = shell_exec($command);
 
         unlink($filename);
 
         if (!is_null($validationResult)) {
-            $errorMsg = str_replace($filename . ':', '', $validationResult);
-            throw new ValidationFailedException('JavaScript error found: ' . $errorMsg);
+            $errorMsg = str_replace($filename.':', '', $validationResult);
+            throw new ValidationFailedException('JavaScript error found: '.$errorMsg);
         }
     }
 }

src/Rules/Image/SizeRule.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@
 
     protected function doValidation(ResponseInterface $response)
     {
-        $size = strlen((string)$response->getBody()) / 1000;
-        $this->assert($size <= $this->maxSize, 'The size of the file is too big (' . $size . ' KB)');
+        $size = strlen((string) $response->getBody()) / 1000;
+        $this->assert($size <= $this->maxSize, 'The size of the file is too big ('.$size.' KB)');
     }
 }

src/Cli/Command/SmokeCommand.php

Spacing +4 added lines, -4 removed lines

@@ -56,10 +56,10 @@ 
      */
     protected function writeSmokeCredentials($url = null)
     {
-        $this->output->writeln("\n Smoke " . SMOKE_VERSION . " by Nils Langner\n");
+        $this->output->writeln("\n Smoke ".SMOKE_VERSION." by Nils Langner\n");
 
         if ($url) {
-            $this->output->writeln(' <info>Scanning ' . $url . "</info>\n");
+            $this->output->writeln(' <info>Scanning '.$url."</info>\n");
         }
     }
 
@@ -89,12 +89,12 @@ 
         if ($configFile) {
             if (strpos($configFile, 'http://') === 0 || strpos($configFile, 'https://') === 0) {
                 $curlClient = new Client();
-                $fileContent = (string)$curlClient->get($configFile)->getBody();
+                $fileContent = (string) $curlClient->get($configFile)->getBody();
             } else {
                 if (file_exists($configFile)) {
                     $fileContent = file_get_contents($configFile);
                 } else {
-                    throw new \RuntimeException("Config file was not found ('" . $configFile . "').");
+                    throw new \RuntimeException("Config file was not found ('".$configFile."').");
                 }
             }
             $configArray = EnvAwareYaml::parse($fileContent);

src/Extensions/SmokeResponseRetriever/Retriever/ListRetriever/Retriever.php

Spacing +10 added lines, -10 removed lines

@@ -108,20 +108,20 @@ 
                     if (strpos($corruptUrl, '/') === 0) {
 
                         $mainUri = $request->getUri();
-                        $this->redirects[(string)$mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl] = (string)$mainUri;
+                        $this->redirects[(string) $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl] = (string) $mainUri;
 
-                        $this->urls[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
-                        $this->urlStack[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
+                        $this->urls[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
+                        $this->urlStack[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
 
                         return $this->next();
                     }
 
                     // the error handling should be done withing the calling class
-                    echo "\n   " . $exception->getMessage() . "\n";
+                    echo "\n   ".$exception->getMessage()."\n";
 
                     return $this->next();
                 } else {
-                    $errorMessages .= $exception->getMessage() . "\n";
+                    $errorMessages .= $exception->getMessage()."\n";
                 }
             }
             if ($errorMessages !== '') {
@@ -138,8 +138,8 @@ 
 
     public function getOriginUri(UriInterface $uri)
     {
-        if (array_key_exists((string)$uri, $this->redirects)) {
-            return $this->urls[$this->redirects[(string)$uri]]['url'];
+        if (array_key_exists((string) $uri, $this->redirects)) {
+            return $this->urls[$this->redirects[(string) $uri]]['url'];
         }
 
         return $uri;
@@ -152,11 +152,11 @@ 
 
     public function getSystem(UriInterface $uri)
     {
-        if (array_key_exists((string)$uri, $this->redirects)) {
-            return $this->urls[$this->redirects[(string)$uri]]['system'];
+        if (array_key_exists((string) $uri, $this->redirects)) {
+            return $this->urls[$this->redirects[(string) $uri]]['system'];
         }
 
-        return $this->urls[(string)$uri]['system'];
+        return $this->urls[(string) $uri]['system'];
     }
 
     public function getSystems()

src/Rules/CheckResult.php

Doc Comments +3 added lines, -3 removed lines

@@ -45,7 +45,7 @@ 
     }
 
     /**
-     * @param array $attributes
+     * @param array $attribute
      */
     public function addAttribute(Attribute $attribute)
     {
@@ -69,7 +69,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getMessage()
     {
@@ -85,7 +85,7 @@ 
     }
 
     /**
-     * @param Response $response
+     * @param ResponseInterface $response
      */
     public function setResponse(ResponseInterface $response)
     {

src/Rules/Html/BigContentRule.php

Spacing +2 added lines, -2 removed lines

@@ -36,12 +36,12 @@
         }
 
         if ($totalSize > $this->maxSize) {
-            $message = 'The total size of the file (and all assets) was ' . $totalSize . ' KB (max: ' . $this->maxSize . ' KB).';
+            $message = 'The total size of the file (and all assets) was '.$totalSize.' KB (max: '.$this->maxSize.' KB).';
             $result = new CheckResult(CheckResult::STATUS_FAILURE, $message, $totalSize);
             $result->addAttribute(new Attribute('resources', $response->getResources(), true));
             return $result;
         } else {
-            $message = 'The total size of the file (and all assets) was ' . $totalSize . ' KB (max: ' . $this->maxSize . ' KB).';
+            $message = 'The total size of the file (and all assets) was '.$totalSize.' KB (max: '.$this->maxSize.' KB).';
             $result = new CheckResult(CheckResult::STATUS_SUCCESS, $message, $totalSize);
             $result->addAttribute(new Attribute('resources', $response->getResources(), true));
             return $result;

src/Rules/Html/BigFilesRule.php

Spacing +2 added lines, -2 removed lines

@@ -38,9 +38,9 @@
         }
 
         if (count($bigFiles) > 0) {
-            $message = "Some files were found that are too big (max: " . $this->maxElementSize . " KB):<ul>";
+            $message = "Some files were found that are too big (max: ".$this->maxElementSize." KB):<ul>";
             foreach ($bigFiles as $bigFile) {
-                $message .= '<li>File: ' . $bigFile['name'] . ', Size: ' . $bigFile['size'] . ' KB</li>';
+                $message .= '<li>File: '.$bigFile['name'].', Size: '.$bigFile['size'].' KB</li>';
             }
             $message .= "</ul>";
             $result = new CheckResult(CheckResult::STATUS_FAILURE, $message, count($bigFiles));