phmLabs / Smoke

src/Cli/Command/CustomCommand.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
         $configArray = $this->getConfigArray($configFile, true);
 
         if (is_string($configArray)) {
-            throw new \RuntimeException('Unable to load config file. Please check ' . $configFile);
+            throw new \RuntimeException('Unable to load config file. Please check '.$configFile);
         }
 
         $this->config = new Configuration(new Uri('http://www.example.com'), $dispatcher, $configArray);

src/Extensions/SmokeReporter/Reporter/HtmlReporter.php

Spacing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
         $this->resultFile = $resultFile;
 
         if ($templateDir === null) {
-            $this->templateDir = __DIR__ . '/templates';
+            $this->templateDir = __DIR__.'/templates';
         } else {
             $this->templateDir = $templateDir;
         }
@@ -66,9 +66,9 @@ 
         }
 
         if (!file_put_contents($this->resultFile, $html)) {
-            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to " . $this->resultFile ."</error>");
+            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to ".$this->resultFile."</error>");
         } else {
-            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to " . $this->resultFile);
+            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to ".$this->resultFile);
         }
     }
 

src/Extensions/SmokeReporter/Reporter/KoalamonSummaryReporter.php

Spacing +6 added lines, -6 removed lines

@@ -52,7 +52,7 @@ 
     const STATUS_SUCCESS = 'success';
     const STATUS_FAILURE = 'failure';
 
-    public function init($apiKey, Configuration $_configuration, OutputInterface $_output, $server = 'https://webhook.koalamon.com', $system = '', $identifier = '', $tool = '', $url ='')
+    public function init($apiKey, Configuration $_configuration, OutputInterface $_output, $server = 'https://webhook.koalamon.com', $system = '', $identifier = '', $tool = '', $url = '')
     {
         $httpClient = new \GuzzleHttp\Client();
 
@@ -82,7 +82,7 @@ 
     public function processResults($results)
     {
         foreach ($results as $result) {
-            if($result->getStatus() == CheckResult::STATUS_SUCCESS) {
+            if ($result->getStatus() == CheckResult::STATUS_SUCCESS) {
                 $this->success++;
             } else {
                 $this->failed++;
@@ -93,8 +93,8 @@ 
     public function finish()
     {
         $message = 'Checks: ';
-        $message .= $this->success . ' succeeded, ';
-        $message .= $this->failed . ' failed. ';
+        $message .= $this->success.' succeeded, ';
+        $message .= $this->failed.' failed. ';
 
         if ($this->failed > 0) {
             $status = Event::STATUS_FAILURE;
@@ -129,8 +129,8 @@ 
                 $this->reporter->sendEvent($event);
             } catch (KoalamonException $e) {
                 $this->output->writeln("\n  <error> Error sending result to leankoala. </error>");
-                $this->output->writeln('   Url: ' . $e->getUrl());
-                $this->output->writeln('   Payload: ' . $e->getPayload());
+                $this->output->writeln('   Url: '.$e->getUrl());
+                $this->output->writeln('   Payload: '.$e->getPayload());
                 $this->output->writeln("");
             } catch (\Exception $e) {
                 $this->output->writeln($e->getMessage());

src/Scanner/Scanner.php

Spacing +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
             } catch (ValidationFailedException $e) {
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $e->getMessage());
             } catch (\Exception $e) {
-                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: ' . $e->getMessage());
+                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: '.$e->getMessage());
             }
 
             $this->eventDispatcher->simpleNotify('Scanner.CheckResponse.Rule', array('checkResult' => $result, 'ruleName' => $name));

src/Config/Configuration.php

Spacing +4 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
     private function initConfigArray(array $configArray, array $defaultSettings = null)
     {
         if ($defaultSettings === null) {
-            $defaultSettings = Yaml::parse(file_get_contents(__DIR__ . '/../settings/' . self::DEFAULT_SETTINGS));
+            $defaultSettings = Yaml::parse(file_get_contents(__DIR__.'/../settings/'.self::DEFAULT_SETTINGS));
         }
 
         if (count($configArray) === 0) {
@@ -169,7 +169,7 @@ 
         if ($this->hasSection($section)) {
             return $this->configArray[$section];
         } else {
-            throw new \RuntimeException('The section (' . $section . ') you are trying to access does not exist.');
+            throw new \RuntimeException('The section ('.$section.') you are trying to access does not exist.');
         }
     }
 
@@ -178,7 +178,7 @@ 
         if (array_key_exists($name, $this->extensions)) {
             return $this->extensions[$name];
         } else {
-            throw new \RuntimeException('The extension ("' . $name . '") you are trying to access does not exist. Registered extensions are: ' . implode(' ,', array_keys($this->extensions)) . '.');
+            throw new \RuntimeException('The extension ("'.$name.'") you are trying to access does not exist. Registered extensions are: '.implode(' ,', array_keys($this->extensions)).'.');
         }
     }
 
@@ -203,7 +203,7 @@ 
             try {
                 $client = Init::initialize($this->configArray['client']);
             } catch (\Exception $e) {
-                throw new ConfigurationException('Error initializing client (' . $e->getMessage() . ')');
+                throw new ConfigurationException('Error initializing client ('.$e->getMessage().')');
             }
 
             return $client;

src/Rules/Http/Header/GZipRule.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
             if (strpos($response->getContentType(), 'image') === false
                 && strpos($response->getContentType(), 'pdf') === false
                 && strpos($response->getContentType(), 'postscript') === false
-                && strlen((string)$response->getBody()) >= $this->minFileSize
+                && strlen((string) $response->getBody()) >= $this->minFileSize
             ) {
                 if (!$response->hasHeader('Content-Encoding') || $response->getHeader('Content-Encoding')[0] !== 'gzip') {
                     throw new ValidationFailedException('gzip compression not active');

src/Rules/Cookies/CountRule.php

Spacing +2 added lines, -2 removed lines

@@ -36,12 +36,12 @@
                 if ($cookieCount > $this->maxCookies) {
                     $result = new CheckResult(
                         CheckResult::STATUS_FAILURE,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 } else {
                     $result = new CheckResult(
                         CheckResult::STATUS_SUCCESS,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 }
 

src/Extensions/SmokeReporter/Reporter/CliReporter.php

Spacing +5 added lines, -5 removed lines

@@ -30,19 +30,19 @@
 
     protected function renderFailure(CheckResult $result)
     {
-        $this->output->writeln('   <error> ' . (string) $result->getResponse()->getUri() . ' </error> coming from ' . (string) $this->retriever->getComingFrom($result->getResponse()->getUri()));
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <error> '.(string) $result->getResponse()->getUri().' </error> coming from '.(string) $this->retriever->getComingFrom($result->getResponse()->getUri()));
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
         $this->output->writeln('');
     }
 
     protected function renderSuccess(CheckResult $result)
     {
-        $this->output->writeln('   <info> ' . (string) $result->getResponse()->getUri() . ' </info> all tests passed');
+        $this->output->writeln('   <info> '.(string) $result->getResponse()->getUri().' </info> all tests passed');
     }
 
     protected function renderSkipped(CheckResult $result)
     {
-        $this->output->writeln('   <comment> ' . (string) $result->getResponse()->getUri() . ' </comment>test skipped');
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <comment> '.(string) $result->getResponse()->getUri().' </comment>test skipped');
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
     }
 }

src/Extensions/SmokeReporter/Reporter/LeankoalaReporter.php

Spacing +14 added lines, -14 removed lines

@@ -128,7 +128,7 @@ 
         foreach ($this->results as $results) {
             foreach ($results as $result) {
                 /* @var CheckResult $result */
-                $tool = 'Smoke' . $result->getRuleName();
+                $tool = 'Smoke'.$result->getRuleName();
                 $checks[$tool][] = $result;
             }
         }
@@ -140,19 +140,19 @@ 
                 continue;
             }
 
-            $message = 'The smoke test for #system_name# failed (Rule: ' . $toolName . ').<ul>';
+            $message = 'The smoke test for #system_name# failed (Rule: '.$toolName.').<ul>';
             $status = Event::STATUS_SUCCESS;
             $failureCount = 0;
-            $identifier = $toolName . '_' . $this->system;
+            $identifier = $toolName.'_'.$this->system;
 
             foreach ($results as $result) {
                 /** @var CheckResult $result */
                 if ($result->getStatus() === CheckResult::STATUS_FAILURE) {
                     $comingFrom = '';
                     if ($this->addComingFrom && $this->retriever->getComingFrom($result->getResponse()->getUri())) {
-                        $comingFrom = ', coming from: ' . $this->retriever->getComingFrom($result->getResponse()->getUri());
+                        $comingFrom = ', coming from: '.$this->retriever->getComingFrom($result->getResponse()->getUri());
                     }
-                    $message .= '<li>' . $result->getMessage() . ' (url: ' . (string)$result->getResponse()->getUri() . $comingFrom . ')</li>';
+                    $message .= '<li>'.$result->getMessage().' (url: '.(string) $result->getResponse()->getUri().$comingFrom.')</li>';
                     ++$failureCount;
                 }
             }
@@ -163,12 +163,12 @@ 
                 $response = $firstResult->getResponse();
                 /** @var ResponseInterface $response */
 
-                $attributes[] = new Attribute('html-content', (string)$response->getBody(), true);
+                $attributes[] = new Attribute('html-content', (string) $response->getBody(), true);
                 if ($response instanceof TimeoutAwareResponse) {
                     $attributes[] = new Attribute('timeout', $response->isTimeout());
                 }
             } else {
-                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:' . $toolName . '].';
+                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:'.$toolName.'].';
             }
 
             $this->send($identifier, $this->system, $message, $status, $failureCount, $this->tool, $this->system, $attributes);
@@ -181,7 +181,7 @@ 
             foreach ($results as $result) {
                 /* @var CheckResult $result */
 
-                $identifier = '_' . $this->getIdentifier($result);
+                $identifier = '_'.$this->getIdentifier($result);
                 $tool = $this->getPrefix($result->getRuleName());
 
                 $component = $this->getComponent($result->getRuleName());
@@ -189,7 +189,7 @@ 
 
                 $attributes = array();
                 if ($result->getStatus() == CheckResult::STATUS_FAILURE) {
-                    $body = (string)$result->getResponse()->getBody();
+                    $body = (string) $result->getResponse()->getBody();
                     if ($body == "") {
                         $attributes[] = new Attribute('html content', '<empty>');
                     } else {
@@ -219,7 +219,7 @@ 
                     $this->send(
                         $identifier,
                         $currentSystem,
-                        $result->getMessage() . ' (url: ' . (string)$result->getResponse()->getUri() . ')',
+                        $result->getMessage().' (url: '.(string) $result->getResponse()->getUri().')',
                         $result->getStatus(),
                         $result->getValue(),
                         $tool,
@@ -235,12 +235,12 @@ 
     private function getIdentifier(CheckResult $result)
     {
         if ($this->useUrlAsIdentifier) {
-            $suffix = '_' . md5((string)$result->getResponse()->getUri());
+            $suffix = '_'.md5((string) $result->getResponse()->getUri());
         } else {
             $suffix = '';
         }
 
-        return $this->tool . '_' . $result->getRuleName() . $suffix;
+        return $this->tool.'_'.$result->getRuleName().$suffix;
     }
 
     private function getPrefix($string)
@@ -272,8 +272,8 @@ 
                 $this->reporter->sendEvent($event);
             } catch (KoalamonException $e) {
                 $this->output->writeln("\n  <error> Error sending result to leankoala. </error>");
-                $this->output->writeln('   Url: ' . $e->getUrl());
-                $this->output->writeln('   Payload: ' . $e->getPayload());
+                $this->output->writeln('   Url: '.$e->getUrl());
+                $this->output->writeln('   Payload: '.$e->getPayload());
                 $this->output->writeln("");
             } catch (\Exception $e) {
                 $this->output->writeln($e->getMessage());