phmLabs / Smoke

src/Rules/Html/NoIndexRule.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
             return;
         }
 
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
         $metaTags = $crawler->filterXPath("//meta[@name='robots']/@content");
 
         foreach ($metaTags as $metaTag) {

src/Rules/Js/SyntaxRule.php

Spacing +6 added lines, -6 removed lines

@@ -30,18 +30,18 @@
             return;
         }
 
-        $filename = $this->tmpDir . DIRECTORY_SEPARATOR . md5((string)$response->getBody()) . '.js';
-        file_put_contents($filename, (string)$response->getBody());
-        $conf = __DIR__ . DIRECTORY_SEPARATOR . 'jsHint.conf';
+        $filename = $this->tmpDir.DIRECTORY_SEPARATOR.md5((string) $response->getBody()).'.js';
+        file_put_contents($filename, (string) $response->getBody());
+        $conf = __DIR__.DIRECTORY_SEPARATOR.'jsHint.conf';
 
-        $command = $this->jsHintExecutable . ' --config ' . $conf . ' --verbose ' . $filename . ' | grep -E E[0-9]+.$';
+        $command = $this->jsHintExecutable.' --config '.$conf.' --verbose '.$filename.' | grep -E E[0-9]+.$';
         $validationResult = shell_exec($command);
 
         unlink($filename);
 
         if (!is_null($validationResult)) {
-            $errorMsg = str_replace($filename . ':', '', $validationResult);
-            throw new ValidationFailedException('JavaScript error found: ' . $errorMsg);
+            $errorMsg = str_replace($filename.':', '', $validationResult);
+            throw new ValidationFailedException('JavaScript error found: '.$errorMsg);
         }
     }
 }

src/Rules/Image/SizeRule.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@
 
     protected function doValidation(ResponseInterface $response)
     {
-        $size = strlen((string)$response->getBody()) / 1000;
-        $this->assert($size <= $this->maxSize, 'The size of the file is too big (' . $size . ' KB)');
+        $size = strlen((string) $response->getBody()) / 1000;
+        $this->assert($size <= $this->maxSize, 'The size of the file is too big ('.$size.' KB)');
     }
 }

src/Rules/Html/BigContentRule.php

Spacing +2 added lines, -2 removed lines

@@ -36,12 +36,12 @@
         }
 
         if ($totalSize > $this->maxSize) {
-            $message = 'The total size of the file (and all assets) was ' . $totalSize . ' KB (max: ' . $this->maxSize . ' KB).';
+            $message = 'The total size of the file (and all assets) was '.$totalSize.' KB (max: '.$this->maxSize.' KB).';
             $result = new CheckResult(CheckResult::STATUS_FAILURE, $message, $totalSize);
             $result->addAttribute(new Attribute('resources', $response->getResources(), true));
             return $result;
         } else {
-            $message = 'The total size of the file (and all assets) was ' . $totalSize . ' KB (max: ' . $this->maxSize . ' KB).';
+            $message = 'The total size of the file (and all assets) was '.$totalSize.' KB (max: '.$this->maxSize.' KB).';
             $result = new CheckResult(CheckResult::STATUS_SUCCESS, $message, $totalSize);
             $result->addAttribute(new Attribute('resources', $response->getResources(), true));
             return $result;

src/Rules/Html/BigFilesRule.php

Spacing +2 added lines, -2 removed lines

@@ -38,9 +38,9 @@
         }
 
         if (count($bigFiles) > 0) {
-            $message = "Some files were found that are too big (max: " . $this->maxElementSize . " KB):<ul>";
+            $message = "Some files were found that are too big (max: ".$this->maxElementSize." KB):<ul>";
             foreach ($bigFiles as $bigFile) {
-                $message .= '<li>File: ' . $bigFile['name'] . ', Size: ' . $bigFile['size'] . ' KB</li>';
+                $message .= '<li>File: '.$bigFile['name'].', Size: '.$bigFile['size'].' KB</li>';
             }
             $message .= "</ul>";
             $result = new CheckResult(CheckResult::STATUS_FAILURE, $message, count($bigFiles));

src/Extensions/SmokeOnFailure/OnFailureExtension.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 
     public function init($command)
     {
-        $this->callback = function () use ($command) {
+        $this->callback = function() use ($command) {
             return eval($command);
         };
     }

src/Rules/Html/ResourcesCountRule.php

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
 
     public function init($maxElements = 200)
     {
-        $this->maxElements = (int)$maxElements;
+        $this->maxElements = (int) $maxElements;
     }
 
     protected function doValidation(ResponseInterface $response)
@@ -28,12 +28,12 @@ 
         if ($response instanceof ResourcesAwareResponse) {
             $resourceCount = count($response->getResources());
             if ($resourceCount > $this->maxElements) {
-                $message = 'Too many resources were loaded. ' . $resourceCount . ' resources loaded, maximum was ' . $this->maxElements . '.';
+                $message = 'Too many resources were loaded. '.$resourceCount.' resources loaded, maximum was '.$this->maxElements.'.';
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $message, $resourceCount);
                 $result->addAttribute(new Attribute('resources', $response->getResources(), true));
                 return $result;
             } else {
-                $message = $resourceCount . ' resources were loaded.';
+                $message = $resourceCount.' resources were loaded.';
                 return new CheckResult(CheckResult::STATUS_SUCCESS, $message, $resourceCount);
             }
         } else {

src/Rules/Json/JsonPathExistsRule.php

Spacing +5 added lines, -5 removed lines

@@ -54,7 +54,7 @@ 
 
     public function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         $json = json_decode($body);
 
@@ -73,17 +73,17 @@ 
 
             if ($jsonValue === false || (is_array($jsonValue) && empty($jsonValue))) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (JSON path not found)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (JSON path not found)';
             }
-            if ($this->checkRelation($path['relation'], (int)$path['value'], $count) === false) {
+            if ($this->checkRelation($path['relation'], (int) $path['value'], $count) === false) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (' . $count . ' elements found, expected ' . $path['relation'] . ' ' . $path['value'] . ')';
+                $noCorrectJsonPaths[] = $path['pattern'].' ('.$count.' elements found, expected '.$path['relation'].' '.$path['value'].')';
             }
         }
 
         if ($error === true) {
             $allNoCorrectJsonPaths = implode('", "', $noCorrectJsonPaths);
-            throw new ValidationFailedException('Disonances with JSON Paths "' . $allNoCorrectJsonPaths . '!');
+            throw new ValidationFailedException('Disonances with JSON Paths "'.$allNoCorrectJsonPaths.'!');
         }
     }
 }

src/Rules/Http/HttpsCertificateExpireRule.php

Spacing +4 added lines, -4 removed lines

@@ -31,7 +31,7 @@ 
         } else {
 
             if ($certInfo['validFrom_time_t'] > time() || $certInfo['validTo_time_t'] < time()) {
-                $errorMessage = 'Certificate is expired. [' . $validFrom . ' - ' . $validTo . ']';
+                $errorMessage = 'Certificate is expired. ['.$validFrom.' - '.$validTo.']';
 
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $errorMessage);
                 $infoJson = json_encode($certInfo);
@@ -41,8 +41,8 @@ 
                     $result->addAttribute(new Attribute('certificate information', $infoJson, true));
                 }
                 return $result;
-            } elseif ($certInfo['validTo_time_t'] < strtotime('+' . $this->expireWarningTime . 'days')) {
-                $errorMessage = 'Certificate warning, expires in less than ' . $this->expireWarningTime . ' days. Certificate expires at: ' . $validTo;
+            } elseif ($certInfo['validTo_time_t'] < strtotime('+'.$this->expireWarningTime.'days')) {
+                $errorMessage = 'Certificate warning, expires in less than '.$this->expireWarningTime.' days. Certificate expires at: '.$validTo;
 
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $errorMessage);
                 $result->addAttribute(new Attribute('certificate information', json_encode($certInfo), true));
@@ -50,6 +50,6 @@ 
             }
         }
 
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'The certificate does not expire within the next ' . $this->expireWarningTime . ' days. Expire date: ' . $validTo . '.');
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'The certificate does not expire within the next '.$this->expireWarningTime.' days. Expire date: '.$validTo.'.');
     }
 }