phmLabs / Smoke

src/Rules/Seo/GoogleMobileFriendlyRule.php

Spacing +4 added lines, -4 removed lines

@@ -14,7 +14,7 @@ 
 
     private function getEndpoint(Uri $uri)
     {
-        return str_replace('#url#', urlencode((string)$uri), self::ENDPOINT);
+        return str_replace('#url#', urlencode((string) $uri), self::ENDPOINT);
     }
 
     public function validate(ResponseInterface $response)
@@ -33,7 +33,7 @@ 
             )));
 
         if (property_exists($result, 'error')) {
-            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
+            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
             $checkResult->addAttribute(new Attribute('Google response', json_encode($result), true));
             return $checkResult;
         }
@@ -41,9 +41,9 @@ 
         $passResult = $result->ruleGroups->USABILITY;
 
         if (!$passResult->pass) {
-            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
         }
 
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
     }
 }

src/Rules/Xml/Sitemap/ValidRule.php

Doc Comments +7 added lines

@@ -27,6 +27,9 @@ 
         $this->strictMode = $strictMode;
     }
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         if ($isIndex) {
@@ -40,6 +43,10 @@ 
         }
     }
 
+    /**
+     * @param string $body
+     * @param string $filename
+     */
     private function validateBody($body, $filename, $isIndex = true)
     {
         $dom = new \DOMDocument();

Spacing +7 added lines, -7 removed lines

@@ -30,13 +30,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -50,19 +50,19 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 
     protected function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         // sitemapindex or urlset
         if (preg_match('/<sitemapindex/', $body)) {
-            $this->validateBody($body, (string)$response->getUri());
+            $this->validateBody($body, (string) $response->getUri());
         } elseif (preg_match('/<urlset/', $body)) {
-            $this->validateBody($body, (string)$response->getUri(), false);
+            $this->validateBody($body, (string) $response->getUri(), false);
         }
     }
 }

src/Rules/Xml/DuplicateIdRule.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
             return;
         }
 
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
 
         $idList = $crawler->filterXPath('//*[@id!=""]');
 
@@ -36,7 +36,7 @@ 
 
         if (count($duplicatedIds) > 0) {
             unset($duplicatedIds['']);
-            throw new ValidationFailedException('Duplicate ids found (' . implode(', ', array_keys($duplicatedIds)) . ')');
+            throw new ValidationFailedException('Duplicate ids found ('.implode(', ', array_keys($duplicatedIds)).')');
         }
     }
 }

src/Rules/Json/ValidRule.php

Spacing +2 added lines, -2 removed lines

@@ -26,9 +26,9 @@
 
     public function doValidation(ResponseInterface $response)
     {
-        $result = json_decode((string)$response->getBody());
+        $result = json_decode((string) $response->getBody());
         if ($result === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         }
     }
 }

src/Rules/Html/ForeignDomainImageRule.php

Spacing +3 added lines, -3 removed lines

@@ -26,7 +26,7 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody());
+        $document = new Document((string) $response->getBody());
         $images = $document->getImages($response->getUri());
 
         $foreignImages = array();
@@ -37,10 +37,10 @@ 
         foreach ($images as $image) {
             /* @var $image Uri */
             if ($currentUri->getHost($this->depth) !== $image->getHost($this->depth)) {
-                $foreignImages[] = (string)$image;
+                $foreignImages[] = (string) $image;
             }
         }
 
-        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found (' . implode(', ', $foreignImages) . ')');
+        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found ('.implode(', ', $foreignImages).')');
     }
 }

src/Rules/Html/SizeRule.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@
 
     protected function doValidation(ResponseInterface $response)
     {
-        $size = strlen((string)$response->getBody()) / 1000;
-        $this->assert($size <= $this->maxSize, 'The size of this html file is too big (' . $size . ' KB)');
+        $size = strlen((string) $response->getBody()) / 1000;
+        $this->assert($size <= $this->maxSize, 'The size of this html file is too big ('.$size.' KB)');
     }
 }

src/Rules/Html/StringNotExistsRule.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@
 
     public function doValidation(ResponseInterface $response)
     {
-        $this->assert(strpos((string)$response->getBody(), $this->string) !== false,
-            'The given string (' . $this->string . ') was found in this document.');
+        $this->assert(strpos((string) $response->getBody(), $this->string) !== false,
+            'The given string ('.$this->string.') was found in this document.');
     }
 }

src/Rules/Html/StringExistsRule.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@
 
     protected function doValidation(ResponseInterface $response)
     {
-        $this->assert(strpos((string)$response->getBody(), $this->string) !== false,
-            'The given string (' . $this->string . ') was not found in this document.');
+        $this->assert(strpos((string) $response->getBody(), $this->string) !== false,
+            'The given string ('.$this->string.') was not found in this document.');
     }
 }

src/Rules/Html/NoIndexRule.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
             return;
         }
 
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
         $metaTags = $crawler->filterXPath("//meta[@name='robots']/@content");
 
         foreach ($metaTags as $metaTag) {