phmLabs / Smoke

src/Rules/Html/XPathExistsRule.php

Spacing +8 added lines, -8 removed lines

@@ -22,7 +22,7 @@ 
     public function doValidation(ResponseInterface $response)
     {
         $domDocument = new \DOMDocument();
-        @$domDocument->loadHTML((string)$response->getBody());
+        @$domDocument->loadHTML((string) $response->getBody());
 
         $domXPath = new \DOMXPath($domDocument);
 
@@ -30,16 +30,16 @@ 
             $count = $domXPath->query($xpath['pattern'])->length;
 
             if ($xpath['relation'] === 'equals') {
-                $result = $count === (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
+                $result = $count === (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
             } elseif ($xpath['relation'] === 'less than') {
-                $result = $count < (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
+                $result = $count < (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
             } elseif ($xpath['relation'] === 'greater than') {
-                $result = $count > (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
+                $result = $count > (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
             } else {
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
             }
 
             $this->assert($result, $message);

src/Rules/Html/CssSelectorExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -24,7 +24,7 @@ 
     public function doValidation(ResponseInterface $response)
     {
         $domDocument = new \DOMDocument();
-        @$domDocument->loadHTML((string)$response->getBody());
+        @$domDocument->loadHTML((string) $response->getBody());
 
         $domXPath = new \DOMXPath($domDocument);
 
@@ -37,7 +37,7 @@ 
             try {
                 $selectorAsXPath = $converter->toXPath($selector['pattern']);
             } catch (\Exception $e) {
-                throw new ValidationFailedException('Invalid css selector (' . $selector['pattern'] . ').');
+                throw new ValidationFailedException('Invalid css selector ('.$selector['pattern'].').');
             }
 
             $count = $domXPath->query($selectorAsXPath)->length;
@@ -51,7 +51,7 @@ 
         if ($error === true) {
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
 
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
         }
     }
 }

src/Rules/Seo/GoogleMobileFriendlyRule.php

Spacing +4 added lines, -4 removed lines

@@ -14,7 +14,7 @@ 
 
     private function getEndpoint(Uri $uri)
     {
-        return str_replace('#url#', urlencode((string)$uri), self::ENDPOINT);
+        return str_replace('#url#', urlencode((string) $uri), self::ENDPOINT);
     }
 
     public function validate(ResponseInterface $response)
@@ -33,7 +33,7 @@ 
             )));
 
         if (property_exists($result, 'error')) {
-            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
+            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
             $checkResult->addAttribute(new Attribute('Google response', json_encode($result), true));
             return $checkResult;
         }
@@ -41,9 +41,9 @@ 
         $passResult = $result->ruleGroups->USABILITY;
 
         if (!$passResult->pass) {
-            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
         }
 
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
     }
 }

src/Config/Configuration.php

Spacing +4 added lines, -4 removed lines

@@ -65,7 +65,7 @@ 
     private function initConfigArray(array $configArray, array $defaultSettings = null)
     {
         if ($defaultSettings === null) {
-            $defaultSettings = Yaml::parse(file_get_contents(__DIR__ . '/../settings/' . self::DEFAULT_SETTINGS));
+            $defaultSettings = Yaml::parse(file_get_contents(__DIR__.'/../settings/'.self::DEFAULT_SETTINGS));
         }
 
         if (count($configArray) === 0) {
@@ -167,7 +167,7 @@ 
         if ($this->hasSection($section)) {
             return $this->configArray[$section];
         } else {
-            throw new \RuntimeException('The section (' . $section . ') you are trying to access does not exist.');
+            throw new \RuntimeException('The section ('.$section.') you are trying to access does not exist.');
         }
     }
 
@@ -176,7 +176,7 @@ 
         if (array_key_exists($name, $this->extensions)) {
             return $this->extensions[$name];
         } else {
-            throw new \RuntimeException('The extension ("' . $name . '") you are trying to access does not exist. Registered extensions are: ' . implode(' ,', array_keys($this->extensions)) . '.');
+            throw new \RuntimeException('The extension ("'.$name.'") you are trying to access does not exist. Registered extensions are: '.implode(' ,', array_keys($this->extensions)).'.');
         }
     }
 
@@ -201,7 +201,7 @@ 
             try {
                 $client = Init::initialize($this->configArray['client']);
             } catch (\Exception $e) {
-                throw new ConfigurationException('Error initializing client (' . $e->getMessage() . ')');
+                throw new ConfigurationException('Error initializing client ('.$e->getMessage().')');
             }
 
             if (array_key_exists('cache', $this->configArray['client'])) {

src/Rules/Xml/Sitemap/ValidRule.php

Doc Comments +7 added lines

@@ -27,6 +27,9 @@ 
         $this->strictMode = $strictMode;
     }
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         if ($isIndex) {
@@ -40,6 +43,10 @@ 
         }
     }
 
+    /**
+     * @param string $body
+     * @param string $filename
+     */
     private function validateBody($body, $filename, $isIndex = true)
     {
         $dom = new \DOMDocument();

Spacing +7 added lines, -7 removed lines

@@ -30,13 +30,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -50,19 +50,19 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 
     protected function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         // sitemapindex or urlset
         if (preg_match('/<sitemapindex/', $body)) {
-            $this->validateBody($body, (string)$response->getUri());
+            $this->validateBody($body, (string) $response->getUri());
         } elseif (preg_match('/<urlset/', $body)) {
-            $this->validateBody($body, (string)$response->getUri(), false);
+            $this->validateBody($body, (string) $response->getUri(), false);
         }
     }
 }

src/Rules/Xml/DuplicateIdRule.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
             return;
         }
 
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
 
         $idList = $crawler->filterXPath('//*[@id!=""]');
 
@@ -36,7 +36,7 @@ 
 
         if (count($duplicatedIds) > 0) {
             unset($duplicatedIds['']);
-            throw new ValidationFailedException('Duplicate ids found (' . implode(', ', array_keys($duplicatedIds)) . ')');
+            throw new ValidationFailedException('Duplicate ids found ('.implode(', ', array_keys($duplicatedIds)).')');
         }
     }
 }

src/Rules/Json/ValidRule.php

Spacing +2 added lines, -2 removed lines

@@ -26,9 +26,9 @@
 
     public function doValidation(ResponseInterface $response)
     {
-        $result = json_decode((string)$response->getBody());
+        $result = json_decode((string) $response->getBody());
         if ($result === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         }
     }
 }

src/Rules/Html/ForeignDomainImageRule.php

Spacing +3 added lines, -3 removed lines

@@ -26,7 +26,7 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody());
+        $document = new Document((string) $response->getBody());
         $images = $document->getImages($response->getUri());
 
         $foreignImages = array();
@@ -37,10 +37,10 @@ 
         foreach ($images as $image) {
             /* @var $image Uri */
             if ($currentUri->getHost($this->depth) !== $image->getHost($this->depth)) {
-                $foreignImages[] = (string)$image;
+                $foreignImages[] = (string) $image;
             }
         }
 
-        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found (' . implode(', ', $foreignImages) . ')');
+        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found ('.implode(', ', $foreignImages).')');
     }
 }

src/Rules/Html/SizeRule.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@
 
     protected function doValidation(ResponseInterface $response)
     {
-        $size = strlen((string)$response->getBody()) / 1000;
-        $this->assert($size <= $this->maxSize, 'The size of this html file is too big (' . $size . ' KB)');
+        $size = strlen((string) $response->getBody()) / 1000;
+        $this->assert($size <= $this->maxSize, 'The size of this html file is too big ('.$size.' KB)');
     }
 }