phmLabs / Smoke

src/Rules/Json/JsonSchema/JsonSchemaRule.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use JsonSchema\Validator;
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\StandardRule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Spacing +5 added lines, -5 removed lines

@@ -33,9 +33,9 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $data = json_decode((string)$response->getBody());
+        $data = json_decode((string) $response->getBody());
         if ($data === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         } else {
             $errorStatus = false;
             $messageParts = array();
@@ -51,14 +51,14 @@ 
                     $errorStatus = true;
                     $errorMessage = '';
                     foreach ($validator->getErrors() as $error) {
-                        $errorMessage = $errorMessage . sprintf("[%s] %s\n", $error['property'], $error['message']);
+                        $errorMessage = $errorMessage.sprintf("[%s] %s\n", $error['property'], $error['message']);
                     }
-                    $messageParts[] = $jsonSchemaFile['jsonfilename'] . ' - ' . $jsonSchemaFile['jsonfileurl'] . '(last error: ' . $errorMessage . ').';
+                    $messageParts[] = $jsonSchemaFile['jsonfilename'].' - '.$jsonSchemaFile['jsonfileurl'].'(last error: '.$errorMessage.').';
                 }
             }
 
             if ($errorStatus === true) {
-                $message = 'JSON file (' . (string) $response->getUri() . ')  does not validate against the following JSON Schema files: ' . implode(', ', $messageParts);
+                $message = 'JSON file ('.(string) $response->getUri().')  does not validate against the following JSON Schema files: '.implode(', ', $messageParts);
                 throw new ValidationFailedException($message);
             }
         }

src/Rules/Security/PasswordSecureTransferRule.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use Symfony\Component\DomCrawler\Crawler;
-use whm\Smoke\Http\Response;
-use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\StandardRule;
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -19,10 +19,10 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
         $actionNodes = $crawler->filterXPath('//form[//input[@type="password"]]');
 
-        $url = (string)$response->getUri();
+        $url = (string) $response->getUri();
 
         foreach ($actionNodes as $node) {
             $action = $node->getAttribute('action');
@@ -36,7 +36,7 @@ 
 
             while ($parent = $parent->parentNode) {
                 if (property_exists($parent, 'tagName')) {
-                    $fullPath = $parent->tagName . '/' . $fullPath;
+                    $fullPath = $parent->tagName.'/'.$fullPath;
                 } else {
                     break;
                 }

src/Rules/Seo/PageSpeedRule.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace whm\Smoke\Rules\Seo;
 
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\ValidationFailedException;
 

src/Rules/Seo/RobotsDisallowAllRule.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use Ivory\HttpAdapter\HttpAdapterInterface;
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\ClientAware;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Spacing +4 added lines, -4 removed lines

@@ -21,12 +21,12 @@ 
 
     public function validate(ResponseInterface $response)
     {
-        $url = $response->getUri()->getScheme() . '://' . $response->getUri()->getHost();
+        $url = $response->getUri()->getScheme().'://'.$response->getUri()->getHost();
 
         if (substr_count($url, '/') === 2) {
-            $filename = $robotsUrl = $url . '/robots.txt';
+            $filename = $robotsUrl = $url.'/robots.txt';
         } elseif (substr_count($url, '/') === 3) {
-            $filename = $robotsUrl = $url . 'robots.txt';
+            $filename = $robotsUrl = $url.'robots.txt';
         } else {
             return;
         }
@@ -39,7 +39,7 @@ 
 
         $normalizedContent = $this->normalizeContent($content);
 
-        if (strpos($normalizedContent, 'user-agent:* disallow:/' . PHP_EOL) !== false) {
+        if (strpos($normalizedContent, 'user-agent:* disallow:/'.PHP_EOL) !== false) {
             throw new ValidationFailedException('The robots.txt contains disallow all (Disallow: /)');
         }
 

src/Extensions/SmokeReporter/Reporter/XUnitReporter.php

Spacing +4 added lines, -4 removed lines

@@ -59,7 +59,7 @@ 
         $failures = 0;
 
         if ($this->retriever instanceof CrawlingRetriever) {
-            $startPage = (string)$this->retriever->getStartPage();
+            $startPage = (string) $this->retriever->getStartPage();
         } else {
             $startPage = '';
         }
@@ -80,8 +80,8 @@ 
                     $testCase->addFailure(new Failure($ruleName, $message));
 
                     if ($this->retriever instanceof CrawlingRetriever) {
-                        $stackTrace = $result->getUrl() . ' coming from ' . (string)$this->retriever->getComingFrom($result->getUrl()) . PHP_EOL;
-                        $stackTrace .= '    - ' . $message . " [rule: $ruleName]";
+                        $stackTrace = $result->getUrl().' coming from '.(string) $this->retriever->getComingFrom($result->getUrl()).PHP_EOL;
+                        $stackTrace .= '    - '.$message." [rule: $ruleName]";
                         $testCase->setSystemOut($stackTrace);
                     }
                 }
@@ -92,7 +92,7 @@ 
 
         file_put_contents($this->filename, $xUnitReport->toXml());
 
-        $this->output->writeln('    <info>Writing XUnit Output to file:</info> ' . $this->filename);
+        $this->output->writeln('    <info>Writing XUnit Output to file:</info> '.$this->filename);
     }
 
     public function processResults($results)

src/Rules/Http/Header/GZipRule.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
         if ($response instanceof ContentTypeAwareResponse) {
             if (strpos($response->getContentType(), 'image') === false
                 && strpos($response->getContentType(), 'pdf') === false
-                && strlen((string)$response->getBody()) >= $this->minFileSize
+                && strlen((string) $response->getBody()) >= $this->minFileSize
             ) {
                 if (!$response->hasHeader('Content-Encoding') || $response->getHeader('Content-Encoding')[0] !== 'gzip') {
                     throw new ValidationFailedException('gzip compression not active');

src/Rules/Http/Header/SuccessStatusRule.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
     public function validate(ResponseInterface $response)
     {
         if ($response->getStatusCode() > $this->maxStatusCode) {
-            throw new ValidationFailedException('Status code ' . $response->getStatusCode() . ' found.');
+            throw new ValidationFailedException('Status code '.$response->getStatusCode().' found.');
         }
     }
 }

src/Rules/Http/Header/HttpStatusRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     public function validate(ResponseInterface $response)
     {
         if ($response->getStatusCode() !== $this->expectedStatus) {
-            throw new ValidationFailedException('Status code ' . $response->getStatusCode() . ' found, ' . $this->expectedStatus . ' expected.');
+            throw new ValidationFailedException('Status code '.$response->getStatusCode().' found, '.$this->expectedStatus.' expected.');
         }
     }
 }

src/Rules/Http/DurationRule.php

Spacing +4 added lines, -4 removed lines

@@ -29,14 +29,14 @@
             if ($response->getDuration() > $this->maxDuration) {
                 return new CheckResult(
                     CheckResult::STATUS_FAILURE,
-                    'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                    (int)$response->getDuration());
+                    'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                    (int) $response->getDuration());
             }
 
             return new CheckResult(
                 CheckResult::STATUS_SUCCESS,
-                'The http request took ' . (int)$response->getDuration() . ' milliseconds.',
-                (int)$response->getDuration());
+                'The http request took '.(int) $response->getDuration().' milliseconds.',
+                (int) $response->getDuration());
         }
     }
 }