phmLabs / Smoke

src/Rules/Cookies/CountRule.php

Spacing +2 added lines, -2 removed lines

@@ -36,12 +36,12 @@
                 if ($cookieCount > $this->maxCookies) {
                     $result = new CheckResult(
                         CheckResult::STATUS_FAILURE,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 } else {
                     $result = new CheckResult(
                         CheckResult::STATUS_SUCCESS,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 }
 

Doc Comments -1 removed lines

@@ -18,7 +18,6 @@
     private $maxCookies;
 
     /**
-     * @param int $maxDuration The maximum duration a http call is allowed to take (time to first byte)
      */
     public function init($maxElements = 20)
     {

src/Rules/Html/InvalidUrlsRule.php

Spacing +4 added lines, -4 removed lines

@@ -18,18 +18,18 @@
      */
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody(), false);
+        $document = new Document((string) $response->getBody(), false);
         $urls = $document->getDependencies($response->getUri());
         $invalidUrls = array();
 
         foreach ($urls as $url) {
-            $idnUrl = $url->getScheme() . '://' . idn_to_ascii($url->getHost()) . $url->getPath();
+            $idnUrl = $url->getScheme().'://'.idn_to_ascii($url->getHost()).$url->getPath();
 
             if (!filter_var($idnUrl, FILTER_VALIDATE_URL)) {
-                $invalidUrls[] = (string)$url;
+                $invalidUrls[] = (string) $url;
             }
         }
 
-        $this->assert(count($invalidUrls) === 0, 'Invalid urls found (' . implode(', ', $invalidUrls) . ').');
+        $this->assert(count($invalidUrls) === 0, 'Invalid urls found ('.implode(', ', $invalidUrls).').');
     }
 }

src/Rules/Html/CssSelectorExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
 
     public function doValidation(ResponseInterface $response)
     {
-        $content = (string)$response->getBody();
+        $content = (string) $response->getBody();
 
         $domDocument = new \DOMDocument();
         @$domDocument->loadHTML($content);
@@ -40,7 +40,7 @@ 
             try {
                 $selectorAsXPath = $converter->toXPath($selector['pattern']);
             } catch (\Exception $e) {
-                throw new ValidationFailedException('Invalid css selector (' . $selector['pattern'] . ').');
+                throw new ValidationFailedException('Invalid css selector ('.$selector['pattern'].').');
             }
 
             $count = $domXPath->query($selectorAsXPath)->length;
@@ -54,7 +54,7 @@ 
         if ($error === true) {
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
 
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
         }
     }
 }

src/Rules/Http/Header/GZipRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
                 && strpos($response->getContentType(), 'pdf') === false
                 && strpos($response->getContentType(), 'postscript') === false
                 && strpos($response->getContentType(), 'zip') === false
-                && strlen((string)$response->getBody()) >= $this->minFileSize
+                && strlen((string) $response->getBody()) >= $this->minFileSize
             ) {
                 if (!$response->hasHeader('Content-Encoding') || $response->getHeader('Content-Encoding')[0] !== 'gzip') {
                     throw new ValidationFailedException('gzip compression not active');

src/Rules/Html/BrokenLinkRule.php

Spacing +2 added lines, -2 removed lines

@@ -49,9 +49,9 @@
 
             if (count($errorList) > 0) {
                 $count = count($errorList);
-                $msg = 'Found ' . $count . ' broken link(s). <ul>';
+                $msg = 'Found '.$count.' broken link(s). <ul>';
                 foreach ($errorList as $error) {
-                    $msg .= '<li>' . $error['name'] . ' (http status: ' . $error['http_status'] . ')</li>';
+                    $msg .= '<li>'.$error['name'].' (http status: '.$error['http_status'].')</li>';
                 }
                 $msg .= '</ul>';
                 return new CheckResult(CheckResult::STATUS_FAILURE, $msg, $count);

src/Extensions/SmokeReporter/Reporter/CliReporter.php

Spacing +7 added lines, -7 removed lines

@@ -37,10 +37,10 @@ 
         if ($response instanceof RequestAwareResponse) {
             $request = $response->getRequest();
             if ($request instanceof DeviceAwareRequest) {
-                return ' (Device: ' . $request->getDevice()->getName() . ')';
+                return ' (Device: '.$request->getDevice()->getName().')';
             } else if ($request instanceof ViewportAwareRequest) {
                 $viewport = $request->getViewport();
-                return ' (Viewport: width: ' . $viewport->getWidth() . ', height: ' . $viewport->getHeight() . ')';
+                return ' (Viewport: width: '.$viewport->getWidth().', height: '.$viewport->getHeight().')';
             }
         }
 
@@ -49,19 +49,19 @@ 
 
     protected function renderFailure(CheckResult $result)
     {
-        $this->output->writeln('   <error> ' . (string)$result->getResponse()->getUri() . $this->getRequestString($result->getResponse()) . ' </error> coming from ' . (string)$this->retriever->getComingFrom($result->getResponse()->getUri()));
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <error> '.(string) $result->getResponse()->getUri().$this->getRequestString($result->getResponse()).' </error> coming from '.(string) $this->retriever->getComingFrom($result->getResponse()->getUri()));
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
         $this->output->writeln('');
     }
 
     protected function renderSuccess(CheckResult $result)
     {
-        $this->output->writeln('   <info> ' . (string)$result->getResponse()->getUri() . $this->getRequestString($result->getResponse()) . ' </info> all tests passed');
+        $this->output->writeln('   <info> '.(string) $result->getResponse()->getUri().$this->getRequestString($result->getResponse()).' </info> all tests passed');
     }
 
     protected function renderSkipped(CheckResult $result)
     {
-        $this->output->writeln('   <comment> ' . (string)$result->getResponse()->getUri() . $this->getRequestString($result->getResponse()) . ' </comment>test skipped');
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <comment> '.(string) $result->getResponse()->getUri().$this->getRequestString($result->getResponse()).' </comment>test skipped');
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
     }
 }

src/Rules/Html/XPathExistsRule.php

Spacing +9 added lines, -9 removed lines

@@ -31,12 +31,12 @@ 
 
         // @todo this could be part of an abstract class
         if ($this->useDom) {
-            $content = (string)$response->getBody();
+            $content = (string) $response->getBody();
         } else {
             if ($response instanceof DomAwareResponse) {
                 $content = $response->getHtmlBody();
             } else {
-                $content = (string)$response->getBody();
+                $content = (string) $response->getBody();
             }
         }
 
@@ -48,16 +48,16 @@ 
             $count = $domXPath->query($xpath['pattern'])->length;
 
             if ($xpath['relation'] === 'equals') {
-                $result = $count === (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
+                $result = $count === (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
             } elseif ($xpath['relation'] === 'less than') {
-                $result = $count < (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
+                $result = $count < (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
             } elseif ($xpath['relation'] === 'greater than') {
-                $result = $count > (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
+                $result = $count > (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
             } else {
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
             }
 
             $this->assert($result, $message);