phmLabs / Smoke

src/Extensions/SmokeReporter/Reporter/WarmUpLiveReporter.php

Spacing +2 added lines, -2 removed lines

@@ -22,14 +22,14 @@
         if (count($results) > 0) {
             ++$this->urlCount;
             $firstResult = array_pop($results);
-            $this->output->writeln('   ' . (string) $firstResult->getResponse()->getUri());
+            $this->output->writeln('   '.(string) $firstResult->getResponse()->getUri());
             $this->output->writeln('');
         }
     }
 
     public function finish()
     {
-        $this->output->writeln('   <comment>Warm up finished. ' . $this->urlCount . ' urls visited.</comment>');
+        $this->output->writeln('   <comment>Warm up finished. '.$this->urlCount.' urls visited.</comment>');
         $this->output->writeln('');
     }
 }

src/Rules/Http/Header/ExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -24,13 +24,13 @@
 
         foreach ($this->checkedHeaders as $headerConfig) {
             if (!$response->hasHeader($headerConfig['key'])) {
-                throw new ValidationFailedException('Header not found (' . $headerConfig['key'] . ')');
+                throw new ValidationFailedException('Header not found ('.$headerConfig['key'].')');
             }
 
             $currentValue = $response->getHeader($headerConfig['key'])[0];
 
-            if (!preg_match('%' . $headerConfig['value'] . '%', $currentValue, $matches)) {
-                throw new ValidationFailedException('Header "' . $headerConfig['key'] . '" does not match "' . $headerConfig['value'] . '". Current value is "' . $currentValue . '"');
+            if (!preg_match('%'.$headerConfig['value'].'%', $currentValue, $matches)) {
+                throw new ValidationFailedException('Header "'.$headerConfig['key'].'" does not match "'.$headerConfig['value'].'". Current value is "'.$currentValue.'"');
             }
         }
     }

src/Config/Configuration.php

Doc Comments +4 added lines, -1 removed lines

@@ -158,7 +158,7 @@ 
     }
 
     /**
-     * @param $section
+     * @param string $section
      *
      * @return array
      */
@@ -171,6 +171,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     public function getExtension($name)
     {
         if (array_key_exists($name, $this->extensions)) {

Spacing +4 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
     private function initConfigArray(array $configArray, array $defaultSettings = null)
     {
         if ($defaultSettings === null) {
-            $defaultSettings = Yaml::parse(file_get_contents(__DIR__ . '/../settings/' . self::DEFAULT_SETTINGS));
+            $defaultSettings = Yaml::parse(file_get_contents(__DIR__.'/../settings/'.self::DEFAULT_SETTINGS));
         }
 
         if (count($configArray) === 0) {
@@ -169,7 +169,7 @@ 
         if ($this->hasSection($section)) {
             return $this->configArray[$section];
         } else {
-            throw new \RuntimeException('The section (' . $section . ') you are trying to access does not exist.');
+            throw new \RuntimeException('The section ('.$section.') you are trying to access does not exist.');
         }
     }
 
@@ -178,7 +178,7 @@ 
         if (array_key_exists($name, $this->extensions)) {
             return $this->extensions[$name];
         } else {
-            throw new \RuntimeException('The extension ("' . $name . '") you are trying to access does not exist. Registered extensions are: ' . implode(' ,', array_keys($this->extensions)) . '.');
+            throw new \RuntimeException('The extension ("'.$name.'") you are trying to access does not exist. Registered extensions are: '.implode(' ,', array_keys($this->extensions)).'.');
         }
     }
 
@@ -203,7 +203,7 @@ 
             try {
                 $client = Init::initialize($this->configArray['client']);
             } catch (\Exception $e) {
-                throw new ConfigurationException('Error initializing client (' . $e->getMessage() . ')');
+                throw new ConfigurationException('Error initializing client ('.$e->getMessage().')');
             }
 
             return $client;

src/Rules/Html/CssFileCountRule.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use whm\Html\Document;
-use whm\Smoke\Http\Response;
 
 /**
  * This rules counts the css files that are included in a document. If the number is higher

src/Rules/Html/JsFileCountRule.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use whm\Html\Document;
-use whm\Smoke\Http\Response;
 
 /**
  * This rules counts the js files that are included in a document. If the number is higher

src/Rules/Http/HttpsRule.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace whm\Smoke\Rules\Http;
 
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\Rule;
 
 abstract class HttpsRule implements Rule

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
         $sslOptions = stream_context_create(array('ssl' => array('capture_peer_cert' => true)));
 
         $request = @stream_socket_client(
-            'ssl://' . $host . ':443',
+            'ssl://'.$host.':443',
             $errno,
             $errstr,
             30,

src/Rules/Image/FavIconRule.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace whm\Smoke\Rules\Image;
 
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\StandardRule;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -30,8 +30,8 @@
             return;
         }
 
-        $imageHash = md5((string)$response->getBody());
+        $imageHash = md5((string) $response->getBody());
 
-        $this->assert(!array_key_exists($imageHash, $this->favicons), 'Seems like you use the standard favicon of your framework (' . $this->favicons[$imageHash] . ').');
+        $this->assert(!array_key_exists($imageHash, $this->favicons), 'Seems like you use the standard favicon of your framework ('.$this->favicons[$imageHash].').');
     }
 }

src/Rules/Json/JsonSchema/JsonSchemaRule.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use JsonSchema\Validator;
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\StandardRule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Spacing +5 added lines, -5 removed lines

@@ -33,9 +33,9 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $data = json_decode((string)$response->getBody());
+        $data = json_decode((string) $response->getBody());
         if ($data === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         } else {
             $errorStatus = false;
             $messageParts = array();
@@ -51,14 +51,14 @@ 
                     $errorStatus = true;
                     $errorMessage = '';
                     foreach ($validator->getErrors() as $error) {
-                        $errorMessage = $errorMessage . sprintf("[%s] %s\n", $error['property'], $error['message']);
+                        $errorMessage = $errorMessage.sprintf("[%s] %s\n", $error['property'], $error['message']);
                     }
-                    $messageParts[] = $jsonSchemaFile['jsonfilename'] . ' - ' . $jsonSchemaFile['jsonfileurl'] . '(last error: ' . $errorMessage . ').';
+                    $messageParts[] = $jsonSchemaFile['jsonfilename'].' - '.$jsonSchemaFile['jsonfileurl'].'(last error: '.$errorMessage.').';
                 }
             }
 
             if ($errorStatus === true) {
-                $message = 'JSON file (' . (string) $response->getUri() . ')  does not validate against the following JSON Schema files: ' . implode(', ', $messageParts);
+                $message = 'JSON file ('.(string) $response->getUri().')  does not validate against the following JSON Schema files: '.implode(', ', $messageParts);
                 throw new ValidationFailedException($message);
             }
         }

src/Rules/Security/PasswordSecureTransferRule.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use Symfony\Component\DomCrawler\Crawler;
-use whm\Smoke\Http\Response;
-use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\StandardRule;
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -19,10 +19,10 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
         $actionNodes = $crawler->filterXPath('//form[//input[@type="password"]]');
 
-        $url = (string)$response->getUri();
+        $url = (string) $response->getUri();
 
         foreach ($actionNodes as $node) {
             $action = $node->getAttribute('action');
@@ -36,7 +36,7 @@ 
 
             while ($parent = $parent->parentNode) {
                 if (property_exists($parent, 'tagName')) {
-                    $fullPath = $parent->tagName . '/' . $fullPath;
+                    $fullPath = $parent->tagName.'/'.$fullPath;
                 } else {
                     break;
                 }