phmLabs / Smoke

src/Rules/Seo/RobotsDisallowAllRule.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use Ivory\HttpAdapter\HttpAdapterInterface;
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\ClientAware;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Spacing +4 added lines, -4 removed lines

@@ -21,12 +21,12 @@ 
 
     public function validate(ResponseInterface $response)
     {
-        $url = $response->getUri()->getScheme() . '://' . $response->getUri()->getHost();
+        $url = $response->getUri()->getScheme().'://'.$response->getUri()->getHost();
 
         if (substr_count($url, '/') === 2) {
-            $filename = $robotsUrl = $url . '/robots.txt';
+            $filename = $robotsUrl = $url.'/robots.txt';
         } elseif (substr_count($url, '/') === 3) {
-            $filename = $robotsUrl = $url . 'robots.txt';
+            $filename = $robotsUrl = $url.'robots.txt';
         } else {
             return;
         }
@@ -39,7 +39,7 @@ 
 
         $normalizedContent = $this->normalizeContent($content);
 
-        if (strpos($normalizedContent, 'user-agent:* disallow:/' . PHP_EOL) !== false) {
+        if (strpos($normalizedContent, 'user-agent:* disallow:/'.PHP_EOL) !== false) {
             throw new ValidationFailedException('The robots.txt contains disallow all (Disallow: /)');
         }
 

src/Extensions/SmokeReporter/Reporter/XUnitReporter.php

Spacing +4 added lines, -4 removed lines

@@ -59,7 +59,7 @@ 
         $failures = 0;
 
         if ($this->retriever instanceof CrawlingRetriever) {
-            $startPage = (string)$this->retriever->getStartPage();
+            $startPage = (string) $this->retriever->getStartPage();
         } else {
             $startPage = '';
         }
@@ -80,8 +80,8 @@ 
                     $testCase->addFailure(new Failure($ruleName, $message));
 
                     if ($this->retriever instanceof CrawlingRetriever) {
-                        $stackTrace = $result->getUrl() . ' coming from ' . (string)$this->retriever->getComingFrom($result->getUrl()) . PHP_EOL;
-                        $stackTrace .= '    - ' . $message . " [rule: $ruleName]";
+                        $stackTrace = $result->getUrl().' coming from '.(string) $this->retriever->getComingFrom($result->getUrl()).PHP_EOL;
+                        $stackTrace .= '    - '.$message." [rule: $ruleName]";
                         $testCase->setSystemOut($stackTrace);
                     }
                 }
@@ -92,7 +92,7 @@ 
 
         file_put_contents($this->filename, $xUnitReport->toXml());
 
-        $this->output->writeln('    <info>Writing XUnit Output to file:</info> ' . $this->filename);
+        $this->output->writeln('    <info>Writing XUnit Output to file:</info> '.$this->filename);
     }
 
     public function processResults($results)

src/Rules/Http/Header/SuccessStatusRule.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
     public function validate(ResponseInterface $response)
     {
         if ($response->getStatusCode() > $this->maxStatusCode) {
-            throw new ValidationFailedException('Status code ' . $response->getStatusCode() . ' found.');
+            throw new ValidationFailedException('Status code '.$response->getStatusCode().' found.');
         }
     }
 }

src/Rules/Http/Header/HttpStatusRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     public function validate(ResponseInterface $response)
     {
         if ($response->getStatusCode() !== $this->expectedStatus) {
-            throw new ValidationFailedException('Status code ' . $response->getStatusCode() . ' found, ' . $this->expectedStatus . ' expected.');
+            throw new ValidationFailedException('Status code '.$response->getStatusCode().' found, '.$this->expectedStatus.' expected.');
         }
     }
 }

src/Rules/Http/DurationRule.php

Spacing +4 added lines, -4 removed lines

@@ -29,14 +29,14 @@
             if ($response->getDuration() > $this->maxDuration) {
                 return new CheckResult(
                     CheckResult::STATUS_FAILURE,
-                    'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                    (int)$response->getDuration());
+                    'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                    (int) $response->getDuration());
             }
 
             return new CheckResult(
                 CheckResult::STATUS_SUCCESS,
-                'The http request took ' . (int)$response->getDuration() . ' milliseconds.',
-                (int)$response->getDuration());
+                'The http request took '.(int) $response->getDuration().' milliseconds.',
+                (int) $response->getDuration());
         }
     }
 }

src/Rules/Html/CountRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody());
+        $document = new Document((string) $response->getBody());
         $files = $this->getFilesToCount($document, $response);
 
         $this->assert(count($files) <= $this->maxCount, sprintf($this->errorMessage, count($files)));

src/Rules/Xml/Sitemap/ValidRule.php

Doc Comments +7 added lines

@@ -27,6 +27,9 @@ 
         $this->strictMode = $strictMode;
     }
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         if ($isIndex) {
@@ -40,6 +43,10 @@ 
         }
     }
 
+    /**
+     * @param string $body
+     * @param string $filename
+     */
     private function validateBody($body, $filename, $isIndex = true)
     {
         $dom = new \DOMDocument();

Spacing +7 added lines, -7 removed lines

@@ -30,13 +30,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -50,19 +50,19 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 
     protected function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         // sitemapindex or urlset
         if (preg_match('/<sitemapindex/', $body)) {
-            $this->validateBody($body, (string)$response->getUri());
+            $this->validateBody($body, (string) $response->getUri());
         } elseif (preg_match('/<urlset/', $body)) {
-            $this->validateBody($body, (string)$response->getUri(), false);
+            $this->validateBody($body, (string) $response->getUri(), false);
         }
     }
 }

src/Rules/Xml/DuplicateIdRule.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
             return;
         }
 
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
 
         $idList = $crawler->filterXPath('//*[@id!=""]');
 
@@ -36,7 +36,7 @@ 
 
         if (count($duplicatedIds) > 0) {
             unset($duplicatedIds['']);
-            throw new ValidationFailedException('Duplicate ids found (' . implode(', ', array_keys($duplicatedIds)) . ')');
+            throw new ValidationFailedException('Duplicate ids found ('.implode(', ', array_keys($duplicatedIds)).')');
         }
     }
 }

src/Rules/Json/ValidRule.php

Spacing +2 added lines, -2 removed lines

@@ -26,9 +26,9 @@
 
     public function doValidation(ResponseInterface $response)
     {
-        $result = json_decode((string)$response->getBody());
+        $result = json_decode((string) $response->getBody());
         if ($result === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         }
     }
 }