phmLabs / Smoke

src/Rules/Html/InvalidUrlsRule.php

Spacing +5 added lines, -5 removed lines

@@ -18,22 +18,22 @@
      */
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody(), false);
+        $document = new Document((string) $response->getBody(), false);
         $urls = $document->getDependencies($response->getUri());
         $invalidUrls = array();
 
         foreach ($urls as $url) {
             if (function_exists('idn_to_ascii')) {
-                $idnUrl = $url->getScheme() . '://' . idn_to_ascii($url->getHost()) . $url->getPath();
+                $idnUrl = $url->getScheme().'://'.idn_to_ascii($url->getHost()).$url->getPath();
             } else {
-                $idnUrl = $url->getScheme() . '://' . $url->getHost() . $url->getPath();
+                $idnUrl = $url->getScheme().'://'.$url->getHost().$url->getPath();
             }
 
             if (!filter_var($idnUrl, FILTER_VALIDATE_URL)) {
-                $invalidUrls[] = (string)$url;
+                $invalidUrls[] = (string) $url;
             }
         }
 
-        $this->assert(count($invalidUrls) === 0, 'Invalid urls found (' . implode(', ', $invalidUrls) . ').');
+        $this->assert(count($invalidUrls) === 0, 'Invalid urls found ('.implode(', ', $invalidUrls).').');
     }
 }

src/Cli/Command/SmokeCommand.php

Spacing +5 added lines, -5 removed lines

@@ -48,13 +48,13 @@ 
     protected function writeSmokeCredentials($url = null)
     {
         if (defined('SMOKE_CREDENTIALS')) {
-            $this->output->writeln("\n " . SMOKE_CREDENTIALS . "\n");
+            $this->output->writeln("\n ".SMOKE_CREDENTIALS."\n");
         } else {
-            $this->output->writeln("\n Smoke " . SMOKE_VERSION . " by Nils Langner\n");
+            $this->output->writeln("\n Smoke ".SMOKE_VERSION." by Nils Langner\n");
         }
 
         if ($url) {
-            $this->output->writeln(' <info>Scanning ' . $url . "</info>\n");
+            $this->output->writeln(' <info>Scanning '.$url."</info>\n");
         }
     }
 
@@ -101,12 +101,12 @@ 
         if ($configFile) {
             if (strpos($configFile, 'http://') === 0 || strpos($configFile, 'https://') === 0) {
                 $curlClient = new Client();
-                $fileContent = (string)$curlClient->get($configFile)->getBody();
+                $fileContent = (string) $curlClient->get($configFile)->getBody();
             } else {
                 if (file_exists($configFile)) {
                     $fileContent = file_get_contents($configFile);
                 } else {
-                    throw new \RuntimeException("Config file was not found ('" . $configFile . "').");
+                    throw new \RuntimeException("Config file was not found ('".$configFile."').");
                 }
             }
             $configArray = EnvAwareYaml::parse($fileContent);

src/Extensions/SmokeResponseRetriever/Retriever/Crawler/Filter/BlackWhiteListFilter.php

Spacing +2 added lines, -2 removed lines

@@ -15,9 +15,9 @@
     public function isFiltered(UriInterface $uri, UriInterface $startPage)
     {
         foreach ($this->whitelist as $whitelist) {
-            if (preg_match($whitelist, (string)$uri)) {
+            if (preg_match($whitelist, (string) $uri)) {
                 foreach ($this->blacklist as $blacklist) {
-                    if (preg_match($blacklist, (string)$uri)) {
+                    if (preg_match($blacklist, (string) $uri)) {
                         return true;
                     }
                 }

src/Rules/Http/RedirectRule.php

Spacing +8 added lines, -8 removed lines

@@ -28,30 +28,30 @@ 
         $client = new GuzzleClient();
         $errors = [];
 
-        $targetUrl = (string)$this->removeCredentials($response->getUri());
+        $targetUrl = (string) $this->removeCredentials($response->getUri());
 
 
         foreach ($this->urls as $url) {
             $uri = new Uri($url['url']);
 
             $urlResponses = $client->sendRequests([new Request('GET', $uri)]);
-            $effectiveUrl = (string)$urlResponses[0]->getEffectiveUri();
+            $effectiveUrl = (string) $urlResponses[0]->getEffectiveUri();
 
             if ($effectiveUrl != $targetUrl) {
-                $errors[] = 'The url "' . $url['url'] . '" gets redirected to "' . $effectiveUrl . '".';
+                $errors[] = 'The url "'.$url['url'].'" gets redirected to "'.$effectiveUrl.'".';
             }
         }
 
         if (count($errors) > 0) {
-            $message = 'Not all given urls do redirect to "' . $targetUrl . '"".<ul>';
+            $message = 'Not all given urls do redirect to "'.$targetUrl.'"".<ul>';
             foreach ($errors as $error) {
-                $message .= '<li>' . $error . '</li>';
+                $message .= '<li>'.$error.'</li>';
             }
             $message .= "</ul>";
 
             return new CheckResult(CheckResult::STATUS_FAILURE, $message);
         } else {
-            return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to ' . (string)$response->getUri());
+            return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to '.(string) $response->getUri());
         }
     }
 
@@ -59,10 +59,10 @@ 
     {
         $query = '';
         if ($uri->getQuery()) {
-            $query = "?" . $uri->getQuery();
+            $query = "?".$uri->getQuery();
         }
 
-        $plainUri = $uri->getScheme() . '://' . $uri->getHost() . $uri->getPath() . $query;
+        $plainUri = $uri->getScheme().'://'.$uri->getHost().$uri->getPath().$query;
 
         return new Uri($plainUri);
     }

src/Rules/Xml/Rss/ValidRule.php

Spacing +6 added lines, -6 removed lines

@@ -23,12 +23,12 @@ 
 
     private function getSchema()
     {
-        return __DIR__ . '/' . self::SCHEMA;
+        return __DIR__.'/'.self::SCHEMA;
     }
 
     public function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         if (preg_match('/<rss/', $body)) {
             libxml_clear_errors();
@@ -38,8 +38,8 @@ 
 
             if ($lastError) {
                 throw new ValidationFailedException(
-                    'The given xml file is not well formed (last error: ' .
-                    str_replace("\n", '', $lastError->message) . ').');
+                    'The given xml file is not well formed (last error: '.
+                    str_replace("\n", '', $lastError->message).').');
             }
 
             $valid = @$dom->schemaValidate($this->getSchema());
@@ -49,11 +49,11 @@ 
                 $lastErrorMessage = str_replace("\n", '', $lastError->message);
 
                 if ($response instanceof UriAwareResponse) {
-                    $toolUrl = sprintf(self::PUBLIC_SERVICE, urlencode((string)$response->getUri()));
+                    $toolUrl = sprintf(self::PUBLIC_SERVICE, urlencode((string) $response->getUri()));
                 } else {
                     $toolUrl = '';
                 }
-                return new CheckResult(CheckResult::STATUS_FAILURE, 'The given xml file is not a valid rss file (last error: ' . $lastErrorMessage . ').', null, $toolUrl);
+                return new CheckResult(CheckResult::STATUS_FAILURE, 'The given xml file is not a valid rss file (last error: '.$lastErrorMessage.').', null, $toolUrl);
             }
         }
         return new CheckResult(CheckResult::STATUS_SUCCESS, 'The given rss file is valid.');

src/Extensions/SmokeResponseRetriever/Retriever/Crawler/Filter/LongUrlFilter.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
      */
     public function isFiltered(UriInterface $currentUri, UriInterface $startUri)
     {
-        return strlen((string)$currentUri) > 255;
+        return strlen((string) $currentUri) > 255;
     }
 
     public function isResponseFiltered(ResponseInterface $response, UriInterface $startUri)

src/Rules/Seo/RobotsDisallowAllRule.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use phm\HttpWebdriverClient\Http\Response\UriAwareResponse;
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\ClientAware;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Spacing +4 added lines, -4 removed lines

@@ -21,12 +21,12 @@ 
     public function validate(ResponseInterface $response)
     {
         if ($response instanceof UriAwareResponse) {
-            $url = $response->getUri()->getScheme() . '://' . $response->getUri()->getHost();
+            $url = $response->getUri()->getScheme().'://'.$response->getUri()->getHost();
 
             if (substr_count($url, '/') === 2) {
-                $filename = $robotsUrl = $url . '/robots.txt';
+                $filename = $robotsUrl = $url.'/robots.txt';
             } elseif (substr_count($url, '/') === 3) {
-                $filename = $robotsUrl = $url . 'robots.txt';
+                $filename = $robotsUrl = $url.'robots.txt';
             } else {
                 return;
             }
@@ -39,7 +39,7 @@ 
 
             $normalizedContent = $this->normalizeContent($content);
 
-            if (strpos($normalizedContent, 'user-agent:* disallow:/' . PHP_EOL) !== false) {
+            if (strpos($normalizedContent, 'user-agent:* disallow:/'.PHP_EOL) !== false) {
                 throw new ValidationFailedException('The robots.txt contains disallow all (Disallow: /)');
             }