phmLabs / Smoke

src/Rules/Cookies/CountRule.php

Spacing +2 added lines, -2 removed lines

@@ -36,12 +36,12 @@
                 if ($cookieCount > $this->maxCookies) {
                     $result = new CheckResult(
                         CheckResult::STATUS_FAILURE,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 } else {
                     $result = new CheckResult(
                         CheckResult::STATUS_SUCCESS,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 }
 

Doc Comments -1 removed lines

@@ -18,7 +18,6 @@
     private $maxCookies;
 
     /**
-     * @param int $maxDuration The maximum duration a http call is allowed to take (time to first byte)
      */
     public function init($maxElements = 20)
     {

src/Rules/Html/CssSelectorExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
 
     public function doValidation(ResponseInterface $response)
     {
-        $content = (string)$response->getBody();
+        $content = (string) $response->getBody();
 
         $domDocument = new \DOMDocument();
         @$domDocument->loadHTML($content);
@@ -40,7 +40,7 @@ 
             try {
                 $selectorAsXPath = $converter->toXPath($selector['pattern']);
             } catch (\Exception $e) {
-                throw new ValidationFailedException('Invalid css selector (' . $selector['pattern'] . ').');
+                throw new ValidationFailedException('Invalid css selector ('.$selector['pattern'].').');
             }
 
             $count = $domXPath->query($selectorAsXPath)->length;
@@ -54,7 +54,7 @@ 
         if ($error === true) {
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
 
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
         }
     }
 }

src/Rules/Http/Header/GZipRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
                 && strpos($response->getContentType(), 'pdf') === false
                 && strpos($response->getContentType(), 'postscript') === false
                 && strpos($response->getContentType(), 'zip') === false
-                && strlen((string)$response->getBody()) >= $this->minFileSize
+                && strlen((string) $response->getBody()) >= $this->minFileSize
             ) {
                 if (!$response->hasHeader('Content-Encoding') || $response->getHeader('Content-Encoding')[0] !== 'gzip') {
                     throw new ValidationFailedException('gzip compression not active');

src/Extensions/SmokeReporter/Reporter/CliReporter.php

Spacing +7 added lines, -7 removed lines

@@ -37,10 +37,10 @@ 
         if ($response instanceof RequestAwareResponse) {
             $request = $response->getRequest();
             if ($request instanceof DeviceAwareRequest) {
-                return ' (Device: ' . $request->getDevice()->getName() . ')';
+                return ' (Device: '.$request->getDevice()->getName().')';
             } else if ($request instanceof ViewportAwareRequest) {
                 $viewport = $request->getViewport();
-                return ' (Viewport: width: ' . $viewport->getWidth() . ', height: ' . $viewport->getHeight() . ')';
+                return ' (Viewport: width: '.$viewport->getWidth().', height: '.$viewport->getHeight().')';
             }
         }
 
@@ -49,19 +49,19 @@ 
 
     protected function renderFailure(CheckResult $result)
     {
-        $this->output->writeln('   <error> ' . (string)$result->getResponse()->getUri() . $this->getRequestString($result->getResponse()) . ' </error> coming from ' . (string)$this->retriever->getComingFrom($result->getResponse()->getUri()));
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <error> '.(string) $result->getResponse()->getUri().$this->getRequestString($result->getResponse()).' </error> coming from '.(string) $this->retriever->getComingFrom($result->getResponse()->getUri()));
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
         $this->output->writeln('');
     }
 
     protected function renderSuccess(CheckResult $result)
     {
-        $this->output->writeln('   <info> ' . (string)$result->getResponse()->getUri() . $this->getRequestString($result->getResponse()) . ' </info> all tests passed');
+        $this->output->writeln('   <info> '.(string) $result->getResponse()->getUri().$this->getRequestString($result->getResponse()).' </info> all tests passed');
     }
 
     protected function renderSkipped(CheckResult $result)
     {
-        $this->output->writeln('   <comment> ' . (string)$result->getResponse()->getUri() . $this->getRequestString($result->getResponse()) . ' </comment>test skipped');
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <comment> '.(string) $result->getResponse()->getUri().$this->getRequestString($result->getResponse()).' </comment>test skipped');
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
     }
 }

src/Rules/Html/XPathExistsRule.php

Spacing +9 added lines, -9 removed lines

@@ -31,12 +31,12 @@ 
 
         // @todo this could be part of an abstract class
         if ($this->useDom) {
-            $content = (string)$response->getBody();
+            $content = (string) $response->getBody();
         } else {
             if ($response instanceof DomAwareResponse) {
                 $content = $response->getHtmlBody();
             } else {
-                $content = (string)$response->getBody();
+                $content = (string) $response->getBody();
             }
         }
 
@@ -48,16 +48,16 @@ 
             $count = $domXPath->query($xpath['pattern'])->length;
 
             if ($xpath['relation'] === 'equals') {
-                $result = $count === (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
+                $result = $count === (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
             } elseif ($xpath['relation'] === 'less than') {
-                $result = $count < (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
+                $result = $count < (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
             } elseif ($xpath['relation'] === 'greater than') {
-                $result = $count > (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
+                $result = $count > (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
             } else {
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
             }
 
             $this->assert($result, $message);

src/Rules/Seo/GoogleMobileFriendlyRule.php

Spacing +4 added lines, -4 removed lines

@@ -14,7 +14,7 @@ 
 
     private function getEndpoint(UriInterface $uri)
     {
-        return str_replace('#url#', urlencode((string)$uri), self::ENDPOINT);
+        return str_replace('#url#', urlencode((string) $uri), self::ENDPOINT);
     }
 
     public function validate(ResponseInterface $response)
@@ -33,7 +33,7 @@ 
             )));
 
         if (property_exists($result, 'error')) {
-            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
+            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
             $checkResult->addAttribute(new Attribute('Google response', json_encode($result), true));
             return $checkResult;
         }
@@ -41,9 +41,9 @@ 
         $passResult = $result->ruleGroups->USABILITY;
 
         if (!$passResult->pass) {
-            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
         }
 
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
     }
 }

src/Rules/Http/DurationRule.php

Spacing +4 added lines, -4 removed lines

@@ -29,14 +29,14 @@
             if ($response->getDuration() > $this->maxDuration) {
                 return new CheckResult(
                     CheckResult::STATUS_FAILURE,
-                    'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                    (int)$response->getDuration());
+                    'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                    (int) $response->getDuration());
             }
 
             return new CheckResult(
                 CheckResult::STATUS_SUCCESS,
-                'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                (int)$response->getDuration());
+                'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                (int) $response->getDuration());
         }
     }
 }

src/Rules/Xml/Sitemap/ValidRule.php

Doc Comments +5 added lines, -2 removed lines

@@ -27,6 +27,9 @@ 
         $this->strictMode = $strictMode;
     }
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         if ($isIndex) {
@@ -41,8 +44,8 @@ 
     }
 
     /**
-     * @param $body
-     * @param $filename
+     * @param string $body
+     * @param string $filename
      * @param bool $isIndex
      * @throws ValidationFailedException
      */

Spacing +8 added lines, -8 removed lines

@@ -30,13 +30,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -56,7 +56,7 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 
@@ -67,16 +67,16 @@ 
     protected function doValidation(ResponseInterface $response)
     {
         if ($response instanceof DomAwareResponse) {
-            $body = (string)$response->getHtmlBody();
+            $body = (string) $response->getHtmlBody();
         } else {
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
         }
 
         // sitemapindex or urlset
         if (preg_match('/<sitemapindex/', $body)) {
-            $this->validateBody($body, (string)$response->getUri());
+            $this->validateBody($body, (string) $response->getUri());
         } elseif (preg_match('/<urlset/', $body)) {
-            $this->validateBody($body, (string)$response->getUri(), false);
+            $this->validateBody($body, (string) $response->getUri(), false);
         }
     }
 }

src/Rules/Xml/XmlCheckRule.php

Spacing +4 added lines, -4 removed lines

@@ -24,9 +24,9 @@ 
     public function doValidation(ResponseInterface $response)
     {
         if ($response instanceof DomAwareResponse) {
-            $body = (string)$response->getHtmlBody();
+            $body = (string) $response->getHtmlBody();
         } else {
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
         }
 
         if ($body == "") {
@@ -45,8 +45,8 @@ 
             $lastError = libxml_get_last_error();
 
             if ($lastError) {
-                throw new ValidationFailedException('The xml file ' . $response->getUri() . ' is not well formed (last error: ' .
-                    str_replace("\n", '', $lastError->message) . ').');
+                throw new ValidationFailedException('The xml file '.$response->getUri().' is not well formed (last error: '.
+                    str_replace("\n", '', $lastError->message).').');
             } else {
                 return new CheckResult(CheckResult::STATUS_FAILURE, 'Unknown error occured.');
             }