phmLabs / Smoke

src/Rules/Html/XPathExistsRule.php

Spacing +9 added lines, -9 removed lines

@@ -31,12 +31,12 @@ 
 
         // @todo this could be part of an abstract class
         if ($this->useDom) {
-            $content = (string)$response->getBody();
+            $content = (string) $response->getBody();
         } else {
             if ($response instanceof DomAwareResponse) {
                 $content = $response->getHtmlBody();
             } else {
-                $content = (string)$response->getBody();
+                $content = (string) $response->getBody();
             }
         }
 
@@ -48,16 +48,16 @@ 
             $count = $domXPath->query($xpath['pattern'])->length;
 
             if ($xpath['relation'] === 'equals') {
-                $result = $count === (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
+                $result = $count === (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
             } elseif ($xpath['relation'] === 'less than') {
-                $result = $count < (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
+                $result = $count < (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
             } elseif ($xpath['relation'] === 'greater than') {
-                $result = $count > (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
+                $result = $count > (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
             } else {
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
             }
 
             $this->assert($result, $message);

src/Rules/Seo/GoogleMobileFriendlyRule.php

Spacing +4 added lines, -4 removed lines

@@ -14,7 +14,7 @@ 
 
     private function getEndpoint(UriInterface $uri)
     {
-        return str_replace('#url#', urlencode((string)$uri), self::ENDPOINT);
+        return str_replace('#url#', urlencode((string) $uri), self::ENDPOINT);
     }
 
     public function validate(ResponseInterface $response)
@@ -33,7 +33,7 @@ 
             )));
 
         if (property_exists($result, 'error')) {
-            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
+            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
             $checkResult->addAttribute(new Attribute('Google response', json_encode($result), true));
             return $checkResult;
         }
@@ -41,9 +41,9 @@ 
         $passResult = $result->ruleGroups->USABILITY;
 
         if (!$passResult->pass) {
-            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
         }
 
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
     }
 }

src/Rules/Http/DurationRule.php

Spacing +4 added lines, -4 removed lines

@@ -29,14 +29,14 @@
             if ($response->getDuration() > $this->maxDuration) {
                 return new CheckResult(
                     CheckResult::STATUS_FAILURE,
-                    'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                    (int)$response->getDuration());
+                    'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                    (int) $response->getDuration());
             }
 
             return new CheckResult(
                 CheckResult::STATUS_SUCCESS,
-                'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                (int)$response->getDuration());
+                'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                (int) $response->getDuration());
         }
     }
 }

src/Rules/Xml/Sitemap/ValidRule.php

Spacing +8 added lines, -8 removed lines

@@ -30,13 +30,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -56,7 +56,7 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 
@@ -67,16 +67,16 @@ 
     protected function doValidation(ResponseInterface $response)
     {
         if ($response instanceof DomAwareResponse) {
-            $body = (string)$response->getHtmlBody();
+            $body = (string) $response->getHtmlBody();
         } else {
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
         }
 
         // sitemapindex or urlset
         if (preg_match('/<sitemapindex/', $body)) {
-            $this->validateBody($body, (string)$response->getUri());
+            $this->validateBody($body, (string) $response->getUri());
         } elseif (preg_match('/<urlset/', $body)) {
-            $this->validateBody($body, (string)$response->getUri(), false);
+            $this->validateBody($body, (string) $response->getUri(), false);
         }
     }
 }

src/Rules/Xml/XmlCheckRule.php

Spacing +4 added lines, -4 removed lines

@@ -24,9 +24,9 @@ 
     public function doValidation(ResponseInterface $response)
     {
         if ($response instanceof DomAwareResponse) {
-            $body = (string)$response->getHtmlBody();
+            $body = (string) $response->getHtmlBody();
         } else {
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
         }
 
         if ($body == "") {
@@ -45,8 +45,8 @@ 
             $lastError = libxml_get_last_error();
 
             if ($lastError) {
-                throw new ValidationFailedException('The xml file ' . $response->getUri() . ' is not well formed (last error: ' .
-                    str_replace("\n", '', $lastError->message) . ').');
+                throw new ValidationFailedException('The xml file '.$response->getUri().' is not well formed (last error: '.
+                    str_replace("\n", '', $lastError->message).').');
             } else {
                 return new CheckResult(CheckResult::STATUS_FAILURE, 'Unknown error occured.');
             }

src/Rules/Html/InvalidUrlsRule.php

Spacing +5 added lines, -5 removed lines

@@ -18,22 +18,22 @@
      */
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody(), false);
+        $document = new Document((string) $response->getBody(), false);
         $urls = $document->getDependencies($response->getUri());
         $invalidUrls = array();
 
         foreach ($urls as $url) {
             if (function_exists('idn_to_ascii')) {
-                $idnUrl = $url->getScheme() . '://' . idn_to_ascii($url->getHost()) . $url->getPath();
+                $idnUrl = $url->getScheme().'://'.idn_to_ascii($url->getHost()).$url->getPath();
             } else {
-                $idnUrl = $url->getScheme() . '://' . $url->getHost() . $url->getPath();
+                $idnUrl = $url->getScheme().'://'.$url->getHost().$url->getPath();
             }
 
             if (!filter_var($idnUrl, FILTER_VALIDATE_URL)) {
-                $invalidUrls[] = (string)$url;
+                $invalidUrls[] = (string) $url;
             }
         }
 
-        $this->assert(count($invalidUrls) === 0, 'Invalid urls found (' . implode(', ', $invalidUrls) . ').');
+        $this->assert(count($invalidUrls) === 0, 'Invalid urls found ('.implode(', ', $invalidUrls).').');
     }
 }

src/Cli/Command/SmokeCommand.php

Spacing +5 added lines, -5 removed lines

@@ -48,13 +48,13 @@ 
     protected function writeSmokeCredentials($url = null)
     {
         if (defined('SMOKE_CREDENTIALS')) {
-            $this->output->writeln("\n " . SMOKE_CREDENTIALS . "\n");
+            $this->output->writeln("\n ".SMOKE_CREDENTIALS."\n");
         } else {
-            $this->output->writeln("\n Smoke " . SMOKE_VERSION . " by Nils Langner\n");
+            $this->output->writeln("\n Smoke ".SMOKE_VERSION." by Nils Langner\n");
         }
 
         if ($url) {
-            $this->output->writeln(' <info>Scanning ' . $url . "</info>\n");
+            $this->output->writeln(' <info>Scanning '.$url."</info>\n");
         }
     }
 
@@ -101,12 +101,12 @@ 
         if ($configFile) {
             if (strpos($configFile, 'http://') === 0 || strpos($configFile, 'https://') === 0) {
                 $curlClient = new Client();
-                $fileContent = (string)$curlClient->get($configFile)->getBody();
+                $fileContent = (string) $curlClient->get($configFile)->getBody();
             } else {
                 if (file_exists($configFile)) {
                     $fileContent = file_get_contents($configFile);
                 } else {
-                    throw new \RuntimeException("Config file was not found ('" . $configFile . "').");
+                    throw new \RuntimeException("Config file was not found ('".$configFile."').");
                 }
             }
             $configArray = EnvAwareYaml::parse($fileContent);

src/Extensions/SmokeResponseRetriever/Retriever/Crawler/Filter/BlackWhiteListFilter.php

Spacing +2 added lines, -2 removed lines

@@ -15,9 +15,9 @@
     public function isFiltered(UriInterface $uri, UriInterface $startPage)
     {
         foreach ($this->whitelist as $whitelist) {
-            if (preg_match($whitelist, (string)$uri)) {
+            if (preg_match($whitelist, (string) $uri)) {
                 foreach ($this->blacklist as $blacklist) {
-                    if (preg_match($blacklist, (string)$uri)) {
+                    if (preg_match($blacklist, (string) $uri)) {
                         return true;
                     }
                 }

src/Rules/Http/RedirectRule.php

Spacing +8 added lines, -8 removed lines

@@ -28,30 +28,30 @@ 
         $client = new GuzzleClient();
         $errors = [];
 
-        $targetUrl = (string)$this->removeCredentials($response->getUri());
+        $targetUrl = (string) $this->removeCredentials($response->getUri());
 
 
         foreach ($this->urls as $url) {
             $uri = new Uri($url['url']);
 
             $urlResponses = $client->sendRequests([new Request('GET', $uri)]);
-            $effectiveUrl = (string)$urlResponses[0]->getEffectiveUri();
+            $effectiveUrl = (string) $urlResponses[0]->getEffectiveUri();
 
             if ($effectiveUrl != $targetUrl) {
-                $errors[] = 'The url "' . $url['url'] . '" gets redirected to "' . $effectiveUrl . '".';
+                $errors[] = 'The url "'.$url['url'].'" gets redirected to "'.$effectiveUrl.'".';
             }
         }
 
         if (count($errors) > 0) {
-            $message = 'Not all given urls do redirect to "' . $targetUrl . '"".<ul>';
+            $message = 'Not all given urls do redirect to "'.$targetUrl.'"".<ul>';
             foreach ($errors as $error) {
-                $message .= '<li>' . $error . '</li>';
+                $message .= '<li>'.$error.'</li>';
             }
             $message .= "</ul>";
 
             return new CheckResult(CheckResult::STATUS_FAILURE, $message);
         } else {
-            return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to ' . (string)$response->getUri());
+            return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to '.(string) $response->getUri());
         }
     }
 
@@ -59,10 +59,10 @@ 
     {
         $query = '';
         if ($uri->getQuery()) {
-            $query = "?" . $uri->getQuery();
+            $query = "?".$uri->getQuery();
         }
 
-        $plainUri = $uri->getScheme() . '://' . $uri->getHost() . $uri->getPath() . $query;
+        $plainUri = $uri->getScheme().'://'.$uri->getHost().$uri->getPath().$query;
 
         return new Uri($plainUri);
     }