phmLabs / Smoke

src/Rules/Html/InsecureContentRule.php

Spacing +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
             return;
         }
 
-        $htmlDocument = new Document((string)$response->getBody());
+        $htmlDocument = new Document((string) $response->getBody());
 
         $resources = $htmlDocument->getDependencies($uri, false);
 
@@ -54,7 +54,7 @@ 
             if ($resource->getScheme() && 'https' !== $resource->getScheme()) {
                 $excluded = false;
                 foreach ($this->excludedFiles as $excludedFile) {
-                    if (preg_match('~' . $excludedFile . '~', (string)$resource)) {
+                    if (preg_match('~'.$excludedFile.'~', (string) $resource)) {
                         $excluded = true;
                         break;
                     }
@@ -68,7 +68,7 @@ 
         if (count($unsecures) > 0) {
             $message = 'At least one dependency was found on a secure url, that was transfered insecure.<ul>';
             foreach ($unsecures as $unsecure) {
-                $message .= '<li>' . (string)$unsecure . '</li>';
+                $message .= '<li>'.(string) $unsecure.'</li>';
             }
             $message .= '</ul>';
             return new CheckResult(CheckResult::STATUS_FAILURE, $message, count($unsecures));

src/Cli/Command/CustomCommand.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
         $configArray = $this->getConfigArray($configFile, true);
 
         if (is_string($configArray)) {
-            throw new \RuntimeException('Unable to load config file. Please check ' . $configFile);
+            throw new \RuntimeException('Unable to load config file. Please check '.$configFile);
         }
 
         $this->config = new Configuration(new Uri('http://www.example.com'), $dispatcher, $configArray);

src/Extensions/SmokeReporter/Reporter/HtmlReporter.php

Spacing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
         $this->resultFile = $resultFile;
 
         if ($templateDir === null) {
-            $this->templateDir = __DIR__ . '/templates';
+            $this->templateDir = __DIR__.'/templates';
         } else {
             $this->templateDir = $templateDir;
         }
@@ -66,9 +66,9 @@ 
         }
 
         if (!file_put_contents($this->resultFile, $html)) {
-            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to " . $this->resultFile ."</error>");
+            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to ".$this->resultFile."</error>");
         } else {
-            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to " . $this->resultFile);
+            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to ".$this->resultFile);
         }
     }
 

src/Extensions/SmokeReporter/Reporter/KoalamonSummaryReporter.php

Spacing +6 added lines, -6 removed lines

@@ -52,7 +52,7 @@ 
     const STATUS_SUCCESS = 'success';
     const STATUS_FAILURE = 'failure';
 
-    public function init($apiKey, Configuration $_configuration, OutputInterface $_output, $server = 'https://webhook.koalamon.com', $system = '', $identifier = '', $tool = '', $url ='')
+    public function init($apiKey, Configuration $_configuration, OutputInterface $_output, $server = 'https://webhook.koalamon.com', $system = '', $identifier = '', $tool = '', $url = '')
     {
         $httpClient = new \GuzzleHttp\Client();
 
@@ -82,7 +82,7 @@ 
     public function processResults($results)
     {
         foreach ($results as $result) {
-            if($result->getStatus() == CheckResult::STATUS_SUCCESS) {
+            if ($result->getStatus() == CheckResult::STATUS_SUCCESS) {
                 $this->success++;
             } else {
                 $this->failed++;
@@ -93,8 +93,8 @@ 
     public function finish()
     {
         $message = 'Checks: ';
-        $message .= $this->success . ' succeeded, ';
-        $message .= $this->failed . ' failed. ';
+        $message .= $this->success.' succeeded, ';
+        $message .= $this->failed.' failed. ';
 
         if ($this->failed > 0) {
             $status = Event::STATUS_FAILURE;
@@ -129,8 +129,8 @@ 
                 $this->reporter->sendEvent($event);
             } catch (KoalamonException $e) {
                 $this->output->writeln("\n  <error> Error sending result to leankoala. </error>");
-                $this->output->writeln('   Url: ' . $e->getUrl());
-                $this->output->writeln('   Payload: ' . $e->getPayload());
+                $this->output->writeln('   Url: '.$e->getUrl());
+                $this->output->writeln('   Payload: '.$e->getPayload());
                 $this->output->writeln("");
             } catch (\Exception $e) {
                 $this->output->writeln($e->getMessage());

src/Scanner/Scanner.php

Spacing +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
             } catch (ValidationFailedException $e) {
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $e->getMessage());
             } catch (\Exception $e) {
-                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: ' . $e->getMessage());
+                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: '.$e->getMessage());
             }
 
             $this->eventDispatcher->simpleNotify('Scanner.CheckResponse.Rule', array('checkResult' => $result, 'ruleName' => $name));

src/Config/Configuration.php

Spacing +4 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
     private function initConfigArray(array $configArray, array $defaultSettings = null)
     {
         if ($defaultSettings === null) {
-            $defaultSettings = Yaml::parse(file_get_contents(__DIR__ . '/../settings/' . self::DEFAULT_SETTINGS));
+            $defaultSettings = Yaml::parse(file_get_contents(__DIR__.'/../settings/'.self::DEFAULT_SETTINGS));
         }
 
         if (count($configArray) === 0) {
@@ -169,7 +169,7 @@ 
         if ($this->hasSection($section)) {
             return $this->configArray[$section];
         } else {
-            throw new \RuntimeException('The section (' . $section . ') you are trying to access does not exist.');
+            throw new \RuntimeException('The section ('.$section.') you are trying to access does not exist.');
         }
     }
 
@@ -178,7 +178,7 @@ 
         if (array_key_exists($name, $this->extensions)) {
             return $this->extensions[$name];
         } else {
-            throw new \RuntimeException('The extension ("' . $name . '") you are trying to access does not exist. Registered extensions are: ' . implode(' ,', array_keys($this->extensions)) . '.');
+            throw new \RuntimeException('The extension ("'.$name.'") you are trying to access does not exist. Registered extensions are: '.implode(' ,', array_keys($this->extensions)).'.');
         }
     }
 
@@ -203,7 +203,7 @@ 
             try {
                 $client = Init::initialize($this->configArray['client']);
             } catch (\Exception $e) {
-                throw new ConfigurationException('Error initializing client (' . $e->getMessage() . ')');
+                throw new ConfigurationException('Error initializing client ('.$e->getMessage().')');
             }
 
             return $client;

src/Rules/Cookies/CountRule.php

Spacing +2 added lines, -2 removed lines

@@ -36,12 +36,12 @@
                 if ($cookieCount > $this->maxCookies) {
                     $result = new CheckResult(
                         CheckResult::STATUS_FAILURE,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 } else {
                     $result = new CheckResult(
                         CheckResult::STATUS_SUCCESS,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 }
 

src/Rules/Html/CssSelectorExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
 
     public function doValidation(ResponseInterface $response)
     {
-        $content = (string)$response->getBody();
+        $content = (string) $response->getBody();
 
         $domDocument = new \DOMDocument();
         @$domDocument->loadHTML($content);
@@ -40,7 +40,7 @@ 
             try {
                 $selectorAsXPath = $converter->toXPath($selector['pattern']);
             } catch (\Exception $e) {
-                throw new ValidationFailedException('Invalid css selector (' . $selector['pattern'] . ').');
+                throw new ValidationFailedException('Invalid css selector ('.$selector['pattern'].').');
             }
 
             $count = $domXPath->query($selectorAsXPath)->length;
@@ -54,7 +54,7 @@ 
         if ($error === true) {
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
 
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
         }
     }
 }

src/Rules/Http/Header/GZipRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
                 && strpos($response->getContentType(), 'pdf') === false
                 && strpos($response->getContentType(), 'postscript') === false
                 && strpos($response->getContentType(), 'zip') === false
-                && strlen((string)$response->getBody()) >= $this->minFileSize
+                && strlen((string) $response->getBody()) >= $this->minFileSize
             ) {
                 if (!$response->hasHeader('Content-Encoding') || $response->getHeader('Content-Encoding')[0] !== 'gzip') {
                     throw new ValidationFailedException('gzip compression not active');