phmLabs / Smoke

src/Rules/CheckResult.php

Doc Comments +4 added lines, -4 removed lines

@@ -26,7 +26,7 @@ 
      * Result constructor.
      *
      * @param $status
-     * @param $value
+     * @param integer $value
      * @param $message
      */
     public function __construct($status, $message = '', $value = null)
@@ -45,7 +45,7 @@ 
     }
 
     /**
-     * @param array $attributes
+     * @param array $attribute
      */
     public function addAttribute(Attribute $attribute)
     {
@@ -69,7 +69,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getMessage()
     {
@@ -85,7 +85,7 @@ 
     }
 
     /**
-     * @param Response $response
+     * @param ResponseInterface $response
      */
     public function setResponse(ResponseInterface $response)
     {

src/Rules/Html/CssFileCountRule.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use whm\Html\Document;
-use whm\Smoke\Http\Response;
 
 /**
  * This rules counts the css files that are included in a document. If the number is higher

src/Rules/Html/JsFileCountRule.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use whm\Html\Document;
-use whm\Smoke\Http\Response;
 
 /**
  * This rules counts the js files that are included in a document. If the number is higher

src/Rules/Html/NoIndexRule.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use Symfony\Component\DomCrawler\Crawler;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\StandardRule;
 
 /**

src/Rules/Seo/PageSpeedRule.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace whm\Smoke\Rules\Seo;
 
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\ValidationFailedException;
 

src/Rules/StandardRule.php

Doc Comments +4 added lines

@@ -28,6 +28,10 @@
 
     abstract protected function doValidation(ResponseInterface $response);
 
+    /**
+     * @param boolean $valueToBeTrue
+     * @param string $errorMessage
+     */
     protected function assert($valueToBeTrue, $errorMessage)
     {
         if (!$valueToBeTrue) {

src/Extensions/SmokeFilter/FilterExtension.php

Spacing +4 added lines, -4 removed lines

@@ -41,12 +41,12 @@ 
     public function init($filters = array(), $filterFile = '', $exclusive = array())
     {
         if (count($exclusive) > 0 && (count($filters) > 0 || $filterFile !== '')) {
-            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: " . get_class($this) . '].');
+            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: ".get_class($this).'].');
         }
 
         if ($filterFile !== '') {
             if (!file_exists($filterFile)) {
-                throw new \RuntimeException('Filter file not found: ' . $filterFile);
+                throw new \RuntimeException('Filter file not found: '.$filterFile);
             }
 
             $filterElements = EnvAwareYaml::parse(file_get_contents($filterFile));
@@ -85,7 +85,7 @@ 
      */
     public function isFiltered(Event $event, $ruleName, UriAwareResponse $response)
     {
-        $uri = (string)$this->retriever->getOriginUri($response->getUri());
+        $uri = (string) $this->retriever->getOriginUri($response->getUri());
 
         if ($this->currentModus === self::MODUS_FILTER) {
             $isFiltered = $this->isFilteredByFilter($ruleName, $uri);
@@ -104,7 +104,7 @@ 
     private function isFilteredByFilter($ruleName, $uri)
     {
         foreach ($this->filters as $filter) {
-            if ($ruleName === $filter['rule'] && 0 < preg_match('$' . $filter['uri'] . '$', $uri)) {
+            if ($ruleName === $filter['rule'] && 0 < preg_match('$'.$filter['uri'].'$', $uri)) {
                 return true;
             }
         }

src/Extensions/SmokeResponseRetriever/Retriever/ListRetriever/Retriever.php

Spacing +10 added lines, -10 removed lines

@@ -109,20 +109,20 @@ 
                         /* @var \Ivory\HttpAdapter\HttpAdapterException $exception */
 
                         $mainUri = $request->getUri();
-                        $this->redirects[(string)$mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl] = (string)$mainUri;
+                        $this->redirects[(string) $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl] = (string) $mainUri;
 
-                        $this->urls[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
-                        $this->urlStack[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
+                        $this->urls[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
+                        $this->urlStack[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
 
                         return $this->next();
                     }
 
                     // the error handling should be done withing the calling class
-                    echo "\n   " . $exception->getMessage() . "\n";
+                    echo "\n   ".$exception->getMessage()."\n";
 
                     return $this->next();
                 } else {
-                    $errorMessages .= $exception->getMessage() . "\n";
+                    $errorMessages .= $exception->getMessage()."\n";
                 }
             }
             if ($errorMessages !== '') {
@@ -135,8 +135,8 @@ 
 
     public function getOriginUri(UriInterface $uri)
     {
-        if (array_key_exists((string)$uri, $this->redirects)) {
-            return $this->urls[$this->redirects[(string)$uri]]['url'];
+        if (array_key_exists((string) $uri, $this->redirects)) {
+            return $this->urls[$this->redirects[(string) $uri]]['url'];
         }
 
         return $uri;
@@ -149,11 +149,11 @@ 
 
     public function getSystem(UriInterface $uri)
     {
-        if (array_key_exists((string)$uri, $this->redirects)) {
-            return $this->urls[$this->redirects[(string)$uri]]['system'];
+        if (array_key_exists((string) $uri, $this->redirects)) {
+            return $this->urls[$this->redirects[(string) $uri]]['system'];
         }
 
-        return $this->urls[(string)$uri]['system'];
+        return $this->urls[(string) $uri]['system'];
     }
 
     public function getSystems()

src/Extensions/SmokeReporter/Reporter/XUnitReporter.php

Spacing +4 added lines, -4 removed lines

@@ -59,7 +59,7 @@ 
         $failures = 0;
 
         if ($this->retriever instanceof CrawlingRetriever) {
-            $startPage = (string)$this->retriever->getStartPage();
+            $startPage = (string) $this->retriever->getStartPage();
         } else {
             $startPage = '';
         }
@@ -80,8 +80,8 @@ 
                     $testCase->addFailure(new Failure($ruleName, $message));
 
                     if ($this->retriever instanceof CrawlingRetriever) {
-                        $stackTrace = $result->getUrl() . ' coming from ' . (string)$this->retriever->getComingFrom($result->getUrl()) . PHP_EOL;
-                        $stackTrace .= '    - ' . $message . " [rule: $ruleName]";
+                        $stackTrace = $result->getUrl().' coming from '.(string) $this->retriever->getComingFrom($result->getUrl()).PHP_EOL;
+                        $stackTrace .= '    - '.$message." [rule: $ruleName]";
                         $testCase->setSystemOut($stackTrace);
                     }
                 }
@@ -92,7 +92,7 @@ 
 
         file_put_contents($this->filename, $xUnitReport->toXml());
 
-        $this->output->writeln('    <info>Writing XUnit Output to file:</info> ' . $this->filename);
+        $this->output->writeln('    <info>Writing XUnit Output to file:</info> '.$this->filename);
     }
 
     public function processResults($results)