phmLabs / Smoke

src/Rules/Http/Header/GZipRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
                 && strpos($response->getContentType(), 'pdf') === false
                 && strpos($response->getContentType(), 'postscript') === false
                 && strpos($response->getContentType(), 'zip') === false
-                && strlen((string)$response->getBody()) >= $this->minFileSize
+                && strlen((string) $response->getBody()) >= $this->minFileSize
             ) {
                 if (!$response->hasHeader('Content-Encoding') || $response->getHeader('Content-Encoding')[0] !== 'gzip') {
                     throw new ValidationFailedException('gzip compression not active');

src/Extensions/SmokeReporter/Reporter/CliReporter.php

Spacing +7 added lines, -7 removed lines

@@ -37,10 +37,10 @@ 
         if ($response instanceof RequestAwareResponse) {
             $request = $response->getRequest();
             if ($request instanceof DeviceAwareRequest) {
-                return ' (Device: ' . $request->getDevice()->getName() . ')';
+                return ' (Device: '.$request->getDevice()->getName().')';
             } else if ($request instanceof ViewportAwareRequest) {
                 $viewport = $request->getViewport();
-                return ' (Viewport: width: ' . $viewport->getWidth() . ', height: ' . $viewport->getHeight() . ')';
+                return ' (Viewport: width: '.$viewport->getWidth().', height: '.$viewport->getHeight().')';
             }
         }
 
@@ -49,19 +49,19 @@ 
 
     protected function renderFailure(CheckResult $result)
     {
-        $this->output->writeln('   <error> ' . (string)$result->getResponse()->getUri() . $this->getRequestString($result->getResponse()) . ' </error> coming from ' . (string)$this->retriever->getComingFrom($result->getResponse()->getUri()));
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <error> '.(string) $result->getResponse()->getUri().$this->getRequestString($result->getResponse()).' </error> coming from '.(string) $this->retriever->getComingFrom($result->getResponse()->getUri()));
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
         $this->output->writeln('');
     }
 
     protected function renderSuccess(CheckResult $result)
     {
-        $this->output->writeln('   <info> ' . (string)$result->getResponse()->getUri() . $this->getRequestString($result->getResponse()) . ' </info> all tests passed');
+        $this->output->writeln('   <info> '.(string) $result->getResponse()->getUri().$this->getRequestString($result->getResponse()).' </info> all tests passed');
     }
 
     protected function renderSkipped(CheckResult $result)
     {
-        $this->output->writeln('   <comment> ' . (string)$result->getResponse()->getUri() . $this->getRequestString($result->getResponse()) . ' </comment>test skipped');
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <comment> '.(string) $result->getResponse()->getUri().$this->getRequestString($result->getResponse()).' </comment>test skipped');
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
     }
 }

src/Rules/Html/XPathExistsRule.php

Spacing +9 added lines, -9 removed lines

@@ -31,12 +31,12 @@ 
 
         // @todo this could be part of an abstract class
         if ($this->useDom) {
-            $content = (string)$response->getBody();
+            $content = (string) $response->getBody();
         } else {
             if ($response instanceof DomAwareResponse) {
                 $content = $response->getHtmlBody();
             } else {
-                $content = (string)$response->getBody();
+                $content = (string) $response->getBody();
             }
         }
 
@@ -48,16 +48,16 @@ 
             $count = $domXPath->query($xpath['pattern'])->length;
 
             if ($xpath['relation'] === 'equals') {
-                $result = $count === (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
+                $result = $count === (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
             } elseif ($xpath['relation'] === 'less than') {
-                $result = $count < (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
+                $result = $count < (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
             } elseif ($xpath['relation'] === 'greater than') {
-                $result = $count > (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
+                $result = $count > (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
             } else {
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
             }
 
             $this->assert($result, $message);

src/Rules/Http/DurationRule.php

Spacing +4 added lines, -4 removed lines

@@ -29,14 +29,14 @@
             if ($response->getDuration() > $this->maxDuration) {
                 return new CheckResult(
                     CheckResult::STATUS_FAILURE,
-                    'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                    (int)$response->getDuration());
+                    'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                    (int) $response->getDuration());
             }
 
             return new CheckResult(
                 CheckResult::STATUS_SUCCESS,
-                'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                (int)$response->getDuration());
+                'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                (int) $response->getDuration());
         }
     }
 }

src/Rules/Xml/Sitemap/ValidRule.php

Doc Comments +5 added lines, -2 removed lines

@@ -27,6 +27,9 @@ 
         $this->strictMode = $strictMode;
     }
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         if ($isIndex) {
@@ -41,8 +44,8 @@ 
     }
 
     /**
-     * @param $body
-     * @param $filename
+     * @param string $body
+     * @param string $filename
      * @param bool $isIndex
      * @throws ValidationFailedException
      */

Spacing +9 added lines, -9 removed lines

@@ -36,13 +36,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -61,10 +61,10 @@ 
 
         if (!$valid) {
             $lastError = libxml_get_last_error();
-            $message = 'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').';
+            $message = 'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').';
             return new CheckResult(CheckResult::STATUS_FAILURE, $message);
         } else {
-            $message = 'The given sitemap file (' . $filename . ') is valid.';
+            $message = 'The given sitemap file ('.$filename.') is valid.';
             return new CheckResult(CheckResult::STATUS_SUCCESS, $message);
 
         }
@@ -79,9 +79,9 @@ 
         $contentType = $response->getHeader('content-type');
 
         if ($response instanceof DomAwareResponse) {
-            $body = (string)$response->getHtmlBody();
+            $body = (string) $response->getHtmlBody();
         } else {
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
         }
 
         if (is_array($contentType) && in_array(strtolower($contentType[0]), $this->gzipContentTypes)) {
@@ -90,9 +90,9 @@ 
 
         // sitemapindex or urlset
         if (preg_match('/<sitemapindex/', $body)) {
-            return $this->validateBody($body, (string)$response->getUri(), true);
+            return $this->validateBody($body, (string) $response->getUri(), true);
         } elseif (preg_match('/<urlset/', $body)) {
-            return $this->validateBody($body, (string)$response->getUri(), false);
+            return $this->validateBody($body, (string) $response->getUri(), false);
         } else {
             throw new ValidationFailedException('The given document is not a valid sitemap. Nether sitemapindex nor urlset element was found. ');
         }

src/Rules/Xml/XmlCheckRule.php

Spacing +4 added lines, -4 removed lines

@@ -24,9 +24,9 @@ 
     public function doValidation(ResponseInterface $response)
     {
         if ($response instanceof DomAwareResponse) {
-            $body = (string)$response->getHtmlBody();
+            $body = (string) $response->getHtmlBody();
         } else {
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
         }
 
         if ($body == "") {
@@ -45,8 +45,8 @@ 
             $lastError = libxml_get_last_error();
 
             if ($lastError) {
-                throw new ValidationFailedException('The xml file ' . $response->getUri() . ' is not well formed (last error: ' .
-                    str_replace("\n", '', $lastError->message) . ').');
+                throw new ValidationFailedException('The xml file '.$response->getUri().' is not well formed (last error: '.
+                    str_replace("\n", '', $lastError->message).').');
             } else {
                 return new CheckResult(CheckResult::STATUS_FAILURE, 'Unknown error occured.');
             }

src/Rules/CheckResult.php

Doc Comments +3 added lines, -2 removed lines

@@ -38,6 +38,7 @@ 
      * @param $status
      * @param $value
      * @param $message
+     * @param string $url
      */
     public function __construct($status, $message = '', $value = null, $url = null)
     {
@@ -56,7 +57,7 @@ 
     }
 
     /**
-     * @param array $attributes
+     * @param array $attribute
      */
     public function addAttribute(Attribute $attribute)
     {
@@ -109,7 +110,7 @@ 
     }
 
     /**
-     * @param string $identifier
+     * @param string $identifierRule
      */
     public function setIdentifierRule($identifierRule)
     {

Spacing +2 added lines, -2 removed lines

@@ -64,8 +64,8 @@
      */
     public function hasAttribute($key)
     {
-        foreach($this->attributes as $attribute) {
-            if($attribute->getKey() == $key) {
+        foreach ($this->attributes as $attribute) {
+            if ($attribute->getKey() == $key) {
                 return true;
             }
         }

src/Rules/Html/InvalidUrlsRule.php

Spacing +5 added lines, -5 removed lines

@@ -18,22 +18,22 @@
      */
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody(), false);
+        $document = new Document((string) $response->getBody(), false);
         $urls = $document->getDependencies($response->getUri());
         $invalidUrls = array();
 
         foreach ($urls as $url) {
             if (function_exists('idn_to_ascii')) {
-                $idnUrl = $url->getScheme() . '://' . idn_to_ascii($url->getHost()) . $url->getPath();
+                $idnUrl = $url->getScheme().'://'.idn_to_ascii($url->getHost()).$url->getPath();
             } else {
-                $idnUrl = $url->getScheme() . '://' . $url->getHost() . $url->getPath();
+                $idnUrl = $url->getScheme().'://'.$url->getHost().$url->getPath();
             }
 
             if (!filter_var($idnUrl, FILTER_VALIDATE_URL)) {
-                $invalidUrls[] = (string)$url;
+                $invalidUrls[] = (string) $url;
             }
         }
 
-        $this->assert(count($invalidUrls) === 0, 'Invalid urls found (' . implode(', ', $invalidUrls) . ').');
+        $this->assert(count($invalidUrls) === 0, 'Invalid urls found ('.implode(', ', $invalidUrls).').');
     }
 }

src/Cli/Command/SmokeCommand.php

Spacing +5 added lines, -5 removed lines

@@ -48,13 +48,13 @@ 
     protected function writeSmokeCredentials($url = null)
     {
         if (defined('SMOKE_CREDENTIALS')) {
-            $this->output->writeln("\n " . SMOKE_CREDENTIALS . "\n");
+            $this->output->writeln("\n ".SMOKE_CREDENTIALS."\n");
         } else {
-            $this->output->writeln("\n Smoke " . SMOKE_VERSION . " by Nils Langner\n");
+            $this->output->writeln("\n Smoke ".SMOKE_VERSION." by Nils Langner\n");
         }
 
         if ($url) {
-            $this->output->writeln(' <info>Scanning ' . $url . "</info>\n");
+            $this->output->writeln(' <info>Scanning '.$url."</info>\n");
         }
     }
 
@@ -101,12 +101,12 @@ 
         if ($configFile) {
             if (strpos($configFile, 'http://') === 0 || strpos($configFile, 'https://') === 0) {
                 $curlClient = new Client();
-                $fileContent = (string)$curlClient->get($configFile)->getBody();
+                $fileContent = (string) $curlClient->get($configFile)->getBody();
             } else {
                 if (file_exists($configFile)) {
                     $fileContent = file_get_contents($configFile);
                 } else {
-                    throw new \RuntimeException("Config file was not found ('" . $configFile . "').");
+                    throw new \RuntimeException("Config file was not found ('".$configFile."').");
                 }
             }
             $configArray = EnvAwareYaml::parse($fileContent);