phmLabs / Smoke

src/Extensions/SmokeFilter/FilterExtension.php

Spacing +5 added lines, -5 removed lines

@@ -42,12 +42,12 @@ 
     public function init($filters = array(), $filterFile = '', $exclusive = array())
     {
         if (count($exclusive) > 0 && (count($filters) > 0 || $filterFile !== '')) {
-            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: " . get_class($this) . '].');
+            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: ".get_class($this).'].');
         }
 
         if ($filterFile !== '') {
             if (!file_exists($filterFile)) {
-                throw new \RuntimeException('Filter file not found: ' . $filterFile);
+                throw new \RuntimeException('Filter file not found: '.$filterFile);
             }
 
             $filterElements = EnvAwareYaml::parse(file_get_contents($filterFile));
@@ -72,7 +72,7 @@ 
                 if (is_array($urls)) {
                     foreach ($urls as $url) {
                         $uri = new Uri($url);
-                        $this->exclusives[$rule][] = (string)$uri;
+                        $this->exclusives[$rule][] = (string) $uri;
                     }
                 }
             }
@@ -93,7 +93,7 @@ 
      */
     public function isFiltered(Event $event, $ruleName, UriAwareResponse $response)
     {
-        $uri = (string)$this->retriever->getOriginUri($response->getUri());
+        $uri = (string) $this->retriever->getOriginUri($response->getUri());
 
         if ($this->currentModus === self::MODUS_FILTER) {
             $isFiltered = $this->isFilteredByFilter($ruleName, $uri);
@@ -112,7 +112,7 @@ 
     private function isFilteredByFilter($ruleName, $uri)
     {
         foreach ($this->filters as $filter) {
-            if ($ruleName === $filter['rule'] && 0 < preg_match('$' . $filter['uri'] . '$', $uri)) {
+            if ($ruleName === $filter['rule'] && 0 < preg_match('$'.$filter['uri'].'$', $uri)) {
                 return true;
             }
         }

src/Rules/Html/RegExExistsRule.php

Doc Comments -1 removed lines

@@ -16,7 +16,6 @@
     protected $contentTypes = array('text/html', 'application/json', 'application/xml');
 
     /**
-     * @param int $string The string that the document must contain
      */
     public function init(array $regExs)
     {

Spacing +5 added lines, -5 removed lines

@@ -42,12 +42,12 @@ 
             if ($regEx['isRegEx']) {
                 $pattern = str_replace('', '\\~', $regEx['pattern']);
 
-                if (preg_match('~' . $pattern . '~', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Regular expression: ' . $regEx['pattern'];
+                if (preg_match('~'.$pattern.'~', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Regular expression: '.$regEx['pattern'];
                 }
             } else {
-                if (preg_match('^' . preg_quote($regEx['pattern']) . '^', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Text: ' . $regEx['pattern'];
+                if (preg_match('^'.preg_quote($regEx['pattern']).'^', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Text: '.$regEx['pattern'];
                 }
             }
         }
@@ -56,7 +56,7 @@ 
             $errorString = 'The following text elements were not found: <ul>';
 
             foreach ($errors as $error) {
-                $errorString .= '<li>' . $error . '</li>';
+                $errorString .= '<li>'.$error.'</li>';
             }
 
             $errorString .= '</ul>';

src/Extensions/SmokeMemory/MemoryExtension.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
         foreach ($results as $result) {
             /** @var UriAwareResponse $response */
             if ($result->getStatus() == CheckResult::STATUS_FAILURE) {
-                $this->memory[] = (string)$response->getUri();
+                $this->memory[] = (string) $response->getUri();
             }
         }
     }

src/Rules/Html/ClosingHtmlTagRule.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
         if ($response instanceof ContentTypeAwareResponse) {
 
             // @todo this could be part of the StandardRule class
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
             $body = preg_replace('/[\x00-\x09\x0B\x0C\x0E-\x1F\x7F,\xFF,\x8B]/', '', $body);
 
             if (($response->getStatusCode() < 300 || $response->getStatusCode() >= 400)
@@ -25,7 +25,7 @@ 
                 && strlen($body) > 0
             ) {
                 if (stripos($body, '</html>') === false) {
-                    throw new ValidationFailedException('Closing html tag is missing (document length: ' . strlen($body) . ').');
+                    throw new ValidationFailedException('Closing html tag is missing (document length: '.strlen($body).').');
                 }
             }
         }

src/Rules/Html/InsecureContentRule.php

Spacing +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
             return;
         }
 
-        $htmlDocument = new Document((string)$response->getBody());
+        $htmlDocument = new Document((string) $response->getBody());
 
         $resources = $htmlDocument->getDependencies($uri, false);
 
@@ -54,7 +54,7 @@ 
             if ($resource->getScheme() && 'https' !== $resource->getScheme()) {
                 $excluded = false;
                 foreach ($this->excludedFiles as $excludedFile) {
-                    if (preg_match('~' . $excludedFile . '~', (string)$resource)) {
+                    if (preg_match('~'.$excludedFile.'~', (string) $resource)) {
                         $excluded = true;
                         break;
                     }
@@ -68,7 +68,7 @@ 
         if (count($unsecures) > 0) {
             $message = 'At least one dependency was found on a secure url, that was transfered insecure.<ul>';
             foreach ($unsecures as $unsecure) {
-                $message .= '<li>' . (string)$unsecure . '</li>';
+                $message .= '<li>'.(string) $unsecure.'</li>';
             }
             $message .= '</ul>';
             return new CheckResult(CheckResult::STATUS_FAILURE, $message, count($unsecures));

src/Cli/Command/CustomCommand.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
         $configArray = $this->getConfigArray($configFile, true);
 
         if (is_string($configArray)) {
-            throw new \RuntimeException('Unable to load config file. Please check ' . $configFile);
+            throw new \RuntimeException('Unable to load config file. Please check '.$configFile);
         }
 
         $this->config = new Configuration(new Uri('http://www.example.com'), $dispatcher, $configArray);

src/Extensions/SmokeReporter/Reporter/HtmlReporter.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Symfony\Component\Console\Output\OutputInterface;
 use whm\Smoke\Config\Configuration;
-use whm\Smoke\Extensions\SmokeResponseRetriever\Retriever\Retriever;
 use whm\Smoke\Rules\CheckResult;
 
 

Spacing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
         $this->resultFile = $resultFile;
 
         if ($templateDir === null) {
-            $this->templateDir = __DIR__ . '/templates';
+            $this->templateDir = __DIR__.'/templates';
         } else {
             $this->templateDir = $templateDir;
         }
@@ -66,9 +66,9 @@ 
         }
 
         if (!file_put_contents($this->resultFile, $html)) {
-            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to " . $this->resultFile ."</error>");
+            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to ".$this->resultFile."</error>");
         } else {
-            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to " . $this->resultFile);
+            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to ".$this->resultFile);
         }
     }
 

src/Extensions/SmokeReporter/Reporter/KoalamonSummaryReporter.php

Spacing +6 added lines, -6 removed lines

@@ -52,7 +52,7 @@ 
     const STATUS_SUCCESS = 'success';
     const STATUS_FAILURE = 'failure';
 
-    public function init($apiKey, Configuration $_configuration, OutputInterface $_output, $server = 'https://webhook.koalamon.com', $system = '', $identifier = '', $tool = '', $url ='')
+    public function init($apiKey, Configuration $_configuration, OutputInterface $_output, $server = 'https://webhook.koalamon.com', $system = '', $identifier = '', $tool = '', $url = '')
     {
         $httpClient = new \GuzzleHttp\Client();
 
@@ -82,7 +82,7 @@ 
     public function processResults($results)
     {
         foreach ($results as $result) {
-            if($result->getStatus() == CheckResult::STATUS_SUCCESS) {
+            if ($result->getStatus() == CheckResult::STATUS_SUCCESS) {
                 $this->success++;
             } else {
                 $this->failed++;
@@ -93,8 +93,8 @@ 
     public function finish()
     {
         $message = 'Checks: ';
-        $message .= $this->success . ' succeeded, ';
-        $message .= $this->failed . ' failed. ';
+        $message .= $this->success.' succeeded, ';
+        $message .= $this->failed.' failed. ';
 
         if ($this->failed > 0) {
             $status = Event::STATUS_FAILURE;
@@ -129,8 +129,8 @@ 
                 $this->reporter->sendEvent($event);
             } catch (KoalamonException $e) {
                 $this->output->writeln("\n  <error> Error sending result to leankoala. </error>");
-                $this->output->writeln('   Url: ' . $e->getUrl());
-                $this->output->writeln('   Payload: ' . $e->getPayload());
+                $this->output->writeln('   Url: '.$e->getUrl());
+                $this->output->writeln('   Payload: '.$e->getPayload());
                 $this->output->writeln("");
             } catch (\Exception $e) {
                 $this->output->writeln($e->getMessage());

src/Rules/Cookies/CountRule.php

Spacing +2 added lines, -2 removed lines

@@ -36,12 +36,12 @@
                 if ($cookieCount > $this->maxCookies) {
                     $result = new CheckResult(
                         CheckResult::STATUS_FAILURE,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 } else {
                     $result = new CheckResult(
                         CheckResult::STATUS_SUCCESS,
-                        $cookieCount . ' cookies were stored (limit was ' . $this->maxCookies . ').',
+                        $cookieCount.' cookies were stored (limit was '.$this->maxCookies.').',
                         $cookieCount);
                 }
 

Doc Comments -1 removed lines

@@ -18,7 +18,6 @@
     private $maxCookies;
 
     /**
-     * @param int $maxDuration The maximum duration a http call is allowed to take (time to first byte)
      */
     public function init($maxElements = 20)
     {