phmLabs / Smoke

src/Rules/Xml/Sitemap/ValidRule.php

Doc Comments +7 added lines

@@ -16,11 +16,18 @@
 
     protected $contentTypes = array('text/xml', 'application/xml');
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         return ($isIndex) ?  __DIR__ . '/' . self::INDEX : __DIR__ . '/' . self::SCHEMA;
     }
 
+    /**
+     * @param \Psr\Http\Message\StreamInterface $body
+     * @param string $filename
+     */
     private function validateBody($body, $filename, $isIndex = TRUE)
     {
         $dom = new \DOMDocument();

Spacing +4 added lines, -4 removed lines

@@ -29,13 +29,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -49,7 +49,7 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 

src/Rules/Xml/XmlCheckRule.php

Spacing +2 added lines, -2 removed lines

@@ -21,8 +21,8 @@
         if (!$success) {
             $lastError = libxml_get_last_error();
 
-            throw new ValidationFailedException('The xml file ' . $response->getUri() . ' is not well formed (last error: ' .
-                str_replace("\n", '', $lastError->message) . ').');
+            throw new ValidationFailedException('The xml file '.$response->getUri().' is not well formed (last error: '.
+                str_replace("\n", '', $lastError->message).').');
         }
     }
 }

src/Rules/Json/JsonPathExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -65,17 +65,17 @@
 
             if ($jsonValue === FALSE || (is_array($jsonValue) && empty($jsonValue))) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (JSON Path not found)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (JSON Path not found)';
             }
             if ($this->checkRelation($path['relation'], $path['value'], $count) === false) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (number of JSONPaths is not correct corresponding to the given relation/value)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (number of JSONPaths is not correct corresponding to the given relation/value)';
             }
         }
 
         if ($error === true) {
             $allNoCorrectJsonPaths = implode('", "', $noCorrectJsonPaths);
-            throw new ValidationFailedException('Disonances with JSON Paths "' . $allNoCorrectJsonPaths . '!');
+            throw new ValidationFailedException('Disonances with JSON Paths "'.$allNoCorrectJsonPaths.'!');
         }
     }
 }

src/Rules/Html/CssSelectorExistsRule.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         if ($error === true) {
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
 
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
         }
     }
 }

src/Rules/Http/Header/GZipRule.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
     {
         if (strpos($response->getContentType(), 'image') === false
             && strpos($response->getContentType(), 'pdf') === false
-            && strlen((string)$response->getBody()) >= $this->minFileSize
+            && strlen((string) $response->getBody()) >= $this->minFileSize
         ) {
             if (!$response->hasHeader('Content-Encoding') || $response->getHeader('Content-Encoding')[0] !== 'gzip') {
                 throw new ValidationFailedException('gzip compression not active');

src/Rules/Json/JsonSchema/JsonSchemaRule.php

Spacing +6 added lines, -6 removed lines

@@ -38,17 +38,17 @@ 
     {
         $data = json_decode($response->getBody());
         if ($data === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         }
         else {
             $error = false;
             $messageParts = array();
 
             foreach ($this->jsonSchemaFiles AS $jsonSchemaFile) {
-                $factory = new Factory( null, null, Constraint::CHECK_MODE_TYPE_CAST | Constraint::CHECK_MODE_COERCE );
+                $factory = new Factory(null, null, Constraint::CHECK_MODE_TYPE_CAST | Constraint::CHECK_MODE_COERCE);
                 $validator = new Validator($factory);
 
-                $jsonSchemaObject = (object)json_decode(file_get_contents($jsonSchemaFile['jsonschemafileurl']));
+                $jsonSchemaObject = (object) json_decode(file_get_contents($jsonSchemaFile['jsonschemafileurl']));
                 
                 $validator->check($data, $jsonSchemaObject);
 
@@ -56,14 +56,14 @@ 
                     $error = true;
                     $errorMessage = '';
                     foreach ($validator->getErrors() as $error) {
-                        $errorMessage = $errorMessage .  sprintf("[%s] %s\n", $error['property'], $error['message']);
+                        $errorMessage = $errorMessage.sprintf("[%s] %s\n", $error['property'], $error['message']);
                     }
-                    $messageParts[] = $jsonSchemaFile['jsonschemafilename'] . ' - ' . $jsonSchemaFile['jsonschemafileurl'] . '(last error: ' . $errorMessage . ').';
+                    $messageParts[] = $jsonSchemaFile['jsonschemafilename'].' - '.$jsonSchemaFile['jsonschemafileurl'].'(last error: '.$errorMessage.').';
                 }
             }
 
             if ($error == true) {
-                $message = 'JSON file (' . (string)$response->getUri() . ')  does not validate against the following JSON Schema files: ' . implode(", ", $messageParts);
+                $message = 'JSON file ('.(string) $response->getUri().')  does not validate against the following JSON Schema files: '.implode(", ", $messageParts);
                 throw new ValidationFailedException($message);
             }
         }

Braces +1 added lines, -2 removed lines

@@ -39,8 +39,7 @@
         $data = json_decode($response->getBody());
         if ($data === null) {
             throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
-        }
-        else {
+        } else {
             $error = false;
             $messageParts = array();
 

src/Rules/Xml/XmlValidXsdRule.php

Spacing +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
         $dom = new \DOMDocument();
         @$dom->loadXML($body);
 
-        $filename = (string)$response->getUri();
+        $filename = (string) $response->getUri();
 
         $error = false;
         $messageParts = array();
@@ -39,12 +39,12 @@ 
                 $error = true;
                 $lastError = libxml_get_last_error();
 
-                $messageParts[] = $xsdFile['xsdfilename'] . ' - ' . $xsdFile['xsdfileurl'] . '(last error: ' . str_replace("\n", '', $lastError->message) . ').';
+                $messageParts[] = $xsdFile['xsdfilename'].' - '.$xsdFile['xsdfileurl'].'(last error: '.str_replace("\n", '', $lastError->message).').';
             }
         }
 
         if ($error === true) {
-            $message = 'XML file (' . $filename . ')  does not validate against the following XSD files: ' . implode(", ", $messageParts);
+            $message = 'XML file ('.$filename.')  does not validate against the following XSD files: '.implode(", ", $messageParts);
             throw new ValidationFailedException($message);
         }
     }