whm\Smoke\Rules\Xml\XmlValidXsdRule

Complexity

Total Complexity

5

Size/Duplication

Total Lines	40
Duplicated Lines	10 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	4	1
B	doValidation()	4	28	4

<?php

namespace whm\Smoke\Rules\Xml;

use whm\Smoke\Http\Response;
use whm\Smoke\Rules\StandardRule;
use whm\Smoke\Rules\ValidationFailedException;

/**
 * This rule checks if a sitemap.xml file is valid.
 */
class XmlValidXsdRule extends StandardRule
{
    private $xsdFiles;

    protected $contentTypes = array('text/xml', 'application/xml');

    public function init($xsdFiles)
    {
        $this->xsdFiles = $xsdFiles;
    }

    protected function doValidation(Response $response)
    {
        $body = $response->getBody();

        $dom = new \DOMDocument();
        @$dom->loadXML($body);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $filename = (string)$response->getUri();

        $error = false;
        $messageParts = array();

        foreach ($this->xsdFiles AS $xsdFile) {
            $valid = @$dom->schemaValidate($xsdFile['xsdfileurl']);

            if (!$valid) {
                $error = true;
                $lastError = libxml_get_last_error();

                $messageParts[] = $xsdFile['xsdfilename'] . ' - ' . $xsdFile['xsdfileurl'] . '(last error: ' . str_replace("\n", '', $lastError->message) . ').';
            }
        }

        if ($error === true) {

This code seems to be duplicated across your project.

            $message = 'XML file (' . $filename . ')  does not validate against the following XSD files: ' . implode(", ", $messageParts);
            throw new ValidationFailedException($message);
        }
    }
}