phmLabs / Smoke

src/Rules/Http/DurationRule.php

Spacing +2 added lines, -2 removed lines

@@ -27,13 +27,13 @@
         if ($response->getDuration() > $this->maxDuration) {
             return new CheckResult(
                 CheckResult::STATUS_FAILURE,
-                'The http request took ' . (int) $response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
+                'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
                 (int) $response->getDuration());
         }
 
         return new CheckResult(
             CheckResult::STATUS_SUCCESS,
-            'The http request took ' . (int) $response->getDuration() . ' milliseconds.',
+            'The http request took '.(int) $response->getDuration().' milliseconds.',
             (int) $response->getDuration());
     }
 }

src/Rules/Http/HttpsCertificateExpireRule.php

Spacing +4 added lines, -4 removed lines

@@ -25,13 +25,13 @@
         $validTo = date('d.m.Y H:i:s', $certInfo['validTo_time_t']);
 
         if ($certInfo['validFrom_time_t'] > time() || $certInfo['validTo_time_t'] < time()) {
-            $errorMessage = 'Certificate is expired. [' . $validFrom . ' - ' . $validTo . ']';
+            $errorMessage = 'Certificate is expired. ['.$validFrom.' - '.$validTo.']';
             return new CheckResult(CheckResult::STATUS_FAILURE, $errorMessage);
-        } elseif ($certInfo['validTo_time_t'] < strtotime('+' . $this->expireWarningTime . 'days')) {
-            $errorMessage = 'Certificate warning, expires in less than ' . $this->expireWarningTime . ' days. Certificate expires at: ' . $validTo;
+        } elseif ($certInfo['validTo_time_t'] < strtotime('+'.$this->expireWarningTime.'days')) {
+            $errorMessage = 'Certificate warning, expires in less than '.$this->expireWarningTime.' days. Certificate expires at: '.$validTo;
             return new CheckResult(CheckResult::STATUS_FAILURE, $errorMessage, 0);
         }
 
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'The certificate does not expire within the next ' . $this->expireWarningTime . ' days. Expire date: ' . $validTo . '.');
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'The certificate does not expire within the next '.$this->expireWarningTime.' days. Expire date: '.$validTo.'.');
     }
 }

src/Extensions/SmokeReporter/Reporter/WarmUpLiveReporter.php

Spacing +2 added lines, -2 removed lines

@@ -22,14 +22,14 @@
         if (count($results) > 0) {
             ++$this->urlCount;
             $firstResult = array_pop($results);
-            $this->output->writeln('   ' . (string) $firstResult->getResponse()->getUri());
+            $this->output->writeln('   '.(string) $firstResult->getResponse()->getUri());
             $this->output->writeln('');
         }
     }
 
     public function finish()
     {
-        $this->output->writeln('   <comment>Warm up finished. ' . $this->urlCount . ' urls visited.</comment>');
+        $this->output->writeln('   <comment>Warm up finished. '.$this->urlCount.' urls visited.</comment>');
         $this->output->writeln('');
     }
 }

src/Rules/Json/JsonSchema/JsonSchemaRule.php

Spacing +4 added lines, -4 removed lines

@@ -34,7 +34,7 @@ 
     {
         $data = json_decode($response->getBody());
         if ($data === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         } else {
             $errorStatus = false;
             $messageParts = array();
@@ -50,14 +50,14 @@ 
                     $errorStatus = true;
                     $errorMessage = '';
                     foreach ($validator->getErrors() as $error) {
-                        $errorMessage = $errorMessage . sprintf("[%s] %s\n", $error['property'], $error['message']);
+                        $errorMessage = $errorMessage.sprintf("[%s] %s\n", $error['property'], $error['message']);
                     }
-                    $messageParts[] = $jsonSchemaFile['jsonfilename'] . ' - ' . $jsonSchemaFile['jsonfileurl'] . '(last error: ' . $errorMessage . ').';
+                    $messageParts[] = $jsonSchemaFile['jsonfilename'].' - '.$jsonSchemaFile['jsonfileurl'].'(last error: '.$errorMessage.').';
                 }
             }
 
             if ($errorStatus === true) {
-                $message = 'JSON file (' . (string) $response->getUri() . ')  does not validate against the following JSON Schema files: ' . implode(', ', $messageParts);
+                $message = 'JSON file ('.(string) $response->getUri().')  does not validate against the following JSON Schema files: '.implode(', ', $messageParts);
                 throw new ValidationFailedException($message);
             }
         }

src/Rules/Html/CssSelectorExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -24,7 +24,7 @@ 
     public function doValidation(Response $response)
     {
         $domDocument = new \DOMDocument();
-        @$domDocument->loadHTML((string)$response->getBody());
+        @$domDocument->loadHTML((string) $response->getBody());
 
         $domXPath = new \DOMXPath($domDocument);
 
@@ -37,7 +37,7 @@ 
             try {
                 $selectorAsXPath = $converter->toXPath($selector['pattern']);
             } catch (\Exception $e) {
-                throw new ValidationFailedException('Invalid css selector (' . $selector['pattern'] . ').');
+                throw new ValidationFailedException('Invalid css selector ('.$selector['pattern'].').');
             }
 
             $count = $domXPath->query($selectorAsXPath)->length;
@@ -51,7 +51,7 @@ 
         if ($error === true) {
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
 
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
         }
     }
 }

src/Scanner/Scanner.php

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
             } catch (ValidationFailedException $e) {
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $e->getMessage());
             } catch (\Exception $e) {
-                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: ' . $e->getMessage());
+                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: '.$e->getMessage());
             }
 
             $result->setResponse($response);

src/Extensions/SmokeResponseRetriever/Retriever/ListRetriever/Retriever.php

Spacing +11 added lines, -11 removed lines

@@ -91,7 +91,7 @@ 
 
         if ($url['url'] instanceof UriInterface) {
             $urlObject = $url['url'];
-        }else {
+        } else {
             $urlObject = new Uri($url['url']);
         }
 
@@ -112,20 +112,20 @@ 
                         /* @var \Ivory\HttpAdapter\HttpAdapterException $exception */
 
                         $mainUri = $request->getUri();
-                        $this->redirects[(string)$mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl] = (string)$mainUri;
+                        $this->redirects[(string) $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl] = (string) $mainUri;
 
-                        $this->urls[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
-                        $this->urlStack[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
+                        $this->urls[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
+                        $this->urlStack[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
 
                         return $this->next();
                     }
 
                     // the error handling should be done withing the calling class
-                    echo "\n   " . $exception->getMessage() . "\n";
+                    echo "\n   ".$exception->getMessage()."\n";
 
                     return $this->next();
                 } else {
-                    $errorMessages .= $exception->getMessage() . "\n";
+                    $errorMessages .= $exception->getMessage()."\n";
                 }
             }
             if ($errorMessages !== '') {
@@ -138,8 +138,8 @@ 
 
     public function getOriginUri(UriInterface $uri)
     {
-        if (array_key_exists((string)$uri, $this->redirects)) {
-            return $this->urls[$this->redirects[(string)$uri]]['url'];
+        if (array_key_exists((string) $uri, $this->redirects)) {
+            return $this->urls[$this->redirects[(string) $uri]]['url'];
         }
 
         return $uri;
@@ -152,11 +152,11 @@ 
 
     public function getSystem(UriInterface $uri)
     {
-        if (array_key_exists((string)$uri, $this->redirects)) {
-            return $this->urls[$this->redirects[(string)$uri]]['system'];
+        if (array_key_exists((string) $uri, $this->redirects)) {
+            return $this->urls[$this->redirects[(string) $uri]]['system'];
         }
 
-        return $this->urls[(string)$uri]['system'];
+        return $this->urls[(string) $uri]['system'];
     }
 
     public function getSystems()

Braces +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 
         if ($url['url'] instanceof UriInterface) {
             $urlObject = $url['url'];
-        }else {
+        } else {
             $urlObject = new Uri($url['url']);
         }
 

src/Extensions/SmokeReporter/Reporter/LeankoalaReporter.php

Doc Comments +3 added lines, -3 removed lines

@@ -198,12 +198,12 @@
     }
 
     /**
-     * @param $identifier
+     * @param string $identifier
      * @param $system
-     * @param $message
+     * @param string $message
      * @param $status
      * @param $value
-     * @param $tool
+     * @param string $tool
      * @param $component
      * @param Attribute[] $attributes
      */

Spacing +11 added lines, -11 removed lines

@@ -118,7 +118,7 @@ 
         foreach ($this->results as $results) {
             foreach ($results as $result) {
                 /* @var CheckResult $result */
-                $tool = 'Smoke' . $result->getRuleName();
+                $tool = 'Smoke'.$result->getRuleName();
                 $checks[$tool][] = $result;
             }
         }
@@ -130,19 +130,19 @@ 
                 continue;
             }
 
-            $message = 'The smoke test for #system_name# failed (Rule: ' . $toolName . ').<ul>';
+            $message = 'The smoke test for #system_name# failed (Rule: '.$toolName.').<ul>';
             $status = Event::STATUS_SUCCESS;
             $failureCount = 0;
-            $identifier = $toolName . '_' . $this->system;
+            $identifier = $toolName.'_'.$this->system;
 
             foreach ($results as $result) {
                 /** @var CheckResult $result */
                 if ($result->getStatus() === CheckResult::STATUS_FAILURE) {
                     $comingFrom = '';
                     if ($this->addComingFrom && $this->retriever->getComingFrom($result->getResponse()->getUri())) {
-                        $comingFrom = ', coming from: ' . $this->retriever->getComingFrom($result->getResponse()->getUri());
+                        $comingFrom = ', coming from: '.$this->retriever->getComingFrom($result->getResponse()->getUri());
                     }
-                    $message .= '<li>' . $result->getMessage() . ' (url: ' . (string)$result->getResponse()->getUri() . $comingFrom . ')</li>';
+                    $message .= '<li>'.$result->getMessage().' (url: '.(string) $result->getResponse()->getUri().$comingFrom.')</li>';
                     ++$failureCount;
                 }
             }
@@ -150,9 +150,9 @@ 
                 $status = Event::STATUS_FAILURE;
                 $message .= '</ul>';
                 $firstResult = array_pop($results);
-                $attributes[] = new Attribute('html-content', (string)$firstResult->getResponse()->getBody(), true);
+                $attributes[] = new Attribute('html-content', (string) $firstResult->getResponse()->getBody(), true);
             } else {
-                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:' . $toolName . '].';
+                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:'.$toolName.'].';
             }
 
 
@@ -166,7 +166,7 @@ 
             foreach ($results as $result) {
                 /* @var CheckResult $result */
 
-                $identifier = '_' . $this->getIdentifier($result);
+                $identifier = '_'.$this->getIdentifier($result);
                 $tool = $this->getPrefix($result->getRuleName());
 
                 $component = $this->getComponent($result->getRuleName());
@@ -174,14 +174,14 @@ 
 
                 $attributes = array();
                 if ($result->getStatus() == CheckResult::STATUS_FAILURE) {
-                    $attributes[] = new Attribute('html content', (string)$result->getResponse()->getBody(), true);
+                    $attributes[] = new Attribute('html content', (string) $result->getResponse()->getBody(), true);
                     $attributes[] = new Attribute('http status code', $result->getResponse()->getStatusCode());
                 }
 
                 $this->send(
                     $identifier,
                     $system,
-                    $result->getMessage() . ' (url: ' . (string)$result->getResponse()->getUri() . ')',
+                    $result->getMessage().' (url: '.(string) $result->getResponse()->getUri().')',
                     $result->getStatus(),
                     $result->getValue(),
                     $tool,
@@ -194,7 +194,7 @@ 
 
     private function getIdentifier(CheckResult $result)
     {
-        return $this->tool . '_' . $result->getRuleName();
+        return $this->tool.'_'.$result->getRuleName();
     }
 
     private function getPrefix($string)

src/Rules/Html/InvalidUrlsRule.php

Spacing +3 added lines, -3 removed lines

@@ -27,13 +27,13 @@
 
         foreach ($urls as $url) {
 
-            $idnUrl = $url->getScheme() . '://' . idn_to_ascii($url->getHost()) .  $url->getPath();
+            $idnUrl = $url->getScheme().'://'.idn_to_ascii($url->getHost()).$url->getPath();
 
             if (!filter_var($idnUrl, FILTER_VALIDATE_URL)) {
-                $invalidUrls[] = (string)$url;
+                $invalidUrls[] = (string) $url;
             }
         }
 
-        $this->assert(count($invalidUrls) === 0, 'Invalid urls found (' . implode(', ', $invalidUrls) . ').');
+        $this->assert(count($invalidUrls) === 0, 'Invalid urls found ('.implode(', ', $invalidUrls).').');
     }
 }