phmLabs / Smoke

src/Extensions/SmokeReporter/Reporter/HtmlReporter.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Symfony\Component\Console\Output\OutputInterface;
 use whm\Smoke\Config\Configuration;
-use whm\Smoke\Extensions\SmokeResponseRetriever\Retriever\Retriever;
 use whm\Smoke\Rules\CheckResult;
 
 

Spacing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
         $this->resultFile = $resultFile;
 
         if ($templateDir === null) {
-            $this->templateDir = __DIR__ . '/templates';
+            $this->templateDir = __DIR__.'/templates';
         } else {
             $this->templateDir = $templateDir;
         }
@@ -66,9 +66,9 @@ 
         }
 
         if (!file_put_contents($this->resultFile, $html)) {
-            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to " . $this->resultFile ."</error>");
+            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to ".$this->resultFile."</error>");
         } else {
-            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to " . $this->resultFile);
+            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to ".$this->resultFile);
         }
     }
 

src/Extensions/SmokeReporter/Reporter/KoalamonSummaryReporter.php

Spacing +6 added lines, -6 removed lines

@@ -52,7 +52,7 @@ 
     const STATUS_SUCCESS = 'success';
     const STATUS_FAILURE = 'failure';
 
-    public function init($apiKey, Configuration $_configuration, OutputInterface $_output, $server = 'https://webhook.koalamon.com', $system = '', $identifier = '', $tool = '', $url ='')
+    public function init($apiKey, Configuration $_configuration, OutputInterface $_output, $server = 'https://webhook.koalamon.com', $system = '', $identifier = '', $tool = '', $url = '')
     {
         $httpClient = new \GuzzleHttp\Client();
 
@@ -82,7 +82,7 @@ 
     public function processResults($results)
     {
         foreach ($results as $result) {
-            if($result->getStatus() == CheckResult::STATUS_SUCCESS) {
+            if ($result->getStatus() == CheckResult::STATUS_SUCCESS) {
                 $this->success++;
             } else {
                 $this->failed++;
@@ -93,8 +93,8 @@ 
     public function finish()
     {
         $message = 'Checks: ';
-        $message .= $this->success . ' succeeded, ';
-        $message .= $this->failed . ' failed. ';
+        $message .= $this->success.' succeeded, ';
+        $message .= $this->failed.' failed. ';
 
         if ($this->failed > 0) {
             $status = Event::STATUS_FAILURE;
@@ -129,8 +129,8 @@ 
                 $this->reporter->sendEvent($event);
             } catch (KoalamonException $e) {
                 $this->output->writeln("\n  <error> Error sending result to leankoala. </error>");
-                $this->output->writeln('   Url: ' . $e->getUrl());
-                $this->output->writeln('   Payload: ' . $e->getPayload());
+                $this->output->writeln('   Url: '.$e->getUrl());
+                $this->output->writeln('   Payload: '.$e->getPayload());
                 $this->output->writeln("");
             } catch (\Exception $e) {
                 $this->output->writeln($e->getMessage());

src/Rules/CheckResult.php

Doc Comments +2 added lines, -1 removed lines

@@ -29,6 +29,7 @@ 
      * @param $status
      * @param $value
      * @param $message
+     * @param string $url
      */
     public function __construct($status, $message = '', $value = null, $url = null)
     {
@@ -47,7 +48,7 @@ 
     }
 
     /**
-     * @param array $attributes
+     * @param array $attribute
      */
     public function addAttribute(Attribute $attribute)
     {

src/Scanner/Scanner.php

Spacing +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
             } catch (ValidationFailedException $e) {
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $e->getMessage());
             } catch (\Exception $e) {
-                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: ' . $e->getMessage());
+                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: '.$e->getMessage());
             }
 
             $this->eventDispatcher->simpleNotify('Scanner.CheckResponse.Rule', array('checkResult' => $result, 'ruleName' => $name));

src/Http/GuzzleClient.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use phm\HttpWebdriverClient\Http\Client\Guzzle\GuzzleClient as phmGuzzleClient;
 use phm\HttpWebdriverClient\Http\Client\Decorator\FileCacheDecorator;
-use phm\HttpWebdriverClient\Http\Client\Decorator\LoggerDecorator;
 use phm\HttpWebdriverClient\Http\Client\HttpClient;
 use Psr\Http\Message\RequestInterface;
 

src/Config/Configuration.php

Spacing +4 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
     private function initConfigArray(array $configArray, array $defaultSettings = null)
     {
         if ($defaultSettings === null) {
-            $defaultSettings = Yaml::parse(file_get_contents(__DIR__ . '/../settings/' . self::DEFAULT_SETTINGS));
+            $defaultSettings = Yaml::parse(file_get_contents(__DIR__.'/../settings/'.self::DEFAULT_SETTINGS));
         }
 
         if (count($configArray) === 0) {
@@ -169,7 +169,7 @@ 
         if ($this->hasSection($section)) {
             return $this->configArray[$section];
         } else {
-            throw new \RuntimeException('The section (' . $section . ') you are trying to access does not exist.');
+            throw new \RuntimeException('The section ('.$section.') you are trying to access does not exist.');
         }
     }
 
@@ -178,7 +178,7 @@ 
         if (array_key_exists($name, $this->extensions)) {
             return $this->extensions[$name];
         } else {
-            throw new \RuntimeException('The extension ("' . $name . '") you are trying to access does not exist. Registered extensions are: ' . implode(' ,', array_keys($this->extensions)) . '.');
+            throw new \RuntimeException('The extension ("'.$name.'") you are trying to access does not exist. Registered extensions are: '.implode(' ,', array_keys($this->extensions)).'.');
         }
     }
 
@@ -203,7 +203,7 @@ 
             try {
                 $client = Init::initialize($this->configArray['client']);
             } catch (\Exception $e) {
-                throw new ConfigurationException('Error initializing client (' . $e->getMessage() . ')');
+                throw new ConfigurationException('Error initializing client ('.$e->getMessage().')');
             }
 
             return $client;