whm\Smoke\Rules\Xml\XmlValidXsdRule::doValidation()

Complexity

Conditions	4
Paths	6

Size

Total Lines	28
Code Lines	16

Duplication

Lines	4
Ratio	14.29 %

Importance

Changes

0

<?php
    protected function doValidation(Response $response)
    {
        $body = $response->getBody();

        $dom = new \DOMDocument();
        @$dom->loadXML($body);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $filename = (string)$response->getUri();

        $error = false;
        $messageParts = array();

        foreach ($this->xsdFiles AS $xsdFile) {
            $valid = @$dom->schemaValidate($xsdFile['xsdfileurl']);

            if (!$valid) {
                $error = true;
                $lastError = libxml_get_last_error();

                $messageParts[] = $xsdFile['xsdfilename'] . ' - ' . $xsdFile['xsdfileurl'] . '(last error: ' . str_replace("\n", '', $lastError->message) . ').';
            }
        }

        if ($error === true) {

This code seems to be duplicated across your project.

            $message = 'XML file (' . $filename . ')  does not validate against the following XSD files: ' . implode(", ", $messageParts);
            throw new ValidationFailedException($message);
        }
    }
}