phmLabs / Smoke

src/Rules/Json/JsonSchema/JsonSchemaRule.php

Spacing +4 added lines, -4 removed lines

@@ -36,7 +36,7 @@ 
     {
         $data = json_decode($response->getBody());
         if ($data === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         } else {
             $error = false;
             $messageParts = array();
@@ -53,14 +53,14 @@ 
                     $error = true;
                     $errorMessage = '';
                     foreach ($validator->getErrors() as $error) {
-                        $errorMessage = $errorMessage . sprintf("[%s] %s\n", $error['property'], $error['message']);
+                        $errorMessage = $errorMessage.sprintf("[%s] %s\n", $error['property'], $error['message']);
                     }
-                    $messageParts[] = $jsonSchemaFile['jsonschemafilename'] . ' - ' . $jsonSchemaFile['jsonschemafileurl'] . '(last error: ' . $errorMessage . ').';
+                    $messageParts[] = $jsonSchemaFile['jsonschemafilename'].' - '.$jsonSchemaFile['jsonschemafileurl'].'(last error: '.$errorMessage.').';
                 }
             }
 
             if ($error === true) {
-                $message = 'JSON file (' . (string) $response->getUri() . ')  does not validate against the following JSON Schema files: ' . implode(', ', $messageParts);
+                $message = 'JSON file ('.(string) $response->getUri().')  does not validate against the following JSON Schema files: '.implode(', ', $messageParts);
                 throw new ValidationFailedException($message);
             }
         }

src/Rules/Html/ClosingHtmlTagRule.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
     {
         if (($response->getStatus() < 300 || $response->getStatus() >= 400) && $response->getContentType() === 'text/html') {
             if (stripos($response->getBody(), '</html>') === false) {
-                throw new ValidationFailedException('Closing html tag is missing (document lengh: ' . strlen($response->getBody()) . ').');
+                throw new ValidationFailedException('Closing html tag is missing (document lengh: '.strlen($response->getBody()).').');
             }
         }
     }

src/Rules/Seo/GoogleMobileFriendlyRule.php

Spacing +2 added lines, -2 removed lines

@@ -35,13 +35,13 @@
         var_dump($result);
 
         if ($result->error) {
-            throw new ValidationFailedException('Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
+            throw new ValidationFailedException('Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
         }
 
         $passResult = $result->ruleGroups->USABILITY;
 
         if (!$passResult->pass) {
-            throw new ValidationFailedException('Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.');
+            throw new ValidationFailedException('Google mobile friendly test was not passed. Score '.$passResult->score.'/100.');
         }
     }
 }

src/Extensions/CookieMaker/CookieMakerExtension.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
         $this->sessionContainer = new SessionContainer();
 
         foreach ($sessions as $sessionName => $session) {
-            $command = $this->executable . " '" . json_encode($session) . "'";
+            $command = $this->executable." '".json_encode($session)."'";
 
             exec($command, $output, $return);
 

src/Rules/Seo/RobotsDisallowAllRule.php

Doc Comments +3 added lines

@@ -49,6 +49,9 @@
         }
     }
 
+    /**
+     * @param string $content
+     */
     private function normalizeContent($content)
     {
         $normalizedContent = strtolower($content);

Spacing +4 added lines, -4 removed lines

@@ -20,12 +20,12 @@ 
 
     public function validate(Response $response)
     {
-        $url = $response->getUri()->getScheme() . '://' . $response->getUri()->getHost();
+        $url = $response->getUri()->getScheme().'://'.$response->getUri()->getHost();
 
         if (substr_count($url, '/') === 2) {
-            $filename = $robotsUrl = $url . '/robots.txt';
+            $filename = $robotsUrl = $url.'/robots.txt';
         } elseif (substr_count($url, '/') === 3) {
-            $filename = $robotsUrl = $url . 'robots.txt';
+            $filename = $robotsUrl = $url.'robots.txt';
         } else {
             return;
         }
@@ -40,7 +40,7 @@ 
 
         $normalizedContent = $this->normalizeContent($content);
 
-        if (strpos($normalizedContent, 'user-agent:* disallow:/' . PHP_EOL) !== false) {
+        if (strpos($normalizedContent, 'user-agent:* disallow:/'.PHP_EOL) !== false) {
             throw new ValidationFailedException('The robots.txt contains disallow all (Disallow: /)');
         }
 

src/Extensions/SmokeReporter/Reporter/LeankoalaReporter.php

Doc Comments +5 added lines

@@ -182,6 +182,11 @@
         return substr($string, 0, strpos($string, '_'));
     }
 
+    /**
+     * @param string $identifier
+     * @param string $message
+     * @param string $tool
+     */
     private function send($identifier, $system, $message, $status, $value, $tool, $component)
     {
         $event = new Event($identifier, $system, $status, $tool, $message, $value, '', $component);

Spacing +9 added lines, -9 removed lines

@@ -110,7 +110,7 @@ 
         foreach ($this->results as $results) {
             foreach ($results as $result) {
                 /* @var CheckResult $result */
-                $tool = 'Smoke' . $result->getRuleName();
+                $tool = 'Smoke'.$result->getRuleName();
                 $checks[$tool][] = $result;
             }
         }
@@ -120,19 +120,19 @@ 
                 continue;
             }
 
-            $message = 'The smoke test for #system_name# failed (Rule: ' . $toolName . ').<ul>';
+            $message = 'The smoke test for #system_name# failed (Rule: '.$toolName.').<ul>';
             $status = Event::STATUS_SUCCESS;
             $failureCount = 0;
-            $identifier = $toolName . '_' . $this->system;
+            $identifier = $toolName.'_'.$this->system;
 
             foreach ($results as $result) {
                 /** @var CheckResult $result */
                 if ($result->getStatus() === CheckResult::STATUS_FAILURE) {
                     $comingFrom = '';
                     if ($this->addComingFrom && $this->retriever->getComingFrom($result->getResponse()->getUri())) {
-                        $comingFrom = ', coming from: ' . $this->retriever->getComingFrom($result->getResponse()->getUri());
+                        $comingFrom = ', coming from: '.$this->retriever->getComingFrom($result->getResponse()->getUri());
                     }
-                    $message .= '<li>' . $result->getMessage() . ' (url: ' . (string) $result->getResponse()->getUri() . $comingFrom . ')</li>';
+                    $message .= '<li>'.$result->getMessage().' (url: '.(string) $result->getResponse()->getUri().$comingFrom.')</li>';
                     ++$failureCount;
                 }
             }
@@ -140,7 +140,7 @@ 
                 $status = Event::STATUS_FAILURE;
                 $message .= '</ul>';
             } else {
-                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:' . $toolName . '].';
+                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:'.$toolName.'].';
             }
 
             $this->send($identifier, $this->system, $message, $status, $failureCount, $this->tool, $this->system);
@@ -153,7 +153,7 @@ 
             foreach ($results as $result) {
                 /* @var CheckResult $result */
 
-                $identifier = '_' . $this->getIdentifier($result);
+                $identifier = '_'.$this->getIdentifier($result);
                 $tool = $this->getPrefix($result->getRuleName());
 
                 $component = $this->getComponent($result->getRuleName());
@@ -162,7 +162,7 @@ 
                 $this->send(
                     $identifier,
                     $system,
-                    $result->getMessage() . ' (url: ' . (string) $result->getResponse()->getUri() . ')',
+                    $result->getMessage().' (url: '.(string) $result->getResponse()->getUri().')',
                     $result->getStatus(),
                     $result->getValue(),
                     $tool,
@@ -174,7 +174,7 @@ 
 
     private function getIdentifier(CheckResult $result)
     {
-        return $this->tool . '_' . $result->getRuleName();
+        return $this->tool.'_'.$result->getRuleName();
     }
 
     private function getPrefix($string)

src/Extensions/SmokeReporter/Reporter/StandardCliReporter.php

Doc Comments +3 added lines

@@ -72,6 +72,9 @@
         $this->output->writeln('');
     }
 
+    /**
+     * @param integer $ruleKey
+     */
     private function getFailedUrls($ruleKey)
     {
         $failedUrls = array();

Spacing +6 added lines, -6 removed lines

@@ -81,11 +81,11 @@ 
                 /** @var CheckResult $result */
                 if ($result->getStatus() === CheckResult::STATUS_FAILURE) {
                     if ($ruleKey === $key) {
-                        $failedUrls[] = (string) $result->getResponse()->getUri() . ' - ' . $result->getMessage();
+                        $failedUrls[] = (string) $result->getResponse()->getUri().' - '.$result->getMessage();
                         ++$count;
                     }
                     if ($count > $this->maxResults) {
-                        $failedUrls[] = '... only the first ' . $this->maxResults . ' elements are shown.';
+                        $failedUrls[] = '... only the first '.$this->maxResults.' elements are shown.';
                         break;
                     }
                 }
@@ -104,15 +104,15 @@ 
             $failedUrls = $this->getFailedUrls($ruleKey);
 
             if (count($failedUrls) > 0) {
-                $this->output->writeln('  <error> ' . get_class($rule) . ' </error>');
+                $this->output->writeln('  <error> '.get_class($rule).' </error>');
             } else {
-                $this->output->writeln('  <info> ' . get_class($rule) . ' </info>');
+                $this->output->writeln('  <info> '.get_class($rule).' </info>');
             }
 
-            $this->output->writeln('   ' . str_replace("\n", "\n   ", $info['documentation']) . "\n");
+            $this->output->writeln('   '.str_replace("\n", "\n   ", $info['documentation'])."\n");
 
             foreach ($failedUrls as $failedUrl) {
-                $this->output->writeln('   - ' . $failedUrl);
+                $this->output->writeln('   - '.$failedUrl);
             }
 
             $this->output->writeln('');

src/Extensions/SmokeReporter/Reporter/CliReporter.php

Spacing +3 added lines, -3 removed lines

@@ -30,13 +30,13 @@
 
     protected function renderFailure(CheckResult $result)
     {
-        $this->output->writeln('   <error> ' . (string) $result->getResponse()->getUri() . ' </error> coming from ' . (string) $this->retriever->getComingFrom($result->getResponse()->getUri()));
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <error> '.(string) $result->getResponse()->getUri().' </error> coming from '.(string) $this->retriever->getComingFrom($result->getResponse()->getUri()));
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
         $this->output->writeln('');
     }
 
     protected function renderSuccess(CheckResult $result)
     {
-        $this->output->writeln('   <info> ' . (string) $result->getResponse()->getUri() . ' </info> all tests passed');
+        $this->output->writeln('   <info> '.(string) $result->getResponse()->getUri().' </info> all tests passed');
     }
 }

src/Extensions/SmokeReporter/Reporter/WarmUpLiveReporter.php

Spacing +2 added lines, -2 removed lines

@@ -17,13 +17,13 @@
     public function processResults($results)
     {
         ++$this->urlCount;
-        $this->output->writeln('   ' . array_pop($result)->getUrl());
+        $this->output->writeln('   '.array_pop($result)->getUrl());
         $this->output->writeln('');
     }
 
     public function finish()
     {
-        $this->output->writeln('   <comment>Warm up finished. ' . $this->urlCount . ' urls visited.</comment>');
+        $this->output->writeln('   <comment>Warm up finished. '.$this->urlCount.' urls visited.</comment>');
         $this->output->writeln('');
     }
 }