phmLabs / Smoke

src/Rules/Html/RegExNotExistsRule.php

Doc Comments -1 removed lines

@@ -15,7 +15,6 @@
     protected $contentTypes = array('text/html');
 
     /**
-     * @param int $string The string that the document must contain
      */
     public function init(array $regExs)
     {

Spacing +2 added lines, -2 removed lines

@@ -25,8 +25,8 @@
     protected function doValidation(Response $response)
     {
         foreach ($this->regExs as $regEx) {
-            $this->assert(preg_match('^' . $regEx . '^', (string) $response->getBody()) === 0,
-                'The given regular expression (' . $regEx . ') was found in this document.');
+            $this->assert(preg_match('^'.$regEx.'^', (string) $response->getBody()) === 0,
+                'The given regular expression ('.$regEx.') was found in this document.');
         }
     }
 }

src/Rules/Http/HttpsCertificateExpireRule.php

Spacing +3 added lines, -3 removed lines

@@ -26,10 +26,10 @@
         $validTo = date('d.m.Y H:i:s', $certInfo['validTo_time_t']);
 
         if ($certInfo['validFrom_time_t'] > time() || $certInfo['validTo_time_t'] < time()) {
-            $errorMessage = 'Certificate is expired. [' . $validFrom . ' - ' . $validTo . ']';
+            $errorMessage = 'Certificate is expired. ['.$validFrom.' - '.$validTo.']';
             throw new ValidationFailedException($errorMessage);
-        } elseif ($certInfo['validTo_time_t'] < strtotime('+' . $this->expireWarningTime . 'days')) {
-            $errorMessage = 'Certificate warning, expires in less than ' . $this->expireWarningTime . ' days. Certificate expires at: ' . $validTo;
+        } elseif ($certInfo['validTo_time_t'] < strtotime('+'.$this->expireWarningTime.'days')) {
+            $errorMessage = 'Certificate warning, expires in less than '.$this->expireWarningTime.' days. Certificate expires at: '.$validTo;
             throw new ValidationFailedException($errorMessage);
         }
 

src/Rules/Http/HttpsRule.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
         $sslOptions = stream_context_create(array('ssl' => array('capture_peer_cert' => true)));
 
         $request = stream_socket_client(
-            'ssl://' . $host . ':443',
+            'ssl://'.$host.':443',
             $errno,
             $errstr,
             30,

src/Rules/Http/HttpsCertificateAuthorityRule.php

Spacing +2 added lines, -2 removed lines

@@ -23,10 +23,10 @@
     {
         if (array_key_exists('issuer', $certInfo) and array_key_exists('CN', $certInfo['issuer'])) {
             if ($certInfo['issuer']['CN'] != $this->authorityName) {
-                throw new ValidationFailedException('Expected authority was "' . $this->authorityName . '", "' . $certInfo['issuer']['CN'] . '" found.');
+                throw new ValidationFailedException('Expected authority was "'.$this->authorityName.'", "'.$certInfo['issuer']['CN'].'" found.');
             }
         } else {
-            throw new ValidationFailedException('Expected authority was "' . $this->authorityName . '". No authority found.');
+            throw new ValidationFailedException('Expected authority was "'.$this->authorityName.'". No authority found.');
         }
     }
 }

src/Rules/Http/Header/ExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -24,13 +24,13 @@
 
         foreach ($this->checkedHeaders as $headerConfig) {
             if (!$response->hasHeader($headerConfig['key'])) {
-                throw new ValidationFailedException('Header not found (' . $headerConfig['key'] . ')');
+                throw new ValidationFailedException('Header not found ('.$headerConfig['key'].')');
             }
 
             $currentValue = $response->getHeader($headerConfig['key'])[0];
 
-            if (!preg_match('^' . $headerConfig['value'] . '^', $currentValue, $matches)) {
-                throw new ValidationFailedException('Header "' . $headerConfig['key'] . '" does not match "' . $headerConfig['value'] . '". Current value is "' . $currentValue . '"');
+            if (!preg_match('^'.$headerConfig['value'].'^', $currentValue, $matches)) {
+                throw new ValidationFailedException('Header "'.$headerConfig['key'].'" does not match "'.$headerConfig['value'].'". Current value is "'.$currentValue.'"');
             }
         }
     }

src/Rules/Xml/Sitemap/ValidRule.php

Doc Comments +7 added lines

@@ -16,11 +16,18 @@
 
     protected $contentTypes = array('text/xml', 'application/xml');
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         return ($isIndex) ?  __DIR__ . '/' . self::INDEX : __DIR__ . '/' . self::SCHEMA;
     }
 
+    /**
+     * @param \Psr\Http\Message\StreamInterface $body
+     * @param string $filename
+     */
     private function validateBody($body, $filename, $isIndex = TRUE)
     {
         $dom = new \DOMDocument();

Spacing +4 added lines, -4 removed lines

@@ -29,13 +29,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -49,7 +49,7 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 

src/Rules/Xml/XmlCheckRule.php

Spacing +2 added lines, -2 removed lines

@@ -21,8 +21,8 @@
         if (!$success) {
             $lastError = libxml_get_last_error();
 
-            throw new ValidationFailedException('The xml file ' . $response->getUri() . ' is not well formed (last error: ' .
-                str_replace("\n", '', $lastError->message) . ').');
+            throw new ValidationFailedException('The xml file '.$response->getUri().' is not well formed (last error: '.
+                str_replace("\n", '', $lastError->message).').');
         }
     }
 }

src/Rules/Json/JsonPathExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -65,17 +65,17 @@
 
             if ($jsonValue === FALSE || (is_array($jsonValue) && empty($jsonValue))) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (JSON Path not found)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (JSON Path not found)';
             }
             if ($this->checkRelation($path['relation'], $path['value'], $count) === false) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (number of JSONPaths is not correct corresponding to the given relation/value)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (number of JSONPaths is not correct corresponding to the given relation/value)';
             }
         }
 
         if ($error === true) {
             $allNoCorrectJsonPaths = implode('", "', $noCorrectJsonPaths);
-            throw new ValidationFailedException('Disonances with JSON Paths "' . $allNoCorrectJsonPaths . '!');
+            throw new ValidationFailedException('Disonances with JSON Paths "'.$allNoCorrectJsonPaths.'!');
         }
     }
 }

src/Rules/Html/CssSelectorExistsRule.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         if ($error === true) {
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
 
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
         }
     }
 }