phmLabs / Smoke

src/Extensions/SmokeFilter/FilterExtension.php

Spacing +5 added lines, -5 removed lines

@@ -42,12 +42,12 @@ 
     public function init($filters = array(), $filterFile = '', $exclusive = array())
     {
         if (count($exclusive) > 0 && (count($filters) > 0 || $filterFile !== '')) {
-            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: " . get_class($this) . '].');
+            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: ".get_class($this).'].');
         }
 
         if ($filterFile !== '') {
             if (!file_exists($filterFile)) {
-                throw new \RuntimeException('Filter file not found: ' . $filterFile);
+                throw new \RuntimeException('Filter file not found: '.$filterFile);
             }
 
             $filterElements = EnvAwareYaml::parse(file_get_contents($filterFile));
@@ -72,7 +72,7 @@ 
                 if (is_array($urls)) {
                     foreach ($urls as $url) {
                         $uri = new Uri($url);
-                        $this->exclusives[$rule][] = (string)$uri;
+                        $this->exclusives[$rule][] = (string) $uri;
                     }
                 }
             }
@@ -93,7 +93,7 @@ 
      */
     public function isFiltered(Event $event, $ruleName, UriAwareResponse $response)
     {
-        $uri = (string)$this->retriever->getOriginUri($response->getUri());
+        $uri = (string) $this->retriever->getOriginUri($response->getUri());
 
         if ($this->currentModus === self::MODUS_FILTER) {
             $isFiltered = $this->isFilteredByFilter($ruleName, $uri);
@@ -112,7 +112,7 @@ 
     private function isFilteredByFilter($ruleName, $uri)
     {
         foreach ($this->filters as $filter) {
-            if ($ruleName === $filter['rule'] && 0 < preg_match('$' . $filter['uri'] . '$', $uri)) {
+            if ($ruleName === $filter['rule'] && 0 < preg_match('$'.$filter['uri'].'$', $uri)) {
                 return true;
             }
         }

src/Rules/Html/RegExExistsRule.php

Spacing +5 added lines, -5 removed lines

@@ -42,12 +42,12 @@ 
             if ($regEx['isRegEx']) {
                 $pattern = str_replace('', '\\~', $regEx['pattern']);
 
-                if (preg_match('~' . $pattern . '~', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Regular expression: ' . $regEx['pattern'];
+                if (preg_match('~'.$pattern.'~', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Regular expression: '.$regEx['pattern'];
                 }
             } else {
-                if (preg_match('^' . preg_quote($regEx['pattern']) . '^', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Text: ' . $regEx['pattern'];
+                if (preg_match('^'.preg_quote($regEx['pattern']).'^', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Text: '.$regEx['pattern'];
                 }
             }
         }
@@ -56,7 +56,7 @@ 
             $errorString = 'The following text elements were not found: <ul>';
 
             foreach ($errors as $error) {
-                $errorString .= '<li>' . $error . '</li>';
+                $errorString .= '<li>'.$error.'</li>';
             }
 
             $errorString .= '</ul>';

src/Extensions/SmokeMemory/MemoryExtension.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
         foreach ($results as $result) {
             /** @var UriAwareResponse $response */
             if ($result->getStatus() == CheckResult::STATUS_FAILURE) {
-                $this->memory[] = (string)$response->getUri();
+                $this->memory[] = (string) $response->getUri();
             }
         }
     }

src/Extensions/SmokeReporter/Reporter/LeankoalaReporter.php

Spacing +14 added lines, -14 removed lines

@@ -126,7 +126,7 @@ 
         foreach ($this->results as $results) {
             foreach ($results as $result) {
                 /* @var CheckResult $result */
-                $tool = 'Smoke' . $result->getRuleName();
+                $tool = 'Smoke'.$result->getRuleName();
                 $checks[$tool][] = $result;
             }
         }
@@ -138,19 +138,19 @@ 
                 continue;
             }
 
-            $message = 'The smoke test for #system_name# failed (Rule: ' . $toolName . ').<ul>';
+            $message = 'The smoke test for #system_name# failed (Rule: '.$toolName.').<ul>';
             $status = Event::STATUS_SUCCESS;
             $failureCount = 0;
-            $identifier = $toolName . '_' . $this->system;
+            $identifier = $toolName.'_'.$this->system;
 
             foreach ($results as $result) {
                 /** @var CheckResult $result */
                 if ($result->getStatus() === CheckResult::STATUS_FAILURE) {
                     $comingFrom = '';
                     if ($this->addComingFrom && $this->retriever->getComingFrom($result->getResponse()->getUri())) {
-                        $comingFrom = ', coming from: ' . $this->retriever->getComingFrom($result->getResponse()->getUri());
+                        $comingFrom = ', coming from: '.$this->retriever->getComingFrom($result->getResponse()->getUri());
                     }
-                    $message .= '<li>' . $result->getMessage() . ' (url: ' . (string)$result->getResponse()->getUri() . $comingFrom . ')</li>';
+                    $message .= '<li>'.$result->getMessage().' (url: '.(string) $result->getResponse()->getUri().$comingFrom.')</li>';
                     ++$failureCount;
                 }
             }
@@ -158,9 +158,9 @@ 
                 $status = Event::STATUS_FAILURE;
                 $message .= '</ul>';
                 $firstResult = array_pop($results);
-                $attributes[] = new Attribute('html-content', (string)$firstResult->getResponse()->getBody(), true);
+                $attributes[] = new Attribute('html-content', (string) $firstResult->getResponse()->getBody(), true);
             } else {
-                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:' . $toolName . '].';
+                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:'.$toolName.'].';
             }
 
             $this->send($identifier, $this->system, $message, $status, $failureCount, $this->tool, $this->system, $attributes);
@@ -173,7 +173,7 @@ 
             foreach ($results as $result) {
                 /* @var CheckResult $result */
 
-                $identifier = '_' . $this->getIdentifier($result);
+                $identifier = '_'.$this->getIdentifier($result);
                 $tool = $this->getPrefix($result->getRuleName());
 
                 $component = $this->getComponent($result->getRuleName());
@@ -181,7 +181,7 @@ 
 
                 $attributes = array();
                 if ($result->getStatus() == CheckResult::STATUS_FAILURE) {
-                    $body = (string)$result->getResponse()->getBody();
+                    $body = (string) $result->getResponse()->getBody();
                     if ($body == "") {
                         $attributes[] = new Attribute('html content', '<empty>');
                     } else {
@@ -205,7 +205,7 @@ 
                 $this->send(
                     $identifier,
                     $currentSystem,
-                    $result->getMessage() . ' (url: ' . (string)$result->getResponse()->getUri() . ')',
+                    $result->getMessage().' (url: '.(string) $result->getResponse()->getUri().')',
                     $result->getStatus(),
                     $result->getValue(),
                     $tool,
@@ -219,12 +219,12 @@ 
     private function getIdentifier(CheckResult $result)
     {
         if ($this->useUrlAsIdentifier) {
-            $suffix = '_' . md5((string)$result->getResponse()->getUri());
+            $suffix = '_'.md5((string) $result->getResponse()->getUri());
         } else {
             $suffix = '';
         }
 
-        return $this->tool . '_' . $result->getRuleName() . $suffix;
+        return $this->tool.'_'.$result->getRuleName().$suffix;
     }
 
     private function getPrefix($string)
@@ -255,8 +255,8 @@ 
                 $this->reporter->sendEvent($event);
             } catch (KoalamonException $e) {
                 $this->output->writeln("\n  <error> Error sending result to leankoala. </error>");
-                $this->output->writeln('   Url: ' . $e->getUrl());
-                $this->output->writeln('   Payload: ' . $e->getPayload());
+                $this->output->writeln('   Url: '.$e->getUrl());
+                $this->output->writeln('   Payload: '.$e->getPayload());
                 $this->output->writeln("");
             } catch (\Exception $e) {
                 $this->output->writeln($e->getMessage());

src/Rules/Http/RedirectRule.php

Spacing +6 added lines, -6 removed lines

@@ -31,23 +31,23 @@
             $uri = new Uri($url['url']);
 
             $urlResponses = $client->sendRequests([new Request('GET', $uri)]);
-            $effectiveUrl = (string)$urlResponses[0]->getEffectiveUri();
+            $effectiveUrl = (string) $urlResponses[0]->getEffectiveUri();
 
-            if ($effectiveUrl != (string)$response->getUri()) {
-                $errors[] = 'The url "' . $url['url'] . '" gets redirected to "' . $effectiveUrl . '".';
+            if ($effectiveUrl != (string) $response->getUri()) {
+                $errors[] = 'The url "'.$url['url'].'" gets redirected to "'.$effectiveUrl.'".';
             }
         }
 
         if (count($errors) > 0) {
-            $message = 'Not all given urls do redirect to "' . (string)$response->getUri() . '"".<ul>';
+            $message = 'Not all given urls do redirect to "'.(string) $response->getUri().'"".<ul>';
             foreach ($errors as $error) {
-                $message .= '<li>' . $error . '</li>';
+                $message .= '<li>'.$error.'</li>';
             }
             $message .= "</ul>";
 
             return new CheckResult(CheckResult::STATUS_FAILURE, $message);
         } else {
-            return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to ' . (string)$response->getUri());
+            return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to '.(string) $response->getUri());
         }
     }
 }

src/Rules/Html/InsecureContentRule.php

Spacing +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
             return true;
         }
 
-        $htmlDocument = new Document((string)$response->getBody());
+        $htmlDocument = new Document((string) $response->getBody());
 
         $resources = $htmlDocument->getDependencies($uri, false);
 
@@ -54,7 +54,7 @@ 
             if ($resource->getScheme() && 'https' !== $resource->getScheme()) {
                 $excluded = false;
                 foreach ($this->excludedFiles as $excludedFile) {
-                    if (preg_match('~' . $excludedFile . '~', (string)$resource)) {
+                    if (preg_match('~'.$excludedFile.'~', (string) $resource)) {
                         $excluded = true;
                         break;
                     }
@@ -68,7 +68,7 @@ 
         if (count($unsecures) > 0) {
             $message = 'At least one dependency was found on a secure url, that was transfered insecure.<ul>';
             foreach ($unsecures as $unsecure) {
-                $message .= '<li>' . (string)$unsecure . '</li>';
+                $message .= '<li>'.(string) $unsecure.'</li>';
             }
             $message .= '</ul>';
             return new CheckResult(CheckResult::STATUS_FAILURE, $message, count($unsecures));

src/Rules/Html/ClosingHtmlTagRule.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
         if ($response instanceof ContentTypeAwareResponse) {
 
             // @todo this could be part of the StandardRule class
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
             $body = preg_replace('/[\x00-\x09\x0B\x0C\x0E-\x1F\x7F,\xFF,\x8B]/', '', $body);
 
             if (($response->getStatusCode() < 300 || $response->getStatusCode() >= 400)
@@ -25,7 +25,7 @@ 
                 && strlen($body) > 0
             ) {
                 if (stripos($body, '</html>') === false) {
-                    throw new ValidationFailedException('Closing html tag is missing (document length: ' . strlen($body) . ').');
+                    throw new ValidationFailedException('Closing html tag is missing (document length: '.strlen($body).').');
                 }
             }
         }