phmLabs / Smoke

src/Rules/Security/PasswordSecureTransferRule.php

Spacing +3 added lines, -3 removed lines

@@ -19,10 +19,10 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
         $actionNodes = $crawler->filterXPath('//form[//input[@type="password"]]');
 
-        $url = (string)$response->getUri();
+        $url = (string) $response->getUri();
 
         foreach ($actionNodes as $node) {
             $action = $node->getAttribute('action');
@@ -36,7 +36,7 @@ 
 
             while ($parent = $parent->parentNode) {
                 if (property_exists($parent, 'tagName')) {
-                    $fullPath = $parent->tagName . '/' . $fullPath;
+                    $fullPath = $parent->tagName.'/'.$fullPath;
                 } else {
                     break;
                 }

src/Cli/Command/SmokeCommand.php

Spacing +4 added lines, -4 removed lines

@@ -56,10 +56,10 @@ 
      */
     protected function writeSmokeCredentials($url = null)
     {
-        $this->output->writeln("\n Smoke " . SMOKE_VERSION . " by Nils Langner\n");
+        $this->output->writeln("\n Smoke ".SMOKE_VERSION." by Nils Langner\n");
 
         if ($url) {
-            $this->output->writeln(' <info>Scanning ' . $url . "</info>\n");
+            $this->output->writeln(' <info>Scanning '.$url."</info>\n");
         }
     }
 
@@ -89,12 +89,12 @@ 
         if ($configFile) {
             if (strpos($configFile, 'http://') === 0 || strpos($configFile, 'https://') === 0) {
                 $curlClient = new Client();
-                $fileContent = (string)$curlClient->get($configFile)->getBody();
+                $fileContent = (string) $curlClient->get($configFile)->getBody();
             } else {
                 if (file_exists($configFile)) {
                     $fileContent = file_get_contents($configFile);
                 } else {
-                    throw new \RuntimeException("Config file was not found ('" . $configFile . "').");
+                    throw new \RuntimeException("Config file was not found ('".$configFile."').");
                 }
             }
             $configArray = EnvAwareYaml::parse($fileContent);

src/Rules/Html/BigContentRule.php

Spacing +2 added lines, -2 removed lines

@@ -36,12 +36,12 @@
         }
 
         if ($totalSize > $this->maxSize) {
-            $message = 'The total size of the file (and all assets) was ' . $totalSize . ' KB (max: ' . $this->maxSize . ' KB).';
+            $message = 'The total size of the file (and all assets) was '.$totalSize.' KB (max: '.$this->maxSize.' KB).';
             $result = new CheckResult(CheckResult::STATUS_FAILURE, $message, $totalSize);
             $result->addAttribute(new Attribute('resources', $response->getResources(), true));
             return $result;
         } else {
-            $message = 'The total size of the file (and all assets) was ' . $totalSize . ' KB (max: ' . $this->maxSize . ' KB).';
+            $message = 'The total size of the file (and all assets) was '.$totalSize.' KB (max: '.$this->maxSize.' KB).';
             $result = new CheckResult(CheckResult::STATUS_SUCCESS, $message, $totalSize);
             $result->addAttribute(new Attribute('resources', $response->getResources(), true));
             return $result;

src/Rules/Html/BigFilesRule.php

Spacing +2 added lines, -2 removed lines

@@ -38,9 +38,9 @@
         }
 
         if (count($bigFiles) > 0) {
-            $message = "Some files were found that are too big (max: " . $this->maxElementSize . " KB):<ul>";
+            $message = "Some files were found that are too big (max: ".$this->maxElementSize." KB):<ul>";
             foreach ($bigFiles as $bigFile) {
-                $message .= '<li>File: ' . $bigFile['name'] . ', Size: ' . $bigFile['size'] . ' KB</li>';
+                $message .= '<li>File: '.$bigFile['name'].', Size: '.$bigFile['size'].' KB</li>';
             }
             $message .= "</ul>";
             $result = new CheckResult(CheckResult::STATUS_FAILURE, $message, count($bigFiles));

src/Extensions/SmokeOnFailure/OnFailureExtension.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 
     public function init($command)
     {
-        $this->callback = function () use ($command) {
+        $this->callback = function() use ($command) {
             return eval($command);
         };
     }

src/Rules/Html/ResourcesCountRule.php

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
 
     public function init($maxElements = 200)
     {
-        $this->maxElements = (int)$maxElements;
+        $this->maxElements = (int) $maxElements;
     }
 
     protected function doValidation(ResponseInterface $response)
@@ -28,12 +28,12 @@ 
         if ($response instanceof ResourcesAwareResponse) {
             $resourceCount = count($response->getResources());
             if ($resourceCount > $this->maxElements) {
-                $message = 'Too many resources were loaded. ' . $resourceCount . ' resources loaded, maximum was ' . $this->maxElements . '.';
+                $message = 'Too many resources were loaded. '.$resourceCount.' resources loaded, maximum was '.$this->maxElements.'.';
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $message, $resourceCount);
                 $result->addAttribute(new Attribute('resources', $response->getResources(), true));
                 return $result;
             } else {
-                $message = $resourceCount . ' resources were loaded.';
+                $message = $resourceCount.' resources were loaded.';
                 return new CheckResult(CheckResult::STATUS_SUCCESS, $message, $resourceCount);
             }
         } else {

src/Rules/Xml/XmlValidXsdRule.php

Spacing +3 added lines, -3 removed lines

@@ -22,7 +22,7 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         $dom = new \DOMDocument();
         @$dom->loadXML($body);
@@ -37,12 +37,12 @@ 
                 $error = true;
                 $lastError = libxml_get_last_error();
 
-                $messageParts[] = $xsdFile['xsdfilename'] . ' - ' . $xsdFile['xsdfileurl'] . ' (last error: ' . str_replace("\n", '', $lastError->message) . ').';
+                $messageParts[] = $xsdFile['xsdfilename'].' - '.$xsdFile['xsdfileurl'].' (last error: '.str_replace("\n", '', $lastError->message).').';
             }
         }
 
         if ($error === true) {
-            $message = 'XML file (' . (string)$response->getUri() . ')  does not validate against the following XSD files: ' . implode(', ', $messageParts);
+            $message = 'XML file ('.(string) $response->getUri().')  does not validate against the following XSD files: '.implode(', ', $messageParts);
             throw new ValidationFailedException($message);
         }
     }

src/Rules/Json/JsonPathExistsRule.php

Spacing +5 added lines, -5 removed lines

@@ -54,7 +54,7 @@ 
 
     public function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         $json = json_decode($body);
 
@@ -73,17 +73,17 @@ 
 
             if ($jsonValue === false || (is_array($jsonValue) && empty($jsonValue))) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (JSON path not found)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (JSON path not found)';
             }
-            if ($this->checkRelation($path['relation'], (int)$path['value'], $count) === false) {
+            if ($this->checkRelation($path['relation'], (int) $path['value'], $count) === false) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (' . $count . ' elements found, expected ' . $path['relation'] . ' ' . $path['value'] . ')';
+                $noCorrectJsonPaths[] = $path['pattern'].' ('.$count.' elements found, expected '.$path['relation'].' '.$path['value'].')';
             }
         }
 
         if ($error === true) {
             $allNoCorrectJsonPaths = implode('", "', $noCorrectJsonPaths);
-            throw new ValidationFailedException('Disonances with JSON Paths "' . $allNoCorrectJsonPaths . '!');
+            throw new ValidationFailedException('Disonances with JSON Paths "'.$allNoCorrectJsonPaths.'!');
         }
     }
 }

src/Rules/Html/InsecureContentRule.php

Spacing +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@ 
             return;
         }
 
-        $htmlDocument = new Document((string)$response->getBody());
+        $htmlDocument = new Document((string) $response->getBody());
 
         $resources = $htmlDocument->getDependencies($uri, false);
 
@@ -46,7 +46,7 @@ 
             if ($resource->getScheme() && 'https' !== $resource->getScheme()) {
                 $excluded = false;
                 foreach ($this->excludedFiles as $excludedFile) {
-                    if (preg_match('*' . $excludedFile . '*', (string)$resource)) {
+                    if (preg_match('*'.$excludedFile.'*', (string) $resource)) {
                         $excluded = true;
                         break;
                     }
@@ -60,7 +60,7 @@ 
         if (count($unsecures) > 0) {
             $message = 'At least one dependency was found on a secure url, that was transfered insecure.<ul>';
             foreach ($unsecures as $unsecure) {
-                $message .= '<li>' . (string)$unsecure . '</li>';
+                $message .= '<li>'.(string) $unsecure.'</li>';
             }
             $message .= '</ul>';
             return new CheckResult(CheckResult::STATUS_FAILURE, $message, count($unsecures));