Completed
Push — master ( 9ad1a6...571f4d )
by Nils
02:31
created
src/Extensions/SmokeReporter/Reporter/XUnitReporter.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         $failures = 0;
60 60
 
61 61
         if ($this->retriever instanceof CrawlingRetriever) {
62
-            $startPage = (string)$this->retriever->getStartPage();
62
+            $startPage = (string) $this->retriever->getStartPage();
63 63
         } else {
64 64
             $startPage = '';
65 65
         }
@@ -80,8 +80,8 @@  discard block
 block discarded – undo
80 80
                     $testCase->addFailure(new Failure($ruleName, $message));
81 81
 
82 82
                     if ($this->retriever instanceof CrawlingRetriever) {
83
-                        $stackTrace = $result->getUrl() . ' coming from ' . (string)$this->retriever->getComingFrom($result->getUrl()) . PHP_EOL;
84
-                        $stackTrace .= '    - ' . $message . " [rule: $ruleName]";
83
+                        $stackTrace = $result->getUrl().' coming from '.(string) $this->retriever->getComingFrom($result->getUrl()).PHP_EOL;
84
+                        $stackTrace .= '    - '.$message." [rule: $ruleName]";
85 85
                         $testCase->setSystemOut($stackTrace);
86 86
                     }
87 87
                 }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 
93 93
         file_put_contents($this->filename, $xUnitReport->toXml());
94 94
 
95
-        $this->output->writeln('    <info>Writing XUnit Output to file:</info> ' . $this->filename);
95
+        $this->output->writeln('    <info>Writing XUnit Output to file:</info> '.$this->filename);
96 96
     }
97 97
 
98 98
     public function processResults($results)
Please login to merge, or discard this patch.
src/Rules/Http/Header/GZipRule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
         if ($response instanceof ContentTypeAwareResponse) {
25 25
             if (strpos($response->getContentType(), 'image') === false
26 26
                 && strpos($response->getContentType(), 'pdf') === false
27
-                && strlen((string)$response->getBody()) >= $this->minFileSize
27
+                && strlen((string) $response->getBody()) >= $this->minFileSize
28 28
             ) {
29 29
                 if (!$response->hasHeader('Content-Encoding') || $response->getHeader('Content-Encoding')[0] !== 'gzip') {
30 30
                     throw new ValidationFailedException('gzip compression not active');
Please login to merge, or discard this patch.
src/Rules/Http/Header/SuccessStatusRule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
     public function validate(ResponseInterface $response)
23 23
     {
24 24
         if ($response->getStatusCode() > $this->maxStatusCode) {
25
-            throw new ValidationFailedException('Status code ' . $response->getStatusCode() . ' found.');
25
+            throw new ValidationFailedException('Status code '.$response->getStatusCode().' found.');
26 26
         }
27 27
     }
28 28
 }
Please login to merge, or discard this patch.
src/Rules/Http/Header/HttpStatusRule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
     public function validate(ResponseInterface $response)
27 27
     {
28 28
         if ($response->getStatusCode() !== $this->expectedStatus) {
29
-            throw new ValidationFailedException('Status code ' . $response->getStatusCode() . ' found, ' . $this->expectedStatus . ' expected.');
29
+            throw new ValidationFailedException('Status code '.$response->getStatusCode().' found, '.$this->expectedStatus.' expected.');
30 30
         }
31 31
     }
32 32
 }
Please login to merge, or discard this patch.
src/Rules/Http/DurationRule.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -29,14 +29,14 @@
 block discarded – undo
29 29
             if ($response->getDuration() > $this->maxDuration) {
30 30
                 return new CheckResult(
31 31
                     CheckResult::STATUS_FAILURE,
32
-                    'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
33
-                    (int)$response->getDuration());
32
+                    'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
33
+                    (int) $response->getDuration());
34 34
             }
35 35
 
36 36
             return new CheckResult(
37 37
                 CheckResult::STATUS_SUCCESS,
38
-                'The http request took ' . (int)$response->getDuration() . ' milliseconds.',
39
-                (int)$response->getDuration());
38
+                'The http request took '.(int) $response->getDuration().' milliseconds.',
39
+                (int) $response->getDuration());
40 40
         }
41 41
     }
42 42
 }
Please login to merge, or discard this patch.
src/Rules/Html/CountRule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
     protected function doValidation(ResponseInterface $response)
28 28
     {
29
-        $document = new Document((string)$response->getBody());
29
+        $document = new Document((string) $response->getBody());
30 30
         $files = $this->getFilesToCount($document, $response);
31 31
 
32 32
         $this->assert(count($files) <= $this->maxCount, sprintf($this->errorMessage, count($files)));
Please login to merge, or discard this patch.
src/Rules/Html/XPathExistsRule.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     public function doValidation(ResponseInterface $response)
23 23
     {
24 24
         $domDocument = new \DOMDocument();
25
-        @$domDocument->loadHTML((string)$response->getBody());
25
+        @$domDocument->loadHTML((string) $response->getBody());
26 26
 
27 27
         $domXPath = new \DOMXPath($domDocument);
28 28
 
@@ -30,16 +30,16 @@  discard block
 block discarded – undo
30 30
             $count = $domXPath->query($xpath['pattern'])->length;
31 31
 
32 32
             if ($xpath['relation'] === 'equals') {
33
-                $result = $count === (int)$xpath['value'];
34
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
33
+                $result = $count === (int) $xpath['value'];
34
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
35 35
             } elseif ($xpath['relation'] === 'less than') {
36
-                $result = $count < (int)$xpath['value'];
37
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
36
+                $result = $count < (int) $xpath['value'];
37
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
38 38
             } elseif ($xpath['relation'] === 'greater than') {
39
-                $result = $count > (int)$xpath['value'];
40
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
39
+                $result = $count > (int) $xpath['value'];
40
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
41 41
             } else {
42
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
42
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
43 43
             }
44 44
 
45 45
             $this->assert($result, $message);
Please login to merge, or discard this patch.
src/Rules/Html/CssSelectorExistsRule.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     public function doValidation(ResponseInterface $response)
25 25
     {
26 26
         $domDocument = new \DOMDocument();
27
-        @$domDocument->loadHTML((string)$response->getBody());
27
+        @$domDocument->loadHTML((string) $response->getBody());
28 28
 
29 29
         $domXPath = new \DOMXPath($domDocument);
30 30
 
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
             try {
38 38
                 $selectorAsXPath = $converter->toXPath($selector['pattern']);
39 39
             } catch (\Exception $e) {
40
-                throw new ValidationFailedException('Invalid css selector (' . $selector['pattern'] . ').');
40
+                throw new ValidationFailedException('Invalid css selector ('.$selector['pattern'].').');
41 41
             }
42 42
 
43 43
             $count = $domXPath->query($selectorAsXPath)->length;
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
         if ($error === true) {
52 52
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
53 53
 
54
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
54
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
55 55
         }
56 56
     }
57 57
 }
Please login to merge, or discard this patch.
src/Rules/Seo/GoogleMobileFriendlyRule.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 
15 15
     private function getEndpoint(Uri $uri)
16 16
     {
17
-        return str_replace('#url#', urlencode((string)$uri), self::ENDPOINT);
17
+        return str_replace('#url#', urlencode((string) $uri), self::ENDPOINT);
18 18
     }
19 19
 
20 20
     public function validate(ResponseInterface $response)
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
             )));
34 34
 
35 35
         if (property_exists($result, 'error')) {
36
-            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
36
+            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
37 37
             $checkResult->addAttribute(new Attribute('Google response', json_encode($result), true));
38 38
             return $checkResult;
39 39
         }
@@ -41,9 +41,9 @@  discard block
 block discarded – undo
41 41
         $passResult = $result->ruleGroups->USABILITY;
42 42
 
43 43
         if (!$passResult->pass) {
44
-            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
44
+            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
45 45
         }
46 46
 
47
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
47
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
48 48
     }
49 49
 }
Please login to merge, or discard this patch.