Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | View Code Duplication | class HeadlessChromeClient implements HttpClient |
|
| 12 | { |
||
| 13 | /** |
||
| 14 | * @var HeadlessChrome |
||
| 15 | */ |
||
| 16 | private $chromeClient; |
||
| 17 | |||
| 18 | public function init($nocache = false, $clientTimeout = 31000) |
||
| 28 | |||
| 29 | public function sendRequest(RequestInterface $request) |
||
| 33 | |||
| 34 | public function sendRequests(array $requests) |
||
| 38 | |||
| 39 | public function getClientType() |
||
| 43 | |||
| 44 | public function close() |
||
| 48 | |||
| 49 | public function setOption($key, $value) |
||
| 53 | } |
||
| 54 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..