ValidRule::getSchema() - Code Metrics - Inspection of "sitemap validation rule" - phmLabs/Smoke - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#87)

unknown

created 2016-08-04 14:38 UTC

ValidRule::getSchema() A

↳ Parent: ValidRule

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	1

Metric	Value
c	1
b	1
f	1
dl	0
loc	10
rs	9.4285
cc	3
eloc	7
nc	3
nop	1

<?php

namespace whm\Smoke\Rules\Xml\Sitemap;

use whm\Smoke\Http\Response;
use whm\Smoke\Rules\Rule;
use whm\Smoke\Rules\ValidationFailedException;

/**
 * This rule checks if a rss feed is valid.
 */
class ValidRule implements Rule
{
    const SITEINDEX = 'siteindex.xsd';
    const SITEMAP = 'sitemap.xsd';

    private function getSchema($name = 'index')
    {
        switch ($name) {
            case 'map':
                return __DIR__ . '/' . self::SITEMAP;
            case 'index':
            default:
                return __DIR__ . '/' . self::SITEINDEX;
        }
    }

    public function validate(Response $response)
    {
        if ($response->getContentType() !== 'text/xml') {
            return;
        }

        $body = $response->getBody();

        if (0 === preg_match('/<(sitemapindex|urlset)/', $body)) {
            return;
        }

        libxml_clear_errors();
        $dom = new \DOMDocument();
        @$dom->loadXML($body);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        $lastError = libxml_get_last_error();
        if ($lastError) {
            throw new ValidationFailedException(
                'The given sitemap file is not well formed (last error: ' .
                str_replace("\n", '', $lastError->message) . ').');
        }

        if (preg_match('/<sitemapindex/', $body)) {
            $valid = @$dom->schemaValidate($this->getSchema('index'));
        } elseif (preg_match('/<urlset/', $body)) {
            $valid = @$dom->schemaValidate($this->getSchema('map'));
        } else {
            $valid = false;
        }

        if (!$valid) {

            $lastError = libxml_get_last_error();
            $lastErrorMessage = str_replace("\n", '', $lastError->message);
            throw new ValidationFailedException(
                'The given sitemap file did not validate vs. ' .
                $this->getSchema() . ' (last error: ' .
                $lastErrorMessage . ').');
        }
    }
}


1		<?php
2
3		namespace whm\Smoke\Rules\Xml\Sitemap;
4
5		use whm\Smoke\Http\Response;
6		use whm\Smoke\Rules\Rule;
7		use whm\Smoke\Rules\ValidationFailedException;
8
9		/**
10		* This rule checks if a rss feed is valid.
11		*/
12		class ValidRule implements Rule
13		{
14		const SITEINDEX = 'siteindex.xsd';
15		const SITEMAP = 'sitemap.xsd';
16
17		private function getSchema($name = 'index')
18		{
19		switch ($name) {
20		case 'map':
21		return __DIR__ . '/' . self::SITEMAP;
22		case 'index':
23		default:
24		return __DIR__ . '/' . self::SITEINDEX;
25		}
26		}
27
28		public function validate(Response $response)
29		{
30		if ($response->getContentType() !== 'text/xml') {
31		return;
32		}
33
34		$body = $response->getBody();
35
36		if (0 === preg_match('/<(sitemapindex\|urlset)/', $body)) {
37		return;
38		}
39
40		libxml_clear_errors();
41		$dom = new \DOMDocument();
42		@$dom->loadXML($body);
		0 ignored issues – show Security Best Practice introduced 2016-08-04 14:41 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
43		$lastError = libxml_get_last_error();
44		if ($lastError) {
45		throw new ValidationFailedException(
46		'The given sitemap file is not well formed (last error: ' .
47		str_replace("\n", '', $lastError->message) . ').');
48		}
49
50		if (preg_match('/<sitemapindex/', $body)) {
51		$valid = @$dom->schemaValidate($this->getSchema('index'));
52		} elseif (preg_match('/<urlset/', $body)) {
53		$valid = @$dom->schemaValidate($this->getSchema('map'));
54		} else {
55		$valid = false;
56		}
57
58	View Code Duplication	if (!$valid) {
		0 ignored issues – show Duplication introduced 2016-08-04 14:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		$lastError = libxml_get_last_error();
60		$lastErrorMessage = str_replace("\n", '', $lastError->message);
61		throw new ValidationFailedException(
62		'The given sitemap file did not validate vs. ' .
63		$this->getSchema() . ' (last error: ' .
64		$lastErrorMessage . ').');
65		}
66		}
67		}
68

phmLabs / Smoke

Pull Request — master (#87)

ValidRule::getSchema() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like