phmLabs / Smoke

src/Cli/Command/ExplainCommand.php

Spacing +4 added lines, -4 removed lines

@@ -37,15 +37,15 @@
 
         foreach ($rules as $name => $rule) {
             $info = Init::getInitInformationByClass(get_class($rule));
-            $output->writeln('  ' . $name . ':');
-            $output->writeln('    class: ' . get_class($rule));
-            $output->writeln('    description: ' . str_replace("\n", "\n                 ", $info['documentation']));
+            $output->writeln('  '.$name.':');
+            $output->writeln('    class: '.get_class($rule));
+            $output->writeln('    description: '.str_replace("\n", "\n                 ", $info['documentation']));
 
             if (count($info['parameters']) > 0) {
                 $output->writeln('    parameter:');
 
                 foreach ($info['parameters'] as $parameter) {
-                    $output->writeln('      ' . $parameter['name'] . ': ' . $parameter['description'] . ' (default: ' . $parameter['default'] . ')');
+                    $output->writeln('      '.$parameter['name'].': '.$parameter['description'].' (default: '.$parameter['default'].')');
                 }
             }
 

src/Cli/Command/SmokeCommand.php

Spacing +3 added lines, -3 removed lines

@@ -45,10 +45,10 @@ 
      */
     protected function writeSmokeCredentials($url = null)
     {
-        $this->output->writeln("\n Smoke " . SMOKE_VERSION . " by Nils Langner\n");
+        $this->output->writeln("\n Smoke ".SMOKE_VERSION." by Nils Langner\n");
 
         if ($url) {
-            $this->output->writeln(' <info>Scanning ' . $url . "</info>\n");
+            $this->output->writeln(' <info>Scanning '.$url."</info>\n");
         }
     }
 
@@ -107,7 +107,7 @@ 
                 if (file_exists($configFile)) {
                     $fileContent = file_get_contents($configFile);
                 } else {
-                    throw new \RuntimeException("Config file was not found ('" . $configFile . "').");
+                    throw new \RuntimeException("Config file was not found ('".$configFile."').");
                 }
             }
             $configArray = EnvAwareYaml::parse($fileContent);

src/Cli/Command/ScanCommand.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      */
     private function initConfiguration($num_urls, $run_level, Uri $uri, Dispatcher $dispatcher)
     {
-        $configArray = $this->getConfigArray(__DIR__ . '/../../settings/' . self::CONFIG_FILE);
+        $configArray = $this->getConfigArray(__DIR__.'/../../settings/'.self::CONFIG_FILE);
 
         $config = new Configuration($uri, $dispatcher, $configArray);
 

src/Cli/Command/WarmUpCommand.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
      */
     private function initConfiguration(Uri $uri, Dispatcher $dispatcher)
     {
-        $configArray = $this->getConfigArray(__DIR__ . '/../../settings/warmup.yml');
+        $configArray = $this->getConfigArray(__DIR__.'/../../settings/warmup.yml');
 
         $config = new Configuration($uri, $dispatcher, $configArray);
 

src/Config/Configuration.php

Spacing +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
     private function initConfigArray(array $configArray, array $defaultSettings = null)
     {
         if ($defaultSettings === null) {
-            $defaultSettings = Yaml::parse(file_get_contents(__DIR__ . '/../settings/' . self::DEFAULT_SETTINGS));
+            $defaultSettings = Yaml::parse(file_get_contents(__DIR__.'/../settings/'.self::DEFAULT_SETTINGS));
         }
 
         if (count($configArray) === 0) {
@@ -126,7 +126,7 @@ 
         if ($this->hasSection($section)) {
             return $this->configArray[$section];
         } else {
-            throw new \RuntimeException('The section (' . $section . ') you are trying to access does not exist.');
+            throw new \RuntimeException('The section ('.$section.') you are trying to access does not exist.');
         }
     }
 
@@ -135,7 +135,7 @@ 
         if (array_key_exists($name, $this->extensions)) {
             return $this->extensions[$name];
         } else {
-            throw new \RuntimeException('The extension ("' . $name . '") you are trying to access does not exist. Registered extensions are: ' . implode(' ,', array_keys($this->extensions)) . '.');
+            throw new \RuntimeException('The extension ("'.$name.'") you are trying to access does not exist. Registered extensions are: '.implode(' ,', array_keys($this->extensions)).'.');
         }
     }
 

src/Extensions/SmokeResponseRetriever/Retriever/ListRetriever/Retriever.php

Spacing +5 added lines, -5 removed lines

@@ -53,20 +53,20 @@
                         /* @var \Ivory\HttpAdapter\HttpAdapterException $exception */
 
                         $mainUri = $request->getUri();
-                        $this->redirects[(string) $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl] = (string) $mainUri;
+                        $this->redirects[(string) $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl] = (string) $mainUri;
 
-                        $this->urls[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
-                        $this->urlStack[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
+                        $this->urls[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
+                        $this->urlStack[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
 
                         return $this->next();
                     }
 
                     // the error handling should be done withing the calling class
-                    echo "\n   " . $exception->getMessage() . "\n";
+                    echo "\n   ".$exception->getMessage()."\n";
 
                     return $this->next();
                 } else {
-                    $errorMessages .= $exception->getMessage() . "\n";
+                    $errorMessages .= $exception->getMessage()."\n";
                 }
             }
             if ($errorMessages !== '') {

src/Extensions/SmokeStop/StopExtension.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
         if (array_key_exists($name, $this->stopStrategies)) {
             return $this->stopStrategies[$name];
         } else {
-            throw new \RuntimeException("Strategy ('" . $name . "') not found. Available strategies are " . implode(', ', array_keys($this->stopStrategies)));
+            throw new \RuntimeException("Strategy ('".$name."') not found. Available strategies are ".implode(', ', array_keys($this->stopStrategies)));
         }
     }
 }

src/Extensions/SmokeFilter/FilterExtension.php

Spacing +3 added lines, -3 removed lines

@@ -41,12 +41,12 @@ 
     public function init($filters = array(), $filterFile = '', $exclusive = array())
     {
         if (count($exclusive) > 0 && (count($filters) > 0 || $filterFile !== '')) {
-            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: " . get_class($this) . '].');
+            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: ".get_class($this).'].');
         }
 
         if ($filterFile !== '') {
             if (!file_exists($filterFile)) {
-                throw new \RuntimeException('Filter file not found: ' . $filterFile);
+                throw new \RuntimeException('Filter file not found: '.$filterFile);
             }
 
             $filterElements = EnvAwareYaml::parse(file_get_contents($filterFile));
@@ -105,7 +105,7 @@ 
     private function isFilteredByFilter($ruleName, $uri)
     {
         foreach ($this->filters as $filter) {
-            if ($ruleName === $filter['rule'] && 0 < preg_match('$' . $filter['uri'] . '$', $uri)) {
+            if ($ruleName === $filter['rule'] && 0 < preg_match('$'.$filter['uri'].'$', $uri)) {
                 return true;
             }
         }

src/Extensions/SmokeReporter/Reporter/KoalamonReporter.php

Spacing +15 added lines, -15 removed lines

@@ -92,7 +92,7 @@ 
 
     public function finish()
     {
-        $this->output->writeln('Sending results to ' . $this->server . " ... \n");
+        $this->output->writeln('Sending results to '.$this->server." ... \n");
 
         if ($this->groupBy === 'prefix') {
             $this->sendGroupedByPrefix();
@@ -123,7 +123,7 @@ 
 
         foreach ($this->getRuleKeys() as $rule) {
             foreach ($systems as $system) {
-                $identifier = $this->tool . '_' . $this->getPrefix($rule) . '_' . $system;
+                $identifier = $this->tool.'_'.$this->getPrefix($rule).'_'.$system;
                 $failureMessages[$identifier]['message'] = '';
                 $failureMessages[$identifier]['system'] = $system;
                 $failureMessages[$identifier]['tool'] = $this->getPrefix($rule);
@@ -140,22 +140,22 @@ 
                         $system = $this->retriever->getSystem(($result->getUrl()));
                     }
 
-                    $identifer = $this->tool . '_' . $this->getPrefix($ruleLKey) . '_' . $system;
+                    $identifer = $this->tool.'_'.$this->getPrefix($ruleLKey).'_'.$system;
 
                     if ($failureMessages[$identifer]['message'] === '') {
-                        $failureMessages[$identifer]['message'] = 'The ' . $this->getPrefix($ruleLKey) . ' test for ' . $system . ' failed.<ul>';
+                        $failureMessages[$identifer]['message'] = 'The '.$this->getPrefix($ruleLKey).' test for '.$system.' failed.<ul>';
                     }
                     ++$counter[$identifer];
-                    $failureMessages[$identifer]['message'] .= '<li>' . $message . '<br>url: ' . $result->getUrl() . ', coming from: ' . $this->retriever->getComingFrom($result->getUrl()) . '</li>';
+                    $failureMessages[$identifer]['message'] .= '<li>'.$message.'<br>url: '.$result->getUrl().', coming from: '.$this->retriever->getComingFrom($result->getUrl()).'</li>';
                 }
             }
         }
 
         foreach ($failureMessages as $key => $failureMessage) {
             if ($failureMessage['message'] !== '') {
-                $this->send($this->identifier . '_' . $key, $failureMessage['system'], $failureMessage['message'] . '</ul>', self::STATUS_FAILURE, '', $counter[$key], $failureMessage['tool']);
+                $this->send($this->identifier.'_'.$key, $failureMessage['system'], $failureMessage['message'].'</ul>', self::STATUS_FAILURE, '', $counter[$key], $failureMessage['tool']);
             } else {
-                $this->send($this->identifier . '_' . $key, $failureMessage['system'], '', self::STATUS_SUCCESS, '', 0, $failureMessage['tool']);
+                $this->send($this->identifier.'_'.$key, $failureMessage['system'], '', self::STATUS_SUCCESS, '', 0, $failureMessage['tool']);
             }
         }
     }
@@ -167,7 +167,7 @@ 
             $failedTests = array();
             if ($result->isFailure()) {
                 foreach ($result->getMessages() as $ruleLKey => $message) {
-                    $identifier = 'smoke_' . $ruleLKey . '_' . $result->getUrl();
+                    $identifier = 'smoke_'.$ruleLKey.'_'.$result->getUrl();
 
                     if ($this->system === '') {
                         $system = str_replace('http://', '', $result->getUrl());
@@ -180,7 +180,7 @@ 
             }
             foreach ($rules as $rule) {
                 if (!in_array($rule, $failedTests, true)) {
-                    $identifier = 'smoke_' . $rule . '_' . $result->getUrl();
+                    $identifier = 'smoke_'.$rule.'_'.$result->getUrl();
 
                     if ($this->systemUseRetriever) {
                         $system = $this->retriever->getSystem($result->getUrl());
@@ -189,7 +189,7 @@ 
                     } else {
                         $system = $this->system;
                     }
-                    $this->send($identifier, $system, 'smoke_' . $rule . '_' . $result->getUrl(), self::STATUS_SUCCESS, (string) $result->getUrl());
+                    $this->send($identifier, $system, 'smoke_'.$rule.'_'.$result->getUrl(), self::STATUS_SUCCESS, (string) $result->getUrl());
                 }
             }
         }
@@ -213,16 +213,16 @@ 
                         $system = $this->retriever->getSystem(new Uri($result->getUrl()));
                     }
                     if ($failureMessages[$ruleLKey] === '') {
-                        $failureMessages[$ruleLKey]['message'] = '    The smoke test for ' . $system . ' failed (Rule: ' . $ruleLKey . ').<ul>';
+                        $failureMessages[$ruleLKey]['message'] = '    The smoke test for '.$system.' failed (Rule: '.$ruleLKey.').<ul>';
                     }
                     ++$counter[$ruleLKey];
 
                     $comingFrom = '';
                     if ($this->retriever->getComingFrom($result->getUrl())) {
-                        $comingFrom = ', coming from: ' . $this->retriever->getComingFrom($result->getUrl());
+                        $comingFrom = ', coming from: '.$this->retriever->getComingFrom($result->getUrl());
                     }
 
-                    $failureMessages[$ruleLKey]['message'] .= '<li>' . $message . ' (url: ' . $result->getUrl() . $comingFrom . ')</li > ';
+                    $failureMessages[$ruleLKey]['message'] .= '<li>'.$message.' (url: '.$result->getUrl().$comingFrom.')</li > ';
                     $failureMessages[$ruleLKey]['system'] = $system;
                 }
             }
@@ -230,9 +230,9 @@ 
 
         foreach ($failureMessages as $key => $failureMessage) {
             if ($failureMessage !== '') {
-                $this->send($this->identifier . '_' . $key, $this->system, $failureMessage['message'] . ' </ul > ', self::STATUS_FAILURE, '', $counter[$key]);
+                $this->send($this->identifier.'_'.$key, $this->system, $failureMessage['message'].' </ul > ', self::STATUS_FAILURE, '', $counter[$key]);
             } else {
-                $this->send($this->identifier . '_' . $key, $this->system, '', self::STATUS_SUCCESS, '', 0);
+                $this->send($this->identifier.'_'.$key, $this->system, '', self::STATUS_SUCCESS, '', 0);
             }
         }
     }