phmLabs / Smoke

src/Yaml/EnvAwareYaml.php

Spacing +2 added lines, -2 removed lines

@@ -11,10 +11,10 @@
         preg_match_all('^\${(.*)}^', $fileContent, $matches);
         foreach ($matches[1] as $varName) {
             if (!getenv($varName)) {
-                throw new \RuntimeException('The mandatory env variable (' . $varName . ') from the config file was not set.');
+                throw new \RuntimeException('The mandatory env variable ('.$varName.') from the config file was not set.');
             }
 
-            $fileContent = str_replace('${' . $varName . '}', getenv($varName), $fileContent);
+            $fileContent = str_replace('${'.$varName.'}', getenv($varName), $fileContent);
         }
 
         return Yaml::parse($fileContent);

src/Rules/Seo/RobotsDisallowAllRule.php

Spacing +4 added lines, -4 removed lines

@@ -13,12 +13,12 @@ 
 {
     public function validate(Response $response)
     {
-        $url = $response->getUri()->getScheme() . '://' . $response->getUri()->getHost();
+        $url = $response->getUri()->getScheme().'://'.$response->getUri()->getHost();
 
         if (substr_count($url, '/') === 2) {
-            $filename = $robotsUrl = $url . '/robots.txt';
+            $filename = $robotsUrl = $url.'/robots.txt';
         } elseif (substr_count($url, '/') === 3) {
-            $filename = $robotsUrl = $url . 'robots.txt';
+            $filename = $robotsUrl = $url.'robots.txt';
         } else {
             return;
         }
@@ -29,7 +29,7 @@ 
             $content = file_get_contents($filename);
             $normalizedContent = str_replace(' ', '', $content);
 
-            if (strpos($normalizedContent, 'Disallow:/' . PHP_EOL) !== false) {
+            if (strpos($normalizedContent, 'Disallow:/'.PHP_EOL) !== false) {
                 throw new ValidationFailedException('The robots.txt contains disallow all (Disallow: /)');
             }
         }

src/Rules/Js/SyntaxRule.php

Spacing +5 added lines, -5 removed lines

@@ -30,18 +30,18 @@
             return;
         }
 
-        $filename = $this->tmpDir . DIRECTORY_SEPARATOR . md5($response->getBody()) . '.js';
+        $filename = $this->tmpDir.DIRECTORY_SEPARATOR.md5($response->getBody()).'.js';
         file_put_contents($filename, $response->getBody());
-        $conf = __DIR__ . DIRECTORY_SEPARATOR . 'jsHint.conf';
+        $conf = __DIR__.DIRECTORY_SEPARATOR.'jsHint.conf';
 
-        $command = $this->jsHintExecutable . ' --config ' . $conf . ' --verbose ' . $filename . ' | grep -E E[0-9]+.$';
+        $command = $this->jsHintExecutable.' --config '.$conf.' --verbose '.$filename.' | grep -E E[0-9]+.$';
         $validationResult = shell_exec($command);
 
         unlink($filename);
 
         if (!is_null($validationResult)) {
-            $errorMsg = str_replace($filename . ':', '', $validationResult);
-            throw new ValidationFailedException('JavaScript error found: ' . $errorMsg);
+            $errorMsg = str_replace($filename.':', '', $validationResult);
+            throw new ValidationFailedException('JavaScript error found: '.$errorMsg);
         }
     }
 }

src/Rules/Http/DurationRule.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     public function validate(Response $response)
     {
         if ($response->getDuration() > $this->maxDuration) {
-            throw new ValidationFailedException('the http request lasted ' . $response->getDuration() . ' milliseconds.');
+            throw new ValidationFailedException('the http request lasted '.$response->getDuration().' milliseconds.');
         }
     }
 }

src/Rules/Http/Header/ExistsRule.php

Spacing +2 added lines, -2 removed lines

@@ -22,13 +22,13 @@
     {
         foreach ($this->checkedHeaders as $headerConfig) {
             if (!$response->hasHeader($headerConfig['key'])) {
-                throw new ValidationFailedException('Header not found (' . $headerConfig['key'] . ')');
+                throw new ValidationFailedException('Header not found ('.$headerConfig['key'].')');
             }
 
             $currentValue = $response->getHeader($headerConfig['key'])[0];
 
             if ($currentValue !== $headerConfig['value']) {
-                throw new ValidationFailedException('Header "' . $headerConfig['key'] . '" does not equal "' . $headerConfig['value'] . '". Current value is "' . $currentValue . '"');
+                throw new ValidationFailedException('Header "'.$headerConfig['key'].'" does not equal "'.$headerConfig['value'].'". Current value is "'.$currentValue.'"');
             }
         }
     }

src/Rules/Http/Header/SuccessStatusRule.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
     public function validate(Response $response)
     {
         if ($response->getStatus() > $this->maxStatusCode) {
-            throw new ValidationFailedException('Status code ' . $response->getStatus() . ' found.');
+            throw new ValidationFailedException('Status code '.$response->getStatus().' found.');
         }
     }
 }

src/Rules/Http/Header/HttpStatusRule.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     public function validate(Response $response)
     {
         if ($response->getStatus() !== $this->expectedStatus) {
-            throw new ValidationFailedException('Status code ' . $response->getStatus() . ' found, ' . $this->expectedStatus . ' expected.');
+            throw new ValidationFailedException('Status code '.$response->getStatus().' found, '.$this->expectedStatus.' expected.');
         }
     }
 }

src/Rules/Html/SizeRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,6 +26,6 @@
     protected function doValidation(Response $response)
     {
         $size = strlen($response->getBody()) / 1000;
-        $this->assert($size <= $this->maxSize, 'The size of this html file is too big (' . $size . ' KB)');
+        $this->assert($size <= $this->maxSize, 'The size of this html file is too big ('.$size.' KB)');
     }
 }

src/Rules/Html/ForeignDomainImageRule.php

Spacing +1 added lines, -1 removed lines

@@ -41,6 +41,6 @@
             }
         }
 
-        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found (' . implode(', ', $foreignImages) . ')');
+        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found ('.implode(', ', $foreignImages).')');
     }
 }