phmLabs / Smoke

src/Rules/Html/RegExExistsRule.php

Doc Comments -1 removed lines

@@ -16,7 +16,6 @@
     protected $contentTypes = array('text/html', 'application/json', 'application/xml');
 
     /**
-     * @param int $string The string that the document must contain
      */
     public function init(array $regExs)
     {

Spacing +5 added lines, -5 removed lines

@@ -42,12 +42,12 @@ 
             if ($regEx['isRegEx']) {
                 $pattern = str_replace('', '\\~', $regEx['pattern']);
 
-                if (preg_match('~' . $pattern . '~', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Regular expression: ' . $regEx['pattern'];
+                if (preg_match('~'.$pattern.'~', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Regular expression: '.$regEx['pattern'];
                 }
             } else {
-                if (preg_match('^' . preg_quote($regEx['pattern']) . '^', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Text: ' . $regEx['pattern'];
+                if (preg_match('^'.preg_quote($regEx['pattern']).'^', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Text: '.$regEx['pattern'];
                 }
             }
         }
@@ -56,7 +56,7 @@ 
             $errorString = 'The following text elements were not found: <ul>';
 
             foreach ($errors as $error) {
-                $errorString .= '<li>' . $error . '</li>';
+                $errorString .= '<li>'.$error.'</li>';
             }
 
             $errorString .= '</ul>';

src/Extensions/SmokeMemory/MemoryExtension.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
         foreach ($results as $result) {
             /** @var UriAwareResponse $response */
             if ($result->getStatus() == CheckResult::STATUS_FAILURE) {
-                $this->memory[] = (string)$response->getUri();
+                $this->memory[] = (string) $response->getUri();
             }
         }
     }

src/Rules/Http/RedirectRule.php

Spacing +6 added lines, -6 removed lines

@@ -31,23 +31,23 @@
             $uri = new Uri($url['url']);
 
             $urlResponses = $client->sendRequests([new Request('GET', $uri)]);
-            $effectiveUrl = (string)$urlResponses[0]->getEffectiveUri();
+            $effectiveUrl = (string) $urlResponses[0]->getEffectiveUri();
 
-            if ($effectiveUrl != (string)$response->getUri()) {
-                $errors[] = 'The url "' . $url['url'] . '" gets redirected to "' . $effectiveUrl . '".';
+            if ($effectiveUrl != (string) $response->getUri()) {
+                $errors[] = 'The url "'.$url['url'].'" gets redirected to "'.$effectiveUrl.'".';
             }
         }
 
         if (count($errors) > 0) {
-            $message = 'Not all given urls do redirect to "' . (string)$response->getUri() . '"".<ul>';
+            $message = 'Not all given urls do redirect to "'.(string) $response->getUri().'"".<ul>';
             foreach ($errors as $error) {
-                $message .= '<li>' . $error . '</li>';
+                $message .= '<li>'.$error.'</li>';
             }
             $message .= "</ul>";
 
             return new CheckResult(CheckResult::STATUS_FAILURE, $message);
         } else {
-            return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to ' . (string)$response->getUri());
+            return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to '.(string) $response->getUri());
         }
     }
 }

src/Rules/Html/ClosingHtmlTagRule.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
         if ($response instanceof ContentTypeAwareResponse) {
 
             // @todo this could be part of the StandardRule class
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
             $body = preg_replace('/[\x00-\x09\x0B\x0C\x0E-\x1F\x7F,\xFF,\x8B]/', '', $body);
 
             if (($response->getStatusCode() < 300 || $response->getStatusCode() >= 400)
@@ -25,7 +25,7 @@ 
                 && strlen($body) > 0
             ) {
                 if (stripos($body, '</html>') === false) {
-                    throw new ValidationFailedException('Closing html tag is missing (document length: ' . strlen($body) . ').');
+                    throw new ValidationFailedException('Closing html tag is missing (document length: '.strlen($body).').');
                 }
             }
         }

src/Rules/Html/InvalidUrlsRule.php

Spacing +4 added lines, -4 removed lines

@@ -18,19 +18,19 @@
      */
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody(), false);
+        $document = new Document((string) $response->getBody(), false);
         $urls = $document->getDependencies($response->getUri());
         $invalidUrls = array();
 
         foreach ($urls as $url) {
 
-            $idnUrl = $url->getScheme() . '://' . idn_to_ascii($url->getHost()) .  $url->getPath();
+            $idnUrl = $url->getScheme().'://'.idn_to_ascii($url->getHost()).$url->getPath();
 
             if (!filter_var($idnUrl, FILTER_VALIDATE_URL)) {
-                $invalidUrls[] = (string)$url;
+                $invalidUrls[] = (string) $url;
             }
         }
 
-        $this->assert(count($invalidUrls) === 0, 'Invalid urls found (' . implode(', ', $invalidUrls) . ').');
+        $this->assert(count($invalidUrls) === 0, 'Invalid urls found ('.implode(', ', $invalidUrls).').');
     }
 }

src/Rules/Html/InsecureContentRule.php

Spacing +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
             return;
         }
 
-        $htmlDocument = new Document((string)$response->getBody());
+        $htmlDocument = new Document((string) $response->getBody());
 
         $resources = $htmlDocument->getDependencies($uri, false);
 
@@ -54,7 +54,7 @@ 
             if ($resource->getScheme() && 'https' !== $resource->getScheme()) {
                 $excluded = false;
                 foreach ($this->excludedFiles as $excludedFile) {
-                    if (preg_match('~' . $excludedFile . '~', (string)$resource)) {
+                    if (preg_match('~'.$excludedFile.'~', (string) $resource)) {
                         $excluded = true;
                         break;
                     }
@@ -68,7 +68,7 @@ 
         if (count($unsecures) > 0) {
             $message = 'At least one dependency was found on a secure url, that was transfered insecure.<ul>';
             foreach ($unsecures as $unsecure) {
-                $message .= '<li>' . (string)$unsecure . '</li>';
+                $message .= '<li>'.(string) $unsecure.'</li>';
             }
             $message .= '</ul>';
             return new CheckResult(CheckResult::STATUS_FAILURE, $message, count($unsecures));

src/Rules/Xml/Rss/ValidRule.php

Spacing +6 added lines, -6 removed lines

@@ -21,12 +21,12 @@ 
 
     private function getSchema()
     {
-        return __DIR__ . '/' . self::SCHEMA;
+        return __DIR__.'/'.self::SCHEMA;
     }
 
     public function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         if (preg_match('/<rss/', $body)) {
             libxml_clear_errors();
@@ -35,8 +35,8 @@ 
             $lastError = libxml_get_last_error();
             if ($lastError) {
                 throw new ValidationFailedException(
-                    'The given xml file is not well formed (last error: ' .
-                    str_replace("\n", '', $lastError->message) . ').');
+                    'The given xml file is not well formed (last error: '.
+                    str_replace("\n", '', $lastError->message).').');
             }
             $valid = @$dom->schemaValidate($this->getSchema());
             if (!$valid) {
@@ -44,11 +44,11 @@ 
                 $lastErrorMessage = str_replace("\n", '', $lastError->message);
 
                 if ($response instanceof UriAwareResponse) {
-                    $toolUrl = sprintf(self::PUBLIC_SERVICE, urlencode((string)$response->getUri()));
+                    $toolUrl = sprintf(self::PUBLIC_SERVICE, urlencode((string) $response->getUri()));
                 } else {
                     $toolUrl = '';
                 }
-                return new CheckResult(CheckResult::STATUS_FAILURE, 'The given xml file is not a valid rss file (last error: ' . $lastErrorMessage . ').', null, $toolUrl);
+                return new CheckResult(CheckResult::STATUS_FAILURE, 'The given xml file is not a valid rss file (last error: '.$lastErrorMessage.').', null, $toolUrl);
             }
         }
         return new CheckResult(CheckResult::STATUS_SUCCESS, 'The given rss file is valid.');

src/Cli/Command/CustomCommand.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
         $configArray = $this->getConfigArray($configFile, true);
 
         if (is_string($configArray)) {
-            throw new \RuntimeException('Unable to load config file. Please check ' . $configFile);
+            throw new \RuntimeException('Unable to load config file. Please check '.$configFile);
         }
 
         $this->config = new Configuration(new Uri('http://www.example.com'), $dispatcher, $configArray);

src/Extensions/SmokeReporter/Reporter/HtmlReporter.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Symfony\Component\Console\Output\OutputInterface;
 use whm\Smoke\Config\Configuration;
-use whm\Smoke\Extensions\SmokeResponseRetriever\Retriever\Retriever;
 use whm\Smoke\Rules\CheckResult;
 
 

Spacing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
         $this->resultFile = $resultFile;
 
         if ($templateDir === null) {
-            $this->templateDir = __DIR__ . '/templates';
+            $this->templateDir = __DIR__.'/templates';
         } else {
             $this->templateDir = $templateDir;
         }
@@ -66,9 +66,9 @@ 
         }
 
         if (!file_put_contents($this->resultFile, $html)) {
-            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to " . $this->resultFile ."</error>");
+            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to ".$this->resultFile."</error>");
         } else {
-            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to " . $this->resultFile);
+            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to ".$this->resultFile);
         }
     }