Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | View Code Duplication | class SizeRule extends StandardRule |
|
| 13 | { |
||
| 14 | private $maxSize; |
||
| 15 | |||
| 16 | protected $contentTypes = array('text/html'); |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @param int $maxSize The maximum size of a html file in kilobytes. |
||
| 20 | */ |
||
| 21 | public function init($maxSize = 200) |
||
| 22 | { |
||
| 23 | $this->maxSize = $maxSize; |
||
| 24 | } |
||
| 25 | |||
| 26 | protected function doValidation(Response $response) |
||
| 31 | } |
||
| 32 |