phmLabs / Smoke

src/Rules/Http/DurationRule.php

Spacing +4 added lines, -4 removed lines

@@ -29,14 +29,14 @@
             if ($response->getDuration() > $this->maxDuration) {
                 return new CheckResult(
                     CheckResult::STATUS_FAILURE,
-                    'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                    (int)$response->getDuration());
+                    'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                    (int) $response->getDuration());
             }
 
             return new CheckResult(
                 CheckResult::STATUS_SUCCESS,
-                'The http request took ' . (int)$response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
-                (int)$response->getDuration());
+                'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
+                (int) $response->getDuration());
         }
     }
 }

src/Rules/Xml/Sitemap/ValidRule.php

Doc Comments +5 added lines, -2 removed lines

@@ -27,6 +27,9 @@ 
         $this->strictMode = $strictMode;
     }
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         if ($isIndex) {
@@ -41,8 +44,8 @@ 
     }
 
     /**
-     * @param $body
-     * @param $filename
+     * @param string $body
+     * @param string $filename
      * @param bool $isIndex
      * @throws ValidationFailedException
      */

Spacing +8 added lines, -8 removed lines

@@ -30,13 +30,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -56,7 +56,7 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 
@@ -67,16 +67,16 @@ 
     protected function doValidation(ResponseInterface $response)
     {
         if ($response instanceof DomAwareResponse) {
-            $body = (string)$response->getHtmlBody();
+            $body = (string) $response->getHtmlBody();
         } else {
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
         }
 
         // sitemapindex or urlset
         if (preg_match('/<sitemapindex/', $body)) {
-            $this->validateBody($body, (string)$response->getUri());
+            $this->validateBody($body, (string) $response->getUri());
         } elseif (preg_match('/<urlset/', $body)) {
-            $this->validateBody($body, (string)$response->getUri(), false);
+            $this->validateBody($body, (string) $response->getUri(), false);
         }
     }
 }

src/Rules/Xml/XmlCheckRule.php

Spacing +4 added lines, -4 removed lines

@@ -24,9 +24,9 @@ 
     public function doValidation(ResponseInterface $response)
     {
         if ($response instanceof DomAwareResponse) {
-            $body = (string)$response->getHtmlBody();
+            $body = (string) $response->getHtmlBody();
         } else {
-            $body = (string)$response->getBody();
+            $body = (string) $response->getBody();
         }
 
         if ($body == "") {
@@ -45,8 +45,8 @@ 
             $lastError = libxml_get_last_error();
 
             if ($lastError) {
-                throw new ValidationFailedException('The xml file ' . $response->getUri() . ' is not well formed (last error: ' .
-                    str_replace("\n", '', $lastError->message) . ').');
+                throw new ValidationFailedException('The xml file '.$response->getUri().' is not well formed (last error: '.
+                    str_replace("\n", '', $lastError->message).').');
             } else {
                 return new CheckResult(CheckResult::STATUS_FAILURE, 'Unknown error occured.');
             }

src/Rules/CheckResult.php

Doc Comments +3 added lines, -2 removed lines

@@ -38,6 +38,7 @@ 
      * @param $status
      * @param $value
      * @param $message
+     * @param string $url
      */
     public function __construct($status, $message = '', $value = null, $url = null)
     {
@@ -56,7 +57,7 @@ 
     }
 
     /**
-     * @param array $attributes
+     * @param array $attribute
      */
     public function addAttribute(Attribute $attribute)
     {
@@ -109,7 +110,7 @@ 
     }
 
     /**
-     * @param string $identifier
+     * @param string $identifierRule
      */
     public function setIdentifierRule($identifierRule)
     {

src/Rules/Html/InvalidUrlsRule.php

Spacing +5 added lines, -5 removed lines

@@ -18,22 +18,22 @@
      */
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody(), false);
+        $document = new Document((string) $response->getBody(), false);
         $urls = $document->getDependencies($response->getUri());
         $invalidUrls = array();
 
         foreach ($urls as $url) {
             if (function_exists('idn_to_ascii')) {
-                $idnUrl = $url->getScheme() . '://' . idn_to_ascii($url->getHost()) . $url->getPath();
+                $idnUrl = $url->getScheme().'://'.idn_to_ascii($url->getHost()).$url->getPath();
             } else {
-                $idnUrl = $url->getScheme() . '://' . $url->getHost() . $url->getPath();
+                $idnUrl = $url->getScheme().'://'.$url->getHost().$url->getPath();
             }
 
             if (!filter_var($idnUrl, FILTER_VALIDATE_URL)) {
-                $invalidUrls[] = (string)$url;
+                $invalidUrls[] = (string) $url;
             }
         }
 
-        $this->assert(count($invalidUrls) === 0, 'Invalid urls found (' . implode(', ', $invalidUrls) . ').');
+        $this->assert(count($invalidUrls) === 0, 'Invalid urls found ('.implode(', ', $invalidUrls).').');
     }
 }