HtmlReporter::processResults() - Code Metrics - Inspection of "add HTML Reporter" - phmLabs/Smoke - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8398cb...f02e4f )

unknown

created 2017-09-15 13:41 UTC

HtmlReporter::processResults() A

↳ Parent: HtmlReporter

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1

<?php

namespace whm\Smoke\Extensions\SmokeReporter\Reporter;

use Symfony\Component\Console\Output\OutputInterface;
use whm\Smoke\Config\Configuration;
use whm\Smoke\Extensions\SmokeResponseRetriever\Retriever\Retriever;
use whm\Smoke\Rules\CheckResult;


class HtmlReporter implements Reporter
{
    private $results = [];
    /**
     * @var Configuration
     */
    private $templateDir;
    private $templateFile;
    private $resultFile;

    /**
     * @var OutputInterface
     */
    private $output;

    public function init(OutputInterface $_output, $resultFile, $templateDir = null, $templateFile = 'index.html.twig')
    {
        $this->resultFile = $resultFile;

        if ($templateDir === null) {
            $this->templateDir = __DIR__ . '/templates';

        } else {
            $this->templateDir = $templateDir;
        }

        $this->templateFile = $templateFile;
        $this->output = $_output;
    }

    /**
     * @param CheckResult[] $results
     */
    public function processResults($results)
    {
        foreach ($results as $result) {
            $this->results[] = [
                'url' => $result->getResponse()->getUri(),
                'rule' => $result->getRuleName(),
                'message' => $result->getMessage(),
                'status' => $result->getStatus(),
            ];
        }
    }

    public function finish()
    {
        $loader = new \Twig_Loader_Filesystem($this->templateDir);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $twig = new \Twig_Environment($loader);

        $html = $twig->render($this->templateFile, [
            'results' => $this->results,
        ]);

        if (!file_exists(dirname($this->resultFile))) {
            mkdir(dirname($this->resultFile));
        }

        if (!file_put_contents($this->resultFile, $html)) {
            $this->output->writeln("<error>HTML Reporter extension: Could not write result file to " . $this->resultFile ."</error>");
        } else {
            $this->output->writeln("<info>HTML Reporter extension:</info> Result file written to " . $this->resultFile);
        }
    }

}


1			<?php
2
3			namespace whm\Smoke\Extensions\SmokeReporter\Reporter;
4
5			use Symfony\Component\Console\Output\OutputInterface;
6			use whm\Smoke\Config\Configuration;
7			use whm\Smoke\Extensions\SmokeResponseRetriever\Retriever\Retriever;
8			use whm\Smoke\Rules\CheckResult;
9
10
11			class HtmlReporter implements Reporter
12			{
13			private $results = [];
14			/**
15			* @var Configuration
16			*/
17			private $templateDir;
18			private $templateFile;
19			private $resultFile;
20
21			/**
22			* @var OutputInterface
23			*/
24			private $output;
25
26			public function init(OutputInterface $_output, $resultFile, $templateDir = null, $templateFile = 'index.html.twig')
27			{
28			$this->resultFile = $resultFile;
29
30			if ($templateDir === null) {
31			$this->templateDir = __DIR__ . '/templates';
			0 ignored issues – show Documentation Bug introduced 2017-09-15 13:46 UTC by Report Bug Copy Issue Report It seems like `__DIR__ . '/templates'` of type `string` is incompatible with the declared type `object<whm\Smoke\Config\Configuration>` of property `$templateDir`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
32			} else {
33			$this->templateDir = $templateDir;
34			}
35
36			$this->templateFile = $templateFile;
37			$this->output = $_output;
38			}
39
40			/**
41			* @param CheckResult[] $results
42			*/
43			public function processResults($results)
44			{
45			foreach ($results as $result) {
46			$this->results[] = [
47			'url' => $result->getResponse()->getUri(),
48			'rule' => $result->getRuleName(),
49			'message' => $result->getMessage(),
50			'status' => $result->getStatus(),
51			];
52			}
53			}
54
55			public function finish()
56			{
57			$loader = new \Twig_Loader_Filesystem($this->templateDir);
			0 ignored issues – show Documentation introduced 2017-09-15 13:46 UTC by Report Bug Copy Issue Report `$this->templateDir` is of type `object<whm\Smoke\Config\Configuration>`, but the function expects a `string\|array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58			$twig = new \Twig_Environment($loader);
59
60			$html = $twig->render($this->templateFile, [
61			'results' => $this->results,
62			]);
63
64			if (!file_exists(dirname($this->resultFile))) {
65			mkdir(dirname($this->resultFile));
66			}
67
68			if (!file_put_contents($this->resultFile, $html)) {
69			$this->output->writeln("<error>HTML Reporter extension: Could not write result file to " . $this->resultFile ."</error>");
70			} else {
71			$this->output->writeln("<info>HTML Reporter extension:</info> Result file written to " . $this->resultFile);
72			}
73			}
74
75			}
76

phmLabs / Smoke

Push — master ( 8398cb...f02e4f )

HtmlReporter::processResults() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like