CssSelectorExistsRule::doValidation() - Code Metrics - Inspection of "Strict or NonStrict" - phmLabs/Smoke - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#92)

unknown

created 2016-10-11 15:36 UTC

CssSelectorExistsRule::doValidation() B

↳ Parent: CssSelectorExistsRule

Complexity

Conditions	4
Paths	6

Size

Total Lines	28
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	28
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	16
nc	6
nop	1

<?php

namespace whm\Smoke\Rules\Html;

use whm\Smoke\Http\Response;
use whm\Smoke\Rules\StandardRule;
use Symfony\Component\CssSelector\CssSelectorConverter;
use whm\Smoke\Rules\ValidationFailedException;

/**
 * This rule checks if xpath is found in a html document.
 */
class CssSelectorExistsRule extends StandardRule
{
    protected $contentTypes = ['text/html'];

    private $cssSelectors;

    public function init(array $cssSelectors)
    {
        $this->cssSelectors = $cssSelectors;
    }

    public function doValidation(Response $response)
    {
        $domDocument = new \DOMDocument();
        @$domDocument->loadHTML((string) $response->getBody());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $domXPath = new \DOMXPath($domDocument);

        $error = false;
        $snotFoundSelectors = array();

        foreach ($this->cssSelectors as $selector) {
            $converter = new CssSelectorConverter();
            $selectorAsXPath = $converter->toXPath($selector['pattern']);

            $count = $domXPath->query($selectorAsXPath)->length;

            if ($count == 0) {
                $error = true;
                $snotFoundSelectors[] = $selector['pattern'];
            }
        }

        if ($error === true) {
            $allNotFoundSelectors = implode('", "', $snotFoundSelectors);

            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors .'" not found in DOM.');
        }
    }
}


1			<?php
2
3			namespace whm\Smoke\Rules\Html;
4
5			use whm\Smoke\Http\Response;
6			use whm\Smoke\Rules\StandardRule;
7			use Symfony\Component\CssSelector\CssSelectorConverter;
8			use whm\Smoke\Rules\ValidationFailedException;
9
10			/**
11			* This rule checks if xpath is found in a html document.
12			*/
13			class CssSelectorExistsRule extends StandardRule
14			{
15			protected $contentTypes = ['text/html'];
16
17			private $cssSelectors;
18
19			public function init(array $cssSelectors)
20			{
21			$this->cssSelectors = $cssSelectors;
22			}
23
24			public function doValidation(Response $response)
25			{
26			$domDocument = new \DOMDocument();
27			@$domDocument->loadHTML((string) $response->getBody());
			0 ignored issues – show Security Best Practice introduced 2016-10-10 15:35 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
28
29			$domXPath = new \DOMXPath($domDocument);
30
31			$error = false;
32			$snotFoundSelectors = array();
33
34			foreach ($this->cssSelectors as $selector) {
35			$converter = new CssSelectorConverter();
36			$selectorAsXPath = $converter->toXPath($selector['pattern']);
37
38			$count = $domXPath->query($selectorAsXPath)->length;
39
40			if ($count == 0) {
41			$error = true;
42			$snotFoundSelectors[] = $selector['pattern'];
43			}
44			}
45
46			if ($error === true) {
47			$allNotFoundSelectors = implode('", "', $snotFoundSelectors);
48
49			throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors .'" not found in DOM.');
50			}
51			}
52			}
53

phmLabs / Smoke

Pull Request — master (#92)

CssSelectorExistsRule::doValidation() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like