phmLabs / Smoke

src/Rules/Xml/XmlValidXsdRule.php

Spacing +2 added lines, -2 removed lines

@@ -39,12 +39,12 @@
                 $error = true;
                 $lastError = libxml_get_last_error();
 
-                $messageParts[] = $xsdFile['xsdfilename'] . ' - ' . $xsdFile['xsdfileurl'] . '(last error: ' . str_replace("\n", '', $lastError->message) . ').';
+                $messageParts[] = $xsdFile['xsdfilename'].' - '.$xsdFile['xsdfileurl'].'(last error: '.str_replace("\n", '', $lastError->message).').';
             }
         }
 
         if ($error === true) {
-            $message = 'XML file (' . $filename . ')  does not validate against the following XSD files: ' . implode(', ', $messageParts);
+            $message = 'XML file ('.$filename.')  does not validate against the following XSD files: '.implode(', ', $messageParts);
             throw new ValidationFailedException($message);
         }
     }

src/Rules/Html/ClosingHtmlTagRule.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
     {
         if (($response->getStatus() < 300 || $response->getStatus() >= 400) && $response->getContentType() === 'text/html') {
             if (stripos($response->getBody(), '</html>') === false) {
-                throw new ValidationFailedException('Closing html tag is missing (document lengh: ' . strlen($response->getBody()) . ').');
+                throw new ValidationFailedException('Closing html tag is missing (document lengh: '.strlen($response->getBody()).').');
             }
         }
     }

src/Rules/Seo/RobotsDisallowAllRule.php

Doc Comments +3 added lines

@@ -49,6 +49,9 @@
         }
     }
 
+    /**
+     * @param string $content
+     */
     private function normalizeContent($content)
     {
         $normalizedContent = strtolower($content);

Spacing +4 added lines, -4 removed lines

@@ -20,12 +20,12 @@ 
 
     public function validate(Response $response)
     {
-        $url = $response->getUri()->getScheme() . '://' . $response->getUri()->getHost();
+        $url = $response->getUri()->getScheme().'://'.$response->getUri()->getHost();
 
         if (substr_count($url, '/') === 2) {
-            $filename = $robotsUrl = $url . '/robots.txt';
+            $filename = $robotsUrl = $url.'/robots.txt';
         } elseif (substr_count($url, '/') === 3) {
-            $filename = $robotsUrl = $url . 'robots.txt';
+            $filename = $robotsUrl = $url.'robots.txt';
         } else {
             return;
         }
@@ -40,7 +40,7 @@ 
 
         $normalizedContent = $this->normalizeContent($content);
 
-        if (strpos($normalizedContent, 'user-agent:* disallow:/' . PHP_EOL) !== false) {
+        if (strpos($normalizedContent, 'user-agent:* disallow:/'.PHP_EOL) !== false) {
             throw new ValidationFailedException('The robots.txt contains disallow all (Disallow: /)');
         }
 

src/Extensions/SmokeReporter/Reporter/StandardCliReporter.php

Doc Comments +3 added lines

@@ -72,6 +72,9 @@
         $this->output->writeln('');
     }
 
+    /**
+     * @param integer $ruleKey
+     */
     private function getFailedUrls($ruleKey)
     {
         $failedUrls = array();

Spacing +6 added lines, -6 removed lines

@@ -81,11 +81,11 @@ 
                 /** @var CheckResult $result */
                 if ($result->getStatus() === CheckResult::STATUS_FAILURE) {
                     if ($ruleKey === $key) {
-                        $failedUrls[] = (string) $result->getResponse()->getUri() . ' - ' . $result->getMessage();
+                        $failedUrls[] = (string) $result->getResponse()->getUri().' - '.$result->getMessage();
                         ++$count;
                     }
                     if ($count > $this->maxResults) {
-                        $failedUrls[] = '... only the first ' . $this->maxResults . ' elements are shown.';
+                        $failedUrls[] = '... only the first '.$this->maxResults.' elements are shown.';
                         break;
                     }
                 }
@@ -104,15 +104,15 @@ 
             $failedUrls = $this->getFailedUrls($ruleKey);
 
             if (count($failedUrls) > 0) {
-                $this->output->writeln('  <error> ' . get_class($rule) . ' </error>');
+                $this->output->writeln('  <error> '.get_class($rule).' </error>');
             } else {
-                $this->output->writeln('  <info> ' . get_class($rule) . ' </info>');
+                $this->output->writeln('  <info> '.get_class($rule).' </info>');
             }
 
-            $this->output->writeln('   ' . str_replace("\n", "\n   ", $info['documentation']) . "\n");
+            $this->output->writeln('   '.str_replace("\n", "\n   ", $info['documentation'])."\n");
 
             foreach ($failedUrls as $failedUrl) {
-                $this->output->writeln('   - ' . $failedUrl);
+                $this->output->writeln('   - '.$failedUrl);
             }
 
             $this->output->writeln('');

src/Extensions/SmokeReporter/Reporter/CliReporter.php

Spacing +3 added lines, -3 removed lines

@@ -30,13 +30,13 @@
 
     protected function renderFailure(CheckResult $result)
     {
-        $this->output->writeln('   <error> ' . (string) $result->getResponse()->getUri() . ' </error> coming from ' . (string) $this->retriever->getComingFrom($result->getResponse()->getUri()));
-        $this->output->writeln('    - ' . $result->getMessage() . ' [rule: ' . $result->getRuleName() . ']');
+        $this->output->writeln('   <error> '.(string) $result->getResponse()->getUri().' </error> coming from '.(string) $this->retriever->getComingFrom($result->getResponse()->getUri()));
+        $this->output->writeln('    - '.$result->getMessage().' [rule: '.$result->getRuleName().']');
         $this->output->writeln('');
     }
 
     protected function renderSuccess(CheckResult $result)
     {
-        $this->output->writeln('   <info> ' . (string) $result->getResponse()->getUri() . ' </info> all tests passed');
+        $this->output->writeln('   <info> '.(string) $result->getResponse()->getUri().' </info> all tests passed');
     }
 }

src/Extensions/SmokeResponseRetriever/Retriever/Koalamon/Retriever.php

Doc Comments +5 added lines

@@ -43,6 +43,11 @@
         return json_decode($systems->getBody(), true);
     }
 
+    /**
+     * @param string $url
+     *
+     * @return string
+     */
     private function prepareUrl($url)
     {
         $preparedUrl = str_replace('#project#', $this->project, $url);

src/Rules/Json/JsonPathExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -73,17 +73,17 @@
 
             if ($jsonValue === false || (is_array($jsonValue) && empty($jsonValue))) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (JSON Path not found)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (JSON Path not found)';
             }
             if ($this->checkRelation($path['relation'], $path['value'], $count) === false) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (number of JSONPaths is not correct corresponding to the given relation/value)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (number of JSONPaths is not correct corresponding to the given relation/value)';
             }
         }
 
         if ($error === true) {
             $allNoCorrectJsonPaths = implode('", "', $noCorrectJsonPaths);
-            throw new ValidationFailedException('Disonances with JSON Paths "' . $allNoCorrectJsonPaths . '!');
+            throw new ValidationFailedException('Disonances with JSON Paths "'.$allNoCorrectJsonPaths.'!');
         }
     }
 }

src/Rules/Html/XPathExistsRule.php

Spacing +4 added lines, -4 removed lines

@@ -31,15 +31,15 @@
 
             if ($xpath['relation'] === 'equals') {
                 $result = $count === (int) $xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
             } elseif ($xpath['relation'] === 'less than') {
                 $result = $count < (int) $xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
             } elseif ($xpath['relation'] === 'greater than') {
                 $result = $count > (int) $xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
             } else {
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
             }
 
             $this->assert($result, $message);

src/Rules/Http/HttpsCertificateAuthorityRule.php

Spacing +2 added lines, -2 removed lines

@@ -23,10 +23,10 @@
     {
         if (array_key_exists('issuer', $certInfo) and array_key_exists('CN', $certInfo['issuer'])) {
             if ($certInfo['issuer']['CN'] !== $this->authorityName) {
-                throw new ValidationFailedException('Expected authority was "' . $this->authorityName . '", "' . $certInfo['issuer']['CN'] . '" found.');
+                throw new ValidationFailedException('Expected authority was "'.$this->authorityName.'", "'.$certInfo['issuer']['CN'].'" found.');
             }
         } else {
-            throw new ValidationFailedException('Expected authority was "' . $this->authorityName . '". No authority found.');
+            throw new ValidationFailedException('Expected authority was "'.$this->authorityName.'". No authority found.');
         }
     }
 }