phmLabs / Smoke

src/Rules/Html/ResourcesCountRule.php

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
 
     public function init($maxElements = 200)
     {
-        $this->maxElements = (int)$maxElements;
+        $this->maxElements = (int) $maxElements;
     }
 
     protected function doValidation(ResponseInterface $response)
@@ -28,12 +28,12 @@ 
         if ($response instanceof ResourcesAwareResponse) {
             $resourceCount = count($response->getResources());
             if ($resourceCount > $this->maxElements) {
-                $message = 'Too many resources were loaded. ' . $resourceCount . ' resources loaded, maximum was ' . $this->maxElements . '.';
+                $message = 'Too many resources were loaded. '.$resourceCount.' resources loaded, maximum was '.$this->maxElements.'.';
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $message, $resourceCount);
                 $result->addAttribute(new Attribute('resources', $response->getResources(), true));
                 return $result;
             } else {
-                $message = $resourceCount . ' resources were loaded.';
+                $message = $resourceCount.' resources were loaded.';
                 return new CheckResult(CheckResult::STATUS_SUCCESS, $message, $resourceCount);
             }
         } else {

src/Rules/Xml/XmlValidXsdRule.php

Spacing +3 added lines, -3 removed lines

@@ -22,7 +22,7 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         $dom = new \DOMDocument();
         @$dom->loadXML($body);
@@ -37,12 +37,12 @@ 
                 $error = true;
                 $lastError = libxml_get_last_error();
 
-                $messageParts[] = $xsdFile['xsdfilename'] . ' - ' . $xsdFile['xsdfileurl'] . ' (last error: ' . str_replace("\n", '', $lastError->message) . ').';
+                $messageParts[] = $xsdFile['xsdfilename'].' - '.$xsdFile['xsdfileurl'].' (last error: '.str_replace("\n", '', $lastError->message).').';
             }
         }
 
         if ($error === true) {
-            $message = 'XML file (' . (string)$response->getUri() . ')  does not validate against the following XSD files: ' . implode(', ', $messageParts);
+            $message = 'XML file ('.(string) $response->getUri().')  does not validate against the following XSD files: '.implode(', ', $messageParts);
             throw new ValidationFailedException($message);
         }
     }

src/Rules/Json/JsonPathExistsRule.php

Spacing +5 added lines, -5 removed lines

@@ -54,7 +54,7 @@ 
 
     public function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         $json = json_decode($body);
 
@@ -73,17 +73,17 @@ 
 
             if ($jsonValue === false || (is_array($jsonValue) && empty($jsonValue))) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (JSON path not found)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (JSON path not found)';
             }
-            if ($this->checkRelation($path['relation'], (int)$path['value'], $count) === false) {
+            if ($this->checkRelation($path['relation'], (int) $path['value'], $count) === false) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (' . $count . ' elements found, expected ' . $path['relation'] . ' ' . $path['value'] . ')';
+                $noCorrectJsonPaths[] = $path['pattern'].' ('.$count.' elements found, expected '.$path['relation'].' '.$path['value'].')';
             }
         }
 
         if ($error === true) {
             $allNoCorrectJsonPaths = implode('", "', $noCorrectJsonPaths);
-            throw new ValidationFailedException('Disonances with JSON Paths "' . $allNoCorrectJsonPaths . '!');
+            throw new ValidationFailedException('Disonances with JSON Paths "'.$allNoCorrectJsonPaths.'!');
         }
     }
 }

src/Rules/Html/InsecureContentRule.php

Spacing +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@ 
             return;
         }
 
-        $htmlDocument = new Document((string)$response->getBody());
+        $htmlDocument = new Document((string) $response->getBody());
 
         $resources = $htmlDocument->getDependencies($uri, false);
 
@@ -46,7 +46,7 @@ 
             if ($resource->getScheme() && 'https' !== $resource->getScheme()) {
                 $excluded = false;
                 foreach ($this->excludedFiles as $excludedFile) {
-                    if (preg_match('*' . $excludedFile . '*', (string)$resource)) {
+                    if (preg_match('*'.$excludedFile.'*', (string) $resource)) {
                         $excluded = true;
                         break;
                     }
@@ -60,7 +60,7 @@ 
         if (count($unsecures) > 0) {
             $message = 'At least one dependency was found on a secure url, that was transfered insecure.<ul>';
             foreach ($unsecures as $unsecure) {
-                $message .= '<li>' . (string)$unsecure . '</li>';
+                $message .= '<li>'.(string) $unsecure.'</li>';
             }
             $message .= '</ul>';
             return new CheckResult(CheckResult::STATUS_FAILURE, $message, count($unsecures));

src/Rules/Xml/Rss/ValidRule.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace whm\Smoke\Rules\Xml\Rss;
 
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\StandardRule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Spacing +6 added lines, -6 removed lines

@@ -18,12 +18,12 @@ 
 
     private function getSchema()
     {
-        return __DIR__ . '/' . self::SCHEMA;
+        return __DIR__.'/'.self::SCHEMA;
     }
 
     public function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
         if (preg_match('/<rss/', $body)) {
             libxml_clear_errors();
             $dom = new \DOMDocument();
@@ -31,16 +31,16 @@ 
             $lastError = libxml_get_last_error();
             if ($lastError) {
                 throw new ValidationFailedException(
-                    'The given xml file is not well formed (last error: ' .
-                    str_replace("\n", '', $lastError->message) . ').');
+                    'The given xml file is not well formed (last error: '.
+                    str_replace("\n", '', $lastError->message).').');
             }
             $valid = @$dom->schemaValidate($this->getSchema());
             if (!$valid) {
                 $lastError = libxml_get_last_error();
                 $lastErrorMessage = str_replace("\n", '', $lastError->message);
                 throw new ValidationFailedException(
-                    'The given xml file is not a valid rss file (last error: ' .
-                    $lastErrorMessage . ').');
+                    'The given xml file is not a valid rss file (last error: '.
+                    $lastErrorMessage.').');
             }
         }
     }

src/Rules/CheckResult.php

Doc Comments +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
     }
 
     /**
-     * @param array $attributes
+     * @param array $attribute
      */
     public function addAttribute(Attribute $attribute)
     {
@@ -68,7 +68,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getMessage()
     {

src/Rules/Http/HttpsCertificateExpireRule.php

Spacing +4 added lines, -4 removed lines

@@ -31,7 +31,7 @@ 
         } else {
 
             if ($certInfo['validFrom_time_t'] > time() || $certInfo['validTo_time_t'] < time()) {
-                $errorMessage = 'Certificate is expired. [' . $validFrom . ' - ' . $validTo . ']';
+                $errorMessage = 'Certificate is expired. ['.$validFrom.' - '.$validTo.']';
 
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $errorMessage);
                 $infoJson = json_encode($certInfo);
@@ -41,8 +41,8 @@ 
                     $result->addAttribute(new Attribute('certificate information', $infoJson, true));
                 }
                 return $result;
-            } elseif ($certInfo['validTo_time_t'] < strtotime('+' . $this->expireWarningTime . 'days')) {
-                $errorMessage = 'Certificate warning, expires in less than ' . $this->expireWarningTime . ' days. Certificate expires at: ' . $validTo;
+            } elseif ($certInfo['validTo_time_t'] < strtotime('+'.$this->expireWarningTime.'days')) {
+                $errorMessage = 'Certificate warning, expires in less than '.$this->expireWarningTime.' days. Certificate expires at: '.$validTo;
 
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $errorMessage);
                 $result->addAttribute(new Attribute('certificate information', json_encode($certInfo), true));
@@ -50,6 +50,6 @@ 
             }
         }
 
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'The certificate does not expire within the next ' . $this->expireWarningTime . ' days. Expire date: ' . $validTo . '.');
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'The certificate does not expire within the next '.$this->expireWarningTime.' days. Expire date: '.$validTo.'.');
     }
 }

src/Extensions/SmokeResponseRetriever/Retriever/ListRetriever/Retriever.php

Spacing +11 added lines, -11 removed lines

@@ -49,7 +49,7 @@ 
                     } else {
                         $uri = new Uri($url);
                     }
-                    $this->urls[(string)$uri] = ['url' => $uri, 'system' => $key];
+                    $this->urls[(string) $uri] = ['url' => $uri, 'system' => $key];
                 }
             }
             $this->urlStack = $this->urls;
@@ -109,20 +109,20 @@ 
                     if (strpos($corruptUrl, '/') === 0) {
 
                         $mainUri = $request->getUri();
-                        $this->redirects[(string)$mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl] = (string)$mainUri;
+                        $this->redirects[(string) $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl] = (string) $mainUri;
 
-                        $this->urls[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
-                        $this->urlStack[] = ['url' => $mainUri->getScheme() . '://' . $mainUri->getHost() . $corruptUrl, 'system' => $url['system']];
+                        $this->urls[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
+                        $this->urlStack[] = ['url' => $mainUri->getScheme().'://'.$mainUri->getHost().$corruptUrl, 'system' => $url['system']];
 
                         return $this->next();
                     }
 
                     // the error handling should be done withing the calling class
-                    echo "\n   " . $exception->getMessage() . "\n";
+                    echo "\n   ".$exception->getMessage()."\n";
 
                     return $this->next();
                 } else {
-                    $errorMessages .= $exception->getMessage() . "\n";
+                    $errorMessages .= $exception->getMessage()."\n";
                 }
             }
             if ($errorMessages !== '') {
@@ -139,8 +139,8 @@ 
 
     public function getOriginUri(UriInterface $uri)
     {
-        if (array_key_exists((string)$uri, $this->redirects)) {
-            return $this->urls[$this->redirects[(string)$uri]]['url'];
+        if (array_key_exists((string) $uri, $this->redirects)) {
+            return $this->urls[$this->redirects[(string) $uri]]['url'];
         }
 
         return $uri;
@@ -153,11 +153,11 @@ 
 
     public function getSystem(UriInterface $uri)
     {
-        if (array_key_exists((string)$uri, $this->redirects)) {
-            return $this->urls[$this->redirects[(string)$uri]]['system'];
+        if (array_key_exists((string) $uri, $this->redirects)) {
+            return $this->urls[$this->redirects[(string) $uri]]['system'];
         }
 
-        return $this->urls[(string)$uri]['system'];
+        return $this->urls[(string) $uri]['system'];
     }
 
     public function getSystems()

src/Extensions/SmokeFilter/FilterExtension.php

Spacing +5 added lines, -5 removed lines

@@ -42,12 +42,12 @@ 
     public function init($filters = array(), $filterFile = '', $exclusive = array())
     {
         if (count($exclusive) > 0 && (count($filters) > 0 || $filterFile !== '')) {
-            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: " . get_class($this) . '].');
+            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: ".get_class($this).'].');
         }
 
         if ($filterFile !== '') {
             if (!file_exists($filterFile)) {
-                throw new \RuntimeException('Filter file not found: ' . $filterFile);
+                throw new \RuntimeException('Filter file not found: '.$filterFile);
             }
 
             $filterElements = EnvAwareYaml::parse(file_get_contents($filterFile));
@@ -72,7 +72,7 @@ 
                 if (is_array($urls)) {
                     foreach ($urls as $url) {
                         $uri = new Uri($url);
-                        $this->exclusives[$rule][] = (string)$uri;
+                        $this->exclusives[$rule][] = (string) $uri;
                     }
                 }
             }
@@ -93,7 +93,7 @@ 
      */
     public function isFiltered(Event $event, $ruleName, UriAwareResponse $response)
     {
-        $uri = (string)$this->retriever->getOriginUri($response->getUri());
+        $uri = (string) $this->retriever->getOriginUri($response->getUri());
 
         if ($this->currentModus === self::MODUS_FILTER) {
             $isFiltered = $this->isFilteredByFilter($ruleName, $uri);
@@ -112,7 +112,7 @@ 
     private function isFilteredByFilter($ruleName, $uri)
     {
         foreach ($this->filters as $filter) {
-            if ($ruleName === $filter['rule'] && 0 < preg_match('$' . $filter['uri'] . '$', $uri)) {
+            if ($ruleName === $filter['rule'] && 0 < preg_match('$'.$filter['uri'].'$', $uri)) {
                 return true;
             }
         }