Completed
Push — master ( 036c01...8ec94e )
by Nils
02:11
created
src/Rules/Seo/GoogleMobileFriendlyRule.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 
15 15
     private function getEndpoint(Uri $uri)
16 16
     {
17
-        return str_replace('#url#', urlencode((string)$uri), self::ENDPOINT);
17
+        return str_replace('#url#', urlencode((string) $uri), self::ENDPOINT);
18 18
     }
19 19
 
20 20
     public function validate(ResponseInterface $response)
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
             )));
34 34
 
35 35
         if (property_exists($result, 'error')) {
36
-            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
36
+            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
37 37
             $checkResult->addAttribute(new Attribute('Google response', json_encode($result), true));
38 38
             return $checkResult;
39 39
         }
@@ -41,9 +41,9 @@  discard block
 block discarded – undo
41 41
         $passResult = $result->ruleGroups->USABILITY;
42 42
 
43 43
         if (!$passResult->pass) {
44
-            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
44
+            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
45 45
         }
46 46
 
47
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
47
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
48 48
     }
49 49
 }
Please login to merge, or discard this patch.
src/Rules/Xml/Sitemap/ValidRule.php 2 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -27,6 +27,9 @@  discard block
 block discarded – undo
27 27
         $this->strictMode = $strictMode;
28 28
     }
29 29
 
30
+    /**
31
+     * @param boolean $isIndex
32
+     */
30 33
     private function getSchema($isIndex)
31 34
     {
32 35
         if ($isIndex) {
@@ -40,6 +43,10 @@  discard block
 block discarded – undo
40 43
         }
41 44
     }
42 45
 
46
+    /**
47
+     * @param string $body
48
+     * @param string $filename
49
+     */
43 50
     private function validateBody($body, $filename, $isIndex = true)
44 51
     {
45 52
         $dom = new \DOMDocument();
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -30,13 +30,13 @@  discard block
 block discarded – undo
30 30
     private function getSchema($isIndex)
31 31
     {
32 32
         if ($isIndex) {
33
-            return __DIR__ . '/' . self::INDEX;
33
+            return __DIR__.'/'.self::INDEX;
34 34
         }
35 35
 
36 36
         if ($this->strictMode) {
37
-            return __DIR__ . '/' . self::SCHEMA;
37
+            return __DIR__.'/'.self::SCHEMA;
38 38
         } else {
39
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
39
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
40 40
         }
41 41
     }
42 42
 
@@ -50,19 +50,19 @@  discard block
 block discarded – undo
50 50
         if (!$valid) {
51 51
             $lastError = libxml_get_last_error();
52 52
             throw new ValidationFailedException(
53
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
53
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
54 54
         }
55 55
     }
56 56
 
57 57
     protected function doValidation(ResponseInterface $response)
58 58
     {
59
-        $body = (string)$response->getBody();
59
+        $body = (string) $response->getBody();
60 60
 
61 61
         // sitemapindex or urlset
62 62
         if (preg_match('/<sitemapindex/', $body)) {
63
-            $this->validateBody($body, (string)$response->getUri());
63
+            $this->validateBody($body, (string) $response->getUri());
64 64
         } elseif (preg_match('/<urlset/', $body)) {
65
-            $this->validateBody($body, (string)$response->getUri(), false);
65
+            $this->validateBody($body, (string) $response->getUri(), false);
66 66
         }
67 67
     }
68 68
 }
Please login to merge, or discard this patch.
src/Rules/Xml/DuplicateIdRule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
             return;
19 19
         }
20 20
 
21
-        $crawler = new Crawler((string)$response->getBody());
21
+        $crawler = new Crawler((string) $response->getBody());
22 22
 
23 23
         $idList = $crawler->filterXPath('//*[@id!=""]');
24 24
 
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         if (count($duplicatedIds) > 0) {
38 38
             unset($duplicatedIds['']);
39
-            throw new ValidationFailedException('Duplicate ids found (' . implode(', ', array_keys($duplicatedIds)) . ')');
39
+            throw new ValidationFailedException('Duplicate ids found ('.implode(', ', array_keys($duplicatedIds)).')');
40 40
         }
41 41
     }
42 42
 }
Please login to merge, or discard this patch.
src/Rules/Json/ValidRule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,9 +26,9 @@
 block discarded – undo
26 26
 
27 27
     public function doValidation(ResponseInterface $response)
28 28
     {
29
-        $result = json_decode((string)$response->getBody());
29
+        $result = json_decode((string) $response->getBody());
30 30
         if ($result === null) {
31
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
31
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
32 32
         }
33 33
     }
34 34
 }
Please login to merge, or discard this patch.
src/Rules/Html/ForeignDomainImageRule.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
     protected function doValidation(ResponseInterface $response)
28 28
     {
29
-        $document = new Document((string)$response->getBody());
29
+        $document = new Document((string) $response->getBody());
30 30
         $images = $document->getImages($response->getUri());
31 31
 
32 32
         $foreignImages = array();
@@ -37,10 +37,10 @@  discard block
 block discarded – undo
37 37
         foreach ($images as $image) {
38 38
             /* @var $image Uri */
39 39
             if ($currentUri->getHost($this->depth) !== $image->getHost($this->depth)) {
40
-                $foreignImages[] = (string)$image;
40
+                $foreignImages[] = (string) $image;
41 41
             }
42 42
         }
43 43
 
44
-        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found (' . implode(', ', $foreignImages) . ')');
44
+        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found ('.implode(', ', $foreignImages).')');
45 45
     }
46 46
 }
Please login to merge, or discard this patch.
src/Rules/Html/SizeRule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
 
26 26
     protected function doValidation(ResponseInterface $response)
27 27
     {
28
-        $size = strlen((string)$response->getBody()) / 1000;
29
-        $this->assert($size <= $this->maxSize, 'The size of this html file is too big (' . $size . ' KB)');
28
+        $size = strlen((string) $response->getBody()) / 1000;
29
+        $this->assert($size <= $this->maxSize, 'The size of this html file is too big ('.$size.' KB)');
30 30
     }
31 31
 }
Please login to merge, or discard this patch.
src/Rules/Html/StringNotExistsRule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 
25 25
     public function doValidation(ResponseInterface $response)
26 26
     {
27
-        $this->assert(strpos((string)$response->getBody(), $this->string) !== false,
28
-            'The given string (' . $this->string . ') was found in this document.');
27
+        $this->assert(strpos((string) $response->getBody(), $this->string) !== false,
28
+            'The given string ('.$this->string.') was found in this document.');
29 29
     }
30 30
 }
Please login to merge, or discard this patch.
src/Rules/Html/StringExistsRule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 
25 25
     protected function doValidation(ResponseInterface $response)
26 26
     {
27
-        $this->assert(strpos((string)$response->getBody(), $this->string) !== false,
28
-            'The given string (' . $this->string . ') was not found in this document.');
27
+        $this->assert(strpos((string) $response->getBody(), $this->string) !== false,
28
+            'The given string ('.$this->string.') was not found in this document.');
29 29
     }
30 30
 }
Please login to merge, or discard this patch.
src/Rules/Html/NoIndexRule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
             return;
21 21
         }
22 22
 
23
-        $crawler = new Crawler((string)$response->getBody());
23
+        $crawler = new Crawler((string) $response->getBody());
24 24
         $metaTags = $crawler->filterXPath("//meta[@name='robots']/@content");
25 25
 
26 26
         foreach ($metaTags as $metaTag) {
Please login to merge, or discard this patch.