RedirectRule - Code Metrics - Inspection of "RedirectRule" - phmLabs/Smoke - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 13acd2...446f84 )

by Nils

created 2017-08-19 19:22 UTC

RedirectRule A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	5
dl	0
loc	38
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	4	1
B	validate()	0	28	5

<?php

namespace whm\Smoke\Rules\Http;

use GuzzleHttp\Psr7\Request;
use phm\HttpWebdriverClient\Http\Client\Guzzle\GuzzleClient;
use Psr\Http\Message\ResponseInterface;
use whm\Html\Uri;
use whm\Smoke\Rules\CheckResult;
use whm\Smoke\Rules\Rule;

/**
 * This rule can validate if a http request takes longer than a given max duration.
 * A website that is slower than one second is considered as slow.
 */
class RedirectRule implements Rule
{
    private $urls;

    public function init($redirectedUrls)
    {
        $this->urls = $redirectedUrls;
    }

    public function validate(ResponseInterface $response)
    {
        $client = new GuzzleClient();
        $errors = [];

        foreach ($this->urls as $url) {
            $uri = new Uri($url['url']);

            $urlResponses = $client->sendRequests([new Request('GET', $uri)]);
            $effectiveUrl = (string)$urlResponses[0]->getEffectiveUri();

            if ($effectiveUrl != (string)$response->getUri()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $errors[] = 'The url "' . $url['url'] . '" gets redirected to "' . $effectiveUrl . '".';
            }
        }

        if (count($errors) > 0) {
            $message = 'Not all given urls do redirect to "' . (string)$response->getUri() . '"".<ul>';
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            foreach ($errors as $error) {
                $message .= '<li>' . $error . '</li>';
            }
            $message .= "</ul>";

            return new CheckResult(CheckResult::STATUS_FAILURE, $message);
        } else {
            return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to ' . (string)$response->getUri());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
    }
}


Push — master ( 13acd2...446f84 )

RedirectRule A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace whm\Smoke\Rules\Http;
4
5			use GuzzleHttp\Psr7\Request;
6			use phm\HttpWebdriverClient\Http\Client\Guzzle\GuzzleClient;
7			use Psr\Http\Message\ResponseInterface;
8			use whm\Html\Uri;
9			use whm\Smoke\Rules\CheckResult;
10			use whm\Smoke\Rules\Rule;
11
12			/**
13			* This rule can validate if a http request takes longer than a given max duration.
14			* A website that is slower than one second is considered as slow.
15			*/
16			class RedirectRule implements Rule
17			{
18			private $urls;
19
20			public function init($redirectedUrls)
21			{
22			$this->urls = $redirectedUrls;
23			}
24
25			public function validate(ResponseInterface $response)
26			{
27			$client = new GuzzleClient();
28			$errors = [];
29
30			foreach ($this->urls as $url) {
31			$uri = new Uri($url['url']);
32
33			$urlResponses = $client->sendRequests([new Request('GET', $uri)]);
34			$effectiveUrl = (string)$urlResponses[0]->getEffectiveUri();
35
36			if ($effectiveUrl != (string)$response->getUri()) {
			0 ignored issues – show Bug introduced 2017-08-19 19:24 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\ResponseInterface` as the method `getUri()` does only exist in the following implementations of said interface: `phm\HttpWebdriverClient\...t\Chrome\ChromeResponse`, `phm\HttpWebdriverClient\...t\Guzzle\GuzzleResponse`, `phm\HttpWebdriverClient\...\Client\Guzzle\Response`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
37			$errors[] = 'The url "' . $url['url'] . '" gets redirected to "' . $effectiveUrl . '".';
38			}
39			}
40
41			if (count($errors) > 0) {
42			$message = 'Not all given urls do redirect to "' . (string)$response->getUri() . '"".<ul>';
			0 ignored issues – show Bug introduced 2017-08-19 19:24 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\ResponseInterface` as the method `getUri()` does only exist in the following implementations of said interface: `phm\HttpWebdriverClient\...t\Chrome\ChromeResponse`, `phm\HttpWebdriverClient\...t\Guzzle\GuzzleResponse`, `phm\HttpWebdriverClient\...\Client\Guzzle\Response`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
43			foreach ($errors as $error) {
44			$message .= '<li>' . $error . '</li>';
45			}
46			$message .= "</ul>";
47
48			return new CheckResult(CheckResult::STATUS_FAILURE, $message);
49			} else {
50			return new CheckResult(CheckResult::STATUS_SUCCESS, 'All given urls redirect to ' . (string)$response->getUri());
			0 ignored issues – show Bug introduced 2017-08-19 19:24 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\ResponseInterface` as the method `getUri()` does only exist in the following implementations of said interface: `phm\HttpWebdriverClient\...t\Chrome\ChromeResponse`, `phm\HttpWebdriverClient\...t\Guzzle\GuzzleResponse`, `phm\HttpWebdriverClient\...\Client\Guzzle\Response`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
51			}
52			}
53			}
54

phmLabs / Smoke

Push — master ( 13acd2...446f84 )

RedirectRule A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like