phmLabs / Smoke

src/Rules/Html/JsFileCountRule.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use whm\Html\Document;
-use whm\Smoke\Http\Response;
 
 /**
  * This rules counts the js files that are included in a document. If the number is higher

src/Rules/Image/FavIconRule.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace whm\Smoke\Rules\Image;
 
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\StandardRule;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -30,8 +30,8 @@
             return;
         }
 
-        $imageHash = md5((string)$response->getBody());
+        $imageHash = md5((string) $response->getBody());
 
-        $this->assert(!array_key_exists($imageHash, $this->favicons), 'Seems like you use the standard favicon of your framework (' . $this->favicons[$imageHash] . ').');
+        $this->assert(!array_key_exists($imageHash, $this->favicons), 'Seems like you use the standard favicon of your framework ('.$this->favicons[$imageHash].').');
     }
 }

src/Rules/Json/JsonSchema/JsonSchemaRule.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use JsonSchema\Validator;
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\StandardRule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Spacing +5 added lines, -5 removed lines

@@ -33,9 +33,9 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $data = json_decode((string)$response->getBody());
+        $data = json_decode((string) $response->getBody());
         if ($data === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         } else {
             $errorStatus = false;
             $messageParts = array();
@@ -51,14 +51,14 @@ 
                     $errorStatus = true;
                     $errorMessage = '';
                     foreach ($validator->getErrors() as $error) {
-                        $errorMessage = $errorMessage . sprintf("[%s] %s\n", $error['property'], $error['message']);
+                        $errorMessage = $errorMessage.sprintf("[%s] %s\n", $error['property'], $error['message']);
                     }
-                    $messageParts[] = $jsonSchemaFile['jsonfilename'] . ' - ' . $jsonSchemaFile['jsonfileurl'] . '(last error: ' . $errorMessage . ').';
+                    $messageParts[] = $jsonSchemaFile['jsonfilename'].' - '.$jsonSchemaFile['jsonfileurl'].'(last error: '.$errorMessage.').';
                 }
             }
 
             if ($errorStatus === true) {
-                $message = 'JSON file (' . (string) $response->getUri() . ')  does not validate against the following JSON Schema files: ' . implode(', ', $messageParts);
+                $message = 'JSON file ('.(string) $response->getUri().')  does not validate against the following JSON Schema files: '.implode(', ', $messageParts);
                 throw new ValidationFailedException($message);
             }
         }

src/Rules/Security/PasswordSecureTransferRule.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use Symfony\Component\DomCrawler\Crawler;
-use whm\Smoke\Http\Response;
-use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\StandardRule;
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -19,10 +19,10 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
         $actionNodes = $crawler->filterXPath('//form[//input[@type="password"]]');
 
-        $url = (string)$response->getUri();
+        $url = (string) $response->getUri();
 
         foreach ($actionNodes as $node) {
             $action = $node->getAttribute('action');
@@ -36,7 +36,7 @@ 
 
             while ($parent = $parent->parentNode) {
                 if (property_exists($parent, 'tagName')) {
-                    $fullPath = $parent->tagName . '/' . $fullPath;
+                    $fullPath = $parent->tagName.'/'.$fullPath;
                 } else {
                     break;
                 }

src/Rules/Seo/PageSpeedRule.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace whm\Smoke\Rules\Seo;
 
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\ValidationFailedException;
 

src/Rules/Seo/RobotsDisallowAllRule.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use Ivory\HttpAdapter\HttpAdapterInterface;
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\ClientAware;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Spacing +4 added lines, -4 removed lines

@@ -21,12 +21,12 @@ 
 
     public function validate(ResponseInterface $response)
     {
-        $url = $response->getUri()->getScheme() . '://' . $response->getUri()->getHost();
+        $url = $response->getUri()->getScheme().'://'.$response->getUri()->getHost();
 
         if (substr_count($url, '/') === 2) {
-            $filename = $robotsUrl = $url . '/robots.txt';
+            $filename = $robotsUrl = $url.'/robots.txt';
         } elseif (substr_count($url, '/') === 3) {
-            $filename = $robotsUrl = $url . 'robots.txt';
+            $filename = $robotsUrl = $url.'robots.txt';
         } else {
             return;
         }
@@ -39,7 +39,7 @@ 
 
         $normalizedContent = $this->normalizeContent($content);
 
-        if (strpos($normalizedContent, 'user-agent:* disallow:/' . PHP_EOL) !== false) {
+        if (strpos($normalizedContent, 'user-agent:* disallow:/'.PHP_EOL) !== false) {
             throw new ValidationFailedException('The robots.txt contains disallow all (Disallow: /)');
         }
 

src/Rules/StandardRule.php

Doc Comments +4 added lines

@@ -28,6 +28,10 @@
 
     abstract protected function doValidation(ResponseInterface $response);
 
+    /**
+     * @param boolean $valueToBeTrue
+     * @param string $errorMessage
+     */
     protected function assert($valueToBeTrue, $errorMessage)
     {
         if (!$valueToBeTrue) {

src/Rules/Xml/Sitemap/ValidRule.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace whm\Smoke\Rules\Xml\Sitemap;
 
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\StandardRule;
 use whm\Smoke\Rules\ValidationFailedException;
 

Doc Comments +7 added lines

@@ -27,6 +27,9 @@ 
         $this->strictMode = $strictMode;
     }
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         if ($isIndex) {
@@ -40,6 +43,10 @@ 
         }
     }
 
+    /**
+     * @param string $body
+     * @param string $filename
+     */
     private function validateBody($body, $filename, $isIndex = true)
     {
         $dom = new \DOMDocument();

Spacing +7 added lines, -7 removed lines

@@ -30,13 +30,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -50,19 +50,19 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 
     protected function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         // sitemapindex or urlset
         if (preg_match('/<sitemapindex/', $body)) {
-            $this->validateBody($body, (string)$response->getUri());
+            $this->validateBody($body, (string) $response->getUri());
         } elseif (preg_match('/<urlset/', $body)) {
-            $this->validateBody($body, (string)$response->getUri(), false);
+            $this->validateBody($body, (string) $response->getUri(), false);
         }
     }
 }

src/Extensions/SmokeFilter/FilterExtension.php

Spacing +4 added lines, -4 removed lines

@@ -41,12 +41,12 @@ 
     public function init($filters = array(), $filterFile = '', $exclusive = array())
     {
         if (count($exclusive) > 0 && (count($filters) > 0 || $filterFile !== '')) {
-            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: " . get_class($this) . '].');
+            throw new \RuntimeException("It's not possible to define filter lists and an exclusive list at the same time [Extension: ".get_class($this).'].');
         }
 
         if ($filterFile !== '') {
             if (!file_exists($filterFile)) {
-                throw new \RuntimeException('Filter file not found: ' . $filterFile);
+                throw new \RuntimeException('Filter file not found: '.$filterFile);
             }
 
             $filterElements = EnvAwareYaml::parse(file_get_contents($filterFile));
@@ -85,7 +85,7 @@ 
      */
     public function isFiltered(Event $event, $ruleName, UriAwareResponse $response)
     {
-        $uri = (string)$this->retriever->getOriginUri($response->getUri());
+        $uri = (string) $this->retriever->getOriginUri($response->getUri());
 
         if ($this->currentModus === self::MODUS_FILTER) {
             $isFiltered = $this->isFilteredByFilter($ruleName, $uri);
@@ -104,7 +104,7 @@ 
     private function isFilteredByFilter($ruleName, $uri)
     {
         foreach ($this->filters as $filter) {
-            if ($ruleName === $filter['rule'] && 0 < preg_match('$' . $filter['uri'] . '$', $uri)) {
+            if ($ruleName === $filter['rule'] && 0 < preg_match('$'.$filter['uri'].'$', $uri)) {
                 return true;
             }
         }