HttpsRule::validate() - Code Metrics - phmLabs/Smoke - Measure and Improve Code Quality continuously with Scrutinizer

HttpsRule::validate() A
last analyzed 2019-05-12 19:55 UTC

↳ Parent: HttpsRule

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace whm\Smoke\Rules\Http;

use Psr\Http\Message\ResponseInterface;
use whm\Smoke\Http\Response;
use whm\Smoke\Rules\Rule;

abstract class HttpsRule implements Rule
{
    public function validate(ResponseInterface $response)
    {
        if ('https' === $response->getUri()->getScheme()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $certInfo = $this->getCertifacateInformation($response->getUri()->getHost());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

            return $this->doValidate($certInfo);
        }
    }

    abstract protected function doValidate($certInfo);

    private function getCertifacateInformation($host)
    {
        $sslOptions = stream_context_create(array('ssl' => array('capture_peer_cert' => true)));

        $request = @stream_socket_client(
            'ssl://' . $host . ':443',
            $errno,
            $errstr,
            30,
            STREAM_CLIENT_CONNECT,
            $sslOptions
        );

        $content = @stream_context_get_params($request);

        $certInfo = openssl_x509_parse($content['options']['ssl']['peer_certificate']);

        return $certInfo;
    }
}


1			<?php
2
3			namespace whm\Smoke\Rules\Http;
4
5			use Psr\Http\Message\ResponseInterface;
6			use whm\Smoke\Http\Response;
7			use whm\Smoke\Rules\Rule;
8
9			abstract class HttpsRule implements Rule
10			{
11			public function validate(ResponseInterface $response)
12			{
13			if ('https' === $response->getUri()->getScheme()) {
			0 ignored issues – show Bug introduced 2018-12-28 01:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\ResponseInterface` as the method `getUri()` does only exist in the following implementations of said interface: `phm\HttpWebdriverClient\...t\Chrome\ChromeResponse`, `phm\HttpWebdriverClient\...t\Guzzle\GuzzleResponse`, `phm\HttpWebdriverClient\...\Client\Guzzle\Response`, `phm\HttpWebdriverClient\...esponse\BrowserResponse`, `whm\Smoke\Http\ConnectionRefusedResponse`, `whm\Smoke\Http\ErrorResponse`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
14			$certInfo = $this->getCertifacateInformation($response->getUri()->getHost());
			0 ignored issues – show Bug introduced 2018-12-28 01:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\ResponseInterface` as the method `getUri()` does only exist in the following implementations of said interface: `phm\HttpWebdriverClient\...t\Chrome\ChromeResponse`, `phm\HttpWebdriverClient\...t\Guzzle\GuzzleResponse`, `phm\HttpWebdriverClient\...\Client\Guzzle\Response`, `phm\HttpWebdriverClient\...esponse\BrowserResponse`, `whm\Smoke\Http\ConnectionRefusedResponse`, `whm\Smoke\Http\ErrorResponse`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
15
16			return $this->doValidate($certInfo);
17			}
18			}
19
20			abstract protected function doValidate($certInfo);
21
22			private function getCertifacateInformation($host)
23			{
24			$sslOptions = stream_context_create(array('ssl' => array('capture_peer_cert' => true)));
25
26			$request = @stream_socket_client(
27			'ssl://' . $host . ':443',
28			$errno,
29			$errstr,
30			30,
31			STREAM_CLIENT_CONNECT,
32			$sslOptions
33			);
34
35			$content = @stream_context_get_params($request);
36
37			$certInfo = openssl_x509_parse($content['options']['ssl']['peer_certificate']);
38
39			return $certInfo;
40			}
41			}
42

phmLabs / Smoke

HttpsRule::validate() A last analyzed 2019-05-12 19:55 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

HttpsRule::validate() A
last analyzed 2019-05-12 19:55 UTC