XPathExistsRule::doValidation() - Code Metrics - phmLabs/Smoke - Measure and Improve Code Quality continuously with Scrutinizer

XPathExistsRule::doValidation() B
last analyzed 2019-05-12 19:55 UTC

↳ Parent: XPathExistsRule

Complexity

Conditions	7
Paths	15

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	38
rs	8.3786
c	0
b	0
f	0
cc	7
nc	15
nop	1

<?php

namespace whm\Smoke\Rules\Html;

use phm\HttpWebdriverClient\Http\Response\DomAwareResponse;
use Psr\Http\Message\ResponseInterface;
use whm\Smoke\Rules\StandardRule;

/**
 * This rule checks if xpath is found in a html document.
 */
class XPathExistsRule extends StandardRule
{
    // protected $contentTypes = ['text/html'];
    private $xPaths;

    /**
     * @var boolean
     */
    private $useDom = true;

    public function init(array $xPaths, $useDom = true)
    {
        $this->xPaths = $xPaths;
        $this->useDom = $useDom;
    }

    public function doValidation(ResponseInterface $response)
    {
        $domDocument = new \DOMDocument();

        // @todo this could be part of an abstract class
        if ($this->useDom) {
            $content = (string)$response->getBody();
        } else {
            if ($response instanceof DomAwareResponse) {
                $content = $response->getHtmlBody();
            } else {
                $content = (string)$response->getBody();
            }
        }

        @$domDocument->loadHTML($content);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $domXPath = new \DOMXPath($domDocument);

        foreach ($this->xPaths as $xpath) {
            $count = $domXPath->query($xpath['pattern'])->length;

            if ($xpath['relation'] === 'equals') {
                $result = $count === (int)$xpath['value'];
                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
            } elseif ($xpath['relation'] === 'less than') {
                $result = $count < (int)$xpath['value'];
                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
            } elseif ($xpath['relation'] === 'greater than') {
                $result = $count > (int)$xpath['value'];
                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
            } else {
                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
            }

            $this->assert($result, $message);
        }
    }
}


1			<?php
2
3			namespace whm\Smoke\Rules\Html;
4
5			use phm\HttpWebdriverClient\Http\Response\DomAwareResponse;
6			use Psr\Http\Message\ResponseInterface;
7			use whm\Smoke\Rules\StandardRule;
8
9			/**
10			* This rule checks if xpath is found in a html document.
11			*/
12			class XPathExistsRule extends StandardRule
13			{
14			// protected $contentTypes = ['text/html'];
15			private $xPaths;
16
17			/**
18			* @var boolean
19			*/
20			private $useDom = true;
21
22			public function init(array $xPaths, $useDom = true)
23			{
24			$this->xPaths = $xPaths;
25			$this->useDom = $useDom;
26			}
27
28			public function doValidation(ResponseInterface $response)
29			{
30			$domDocument = new \DOMDocument();
31
32			// @todo this could be part of an abstract class
33			if ($this->useDom) {
34			$content = (string)$response->getBody();
35			} else {
36			if ($response instanceof DomAwareResponse) {
37			$content = $response->getHtmlBody();
38			} else {
39			$content = (string)$response->getBody();
40			}
41			}
42
43			@$domDocument->loadHTML($content);
			0 ignored issues – show Security Best Practice introduced 2018-01-04 19:25 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
44
45			$domXPath = new \DOMXPath($domDocument);
46
47			foreach ($this->xPaths as $xpath) {
48			$count = $domXPath->query($xpath['pattern'])->length;
49
50			if ($xpath['relation'] === 'equals') {
51			$result = $count === (int)$xpath['value'];
52			$message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
53			} elseif ($xpath['relation'] === 'less than') {
54			$result = $count < (int)$xpath['value'];
55			$message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
56			} elseif ($xpath['relation'] === 'greater than') {
57			$result = $count > (int)$xpath['value'];
58			$message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
59			} else {
60			throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
61			}
62
63			$this->assert($result, $message);
64			}
65			}
66			}
67

phmLabs / Smoke

XPathExistsRule::doValidation() B last analyzed 2019-05-12 19:55 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

XPathExistsRule::doValidation() B
last analyzed 2019-05-12 19:55 UTC