ForeignDomainImageRule::doValidation() - Code Metrics - phmLabs/Smoke - Measure and Improve Code Quality continuously with Scrutinizer

ForeignDomainImageRule::doValidation() A
last analyzed 2019-05-12 19:55 UTC

↳ Parent: ForeignDomainImageRule

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace whm\Smoke\Rules\Html;

use Psr\Http\Message\ResponseInterface;
use whm\Html\Document;
use whm\Html\Uri;
use whm\Smoke\Rules\StandardRule;

/**
 * This rules detects images that are not from the same domain as the request url.
 */
class ForeignDomainImageRule extends StandardRule
{
    private $depth;

    protected $contentTypes = array('text/html');

    /**
     * @param int $depth number of url parts that have to be the same
     */
    public function init($depth = 2)
    {
        $this->depth = $depth;
    }

    protected function doValidation(ResponseInterface $response)
    {
        $document = new Document((string)$response->getBody());
        $images = $document->getImages($response->getUri());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $foreignImages = array();

        /* @var $currentUri Uri */
        $currentUri = $response->getUri();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        foreach ($images as $image) {
            /* @var $image Uri */
            if ($currentUri->getHost($this->depth) !== $image->getHost($this->depth)) {
                $foreignImages[] = (string)$image;
            }
        }

        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found (' . implode(', ', $foreignImages) . ')');
    }
}


1			<?php
2
3			namespace whm\Smoke\Rules\Html;
4
5			use Psr\Http\Message\ResponseInterface;
6			use whm\Html\Document;
7			use whm\Html\Uri;
8			use whm\Smoke\Rules\StandardRule;
9
10			/**
11			* This rules detects images that are not from the same domain as the request url.
12			*/
13			class ForeignDomainImageRule extends StandardRule
14			{
15			private $depth;
16
17			protected $contentTypes = array('text/html');
18
19			/**
20			* @param int $depth number of url parts that have to be the same
21			*/
22			public function init($depth = 2)
23			{
24			$this->depth = $depth;
25			}
26
27			protected function doValidation(ResponseInterface $response)
28			{
29			$document = new Document((string)$response->getBody());
30			$images = $document->getImages($response->getUri());
			0 ignored issues – show Bug introduced 2018-12-28 01:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\ResponseInterface` as the method `getUri()` does only exist in the following implementations of said interface: `phm\HttpWebdriverClient\...t\Chrome\ChromeResponse`, `phm\HttpWebdriverClient\...t\Guzzle\GuzzleResponse`, `phm\HttpWebdriverClient\...\Client\Guzzle\Response`, `phm\HttpWebdriverClient\...esponse\BrowserResponse`, `whm\Smoke\Http\ConnectionRefusedResponse`, `whm\Smoke\Http\ErrorResponse`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
31
32			$foreignImages = array();
33
34			/* @var $currentUri Uri */
35			$currentUri = $response->getUri();
			0 ignored issues – show Bug introduced 2018-12-28 01:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\ResponseInterface` as the method `getUri()` does only exist in the following implementations of said interface: `phm\HttpWebdriverClient\...t\Chrome\ChromeResponse`, `phm\HttpWebdriverClient\...t\Guzzle\GuzzleResponse`, `phm\HttpWebdriverClient\...\Client\Guzzle\Response`, `phm\HttpWebdriverClient\...esponse\BrowserResponse`, `whm\Smoke\Http\ConnectionRefusedResponse`, `whm\Smoke\Http\ErrorResponse`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
36
37			foreach ($images as $image) {
38			/* @var $image Uri */
39			if ($currentUri->getHost($this->depth) !== $image->getHost($this->depth)) {
40			$foreignImages[] = (string)$image;
41			}
42			}
43
44			$this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found (' . implode(', ', $foreignImages) . ')');
45			}
46			}
47

phmLabs / Smoke

ForeignDomainImageRule::doValidation() A last analyzed 2019-05-12 19:55 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ForeignDomainImageRule::doValidation() A
last analyzed 2019-05-12 19:55 UTC